Programming Forums > Application Development > C++

InfoGeek · Apr 28th, 2006, 2:35 PM

I've this li'l program.

#include<iostream>
#include<string>
#include<sstream>
#include<cstdlib>
using namespace std;

//function to print the error message and terminate the program.
void err_quit(string msg)
{
	cerr<<msg;
	exit(1);
}

int main()
{
	char line[200],rest[200];
	string line1;
	stringstream ss;
	char token;
	int id;
	while(true)
	{
		
		cin.getline(line,200);
		
		if(!cin.good())
			err_quit("Cin failed");
		
		line1=line;
		ss.str(line1);
		ss>>rest;
		if(!ss.good())
			err_quit("ss failed at rest");
		cout<<rest<<endl;
	}
return 0;
}

Sample run:

(Toggle Plain Text)

234 a aaa
234
aaa a aaa
aaa
aaa<space>
aaa
aaa
ss failed at rest.

Don't know what's wrong but it expects a space after the word if I enter only one word.

nnxion · Apr 28th, 2006, 2:55 PM

Something like this suit you better?:

(Toggle Plain Text)

#include <iostream>
#include <string>
#include <sstream>

// TM DaWei
void uhOh(std::string TroubleInRiverCity)
{
	std::cerr << TroubleInRiverCity << std::endl;
	exit(1);
}

int main()
{
    std::string myString;
    while (getline ( std::cin, myString ))
    {
        std::istringstream iss(myString);
        iss >> myString;
        if (!iss)
            std::cout << "Bad input" << std::endl;
        else
            std::cout << "You entered: " << iss.str() << std::endl;
    }
    return 0;
}

Of course you can make it a normal stringstream instead of just an input stringstream, and/or put the stringstream outside the loop.

InfoGeek · Apr 28th, 2006, 8:20 PM

I made a few changes to your program(underlined).

(Toggle Plain Text)

#include <iostream>
#include <string>
#include <sstream>

// TM DaWei
void uhOh(std::string TroubleInRiverCity)
{
	std::cerr << TroubleInRiverCity << std::endl;
	exit(1);
}

int main()
{
    std::string myString;
    std::istringstream iss;

    while (std::getline ( std::cin, myString ))
    {
        iss.str(myString);
        iss >> myString;
        if (!iss)
            std::cout << "Bad input" << std::endl;
        else
            std::cout << "You entered: " << myString << std::endl;

	}
    return 0;
}

Sample run:

(Toggle Plain Text)

aaaa<space>
You entered: aaaa
bbb
You entered: bbb
ccc
Bad Input.
ddd
Bad Input.

DaWei · Apr 28th, 2006, 8:49 PM

I went to the doc and said, "Hey, Doc, my back hurts when I bend over to pick up my shoes!" He jes' said, "W'al.....don't DO that....".

lectricpharaoh · Apr 29th, 2006, 2:20 AM

Quote:

Originally Posted by DaWei

I went to the doc and said, "Hey, Doc, my back hurts when I bend over to pick up my shoes!" He jes' said, "W'al.....don't DO that....".

Or the old guy goes to the doctor, and says, "Doc, I can't pee!"

"How old are you?" asks the doctor.

"Eighty-seven!" replies the man.

"Well," says the doctor, "haven't you peed enough?"

nnxion · Apr 29th, 2006, 8:46 AM

Well this is probably a very bad way of doing it, but it works

(Toggle Plain Text)

#include <iostream>
#include <sstream>

// TM DaWei
void uhOh(std::string TroubleInRiverCity)
{
	std::cerr << TroubleInRiverCity << std::endl;
	exit(1);
}

int main()
{
	std::string myString;
	std::istringstream iss;

	while (std::getline ( std::cin, myString ))
	{
		if(myString == "")
		{
			std::cout << "Enter some text" << std::endl;
			continue;
		}
			iss.str(myString);
		iss >> myString;

		if (!iss)
		{
			uhOh("Bad input");

			if(iss.bad())
				uhOh("Very bad");
		}

		else
		{
			std::cout << "You entered: " << iss.str() << std::endl;
			iss.clear(); // probably very bad!!
		}
	}
	return 0;
}

If someone knows how to do it right, then please say so.

Apr 28th, 2006, 2:35 PM	#1
InfoGeek Professional Programmer Join Date: Jun 2005 Location: India, The great. Posts: 435 Rep Power: 4	stringstream expects a space at the end of input? I've this li'l program. (Toggle Plain Text) #include<iostream> #include<string> #include<sstream> #include<cstdlib> using namespace std; //function to print the error message and terminate the program. void err_quit(string msg) { cerr<<msg; exit(1); } int main() { char line[200],rest[200]; string line1; stringstream ss; char token; int id; while(true) { cin.getline(line,200); if(!cin.good()) err_quit("Cin failed"); line1=line; ss.str(line1); ss>>rest; if(!ss.good()) err_quit("ss failed at rest"); cout<<rest<<endl; } return 0; } #include<iostream> #include<string> #include<sstream> #include<cstdlib> using namespace std; //function to print the error message and terminate the program. void err_quit(string msg) { cerr<<msg; exit(1); } int main() { char line[200],rest[200]; string line1; stringstream ss; char token; int id; while(true) { cin.getline(line,200); if(!cin.good()) err_quit("Cin failed"); line1=line; ss.str(line1); ss>>rest; if(!ss.good()) err_quit("ss failed at rest"); cout<<rest<<endl; } return 0; } Sample run: (Toggle Plain Text) 234 a aaa 234 aaa a aaa aaa aaa<space> aaa aaa ss failed at rest. 234 a aaa 234 aaa a aaa aaa aaa<space> aaa aaa ss failed at rest. Don't know what's wrong but it expects a space after the word if I enter only one word. __________________ PFO - My daily dose of technology.

Apr 28th, 2006, 2:55 PM	#2
nnxion Programming Guru Join Date: Jun 2005 Location: elemental plane Posts: 1,429 Rep Power: 5	Something like this suit you better?: (Toggle Plain Text) #include <iostream> #include <string> #include <sstream> // TM DaWei void uhOh(std::string TroubleInRiverCity) { std::cerr << TroubleInRiverCity << std::endl; exit(1); } int main() { std::string myString; while (getline ( std::cin, myString )) { std::istringstream iss(myString); iss >> myString; if (!iss) std::cout << "Bad input" << std::endl; else std::cout << "You entered: " << iss.str() << std::endl; } return 0; } #include <iostream> #include <string> #include <sstream> // TM DaWei void uhOh(std::string TroubleInRiverCity) { std::cerr << TroubleInRiverCity << std::endl; exit(1); } int main() { std::string myString; while (getline ( std::cin, myString )) { std::istringstream iss(myString); iss >> myString; if (!iss) std::cout << "Bad input" << std::endl; else std::cout << "You entered: " << iss.str() << std::endl; } return 0; } Of course you can make it a normal stringstream instead of just an input stringstream, and/or put the stringstream outside the loop. __________________ "Employ your time in improving yourself by other men's writings, so that you shall gain easily what others have labored hard for." -- Socrates

Apr 28th, 2006, 8:20 PM	#3
InfoGeek Professional Programmer Join Date: Jun 2005 Location: India, The great. Posts: 435 Rep Power: 4	I made a few changes to your program(underlined). (Toggle Plain Text) #include <iostream> #include <string> #include <sstream> // TM DaWei void uhOh(std::string TroubleInRiverCity) { std::cerr << TroubleInRiverCity << std::endl; exit(1); } int main() { std::string myString; std::istringstream iss; while (std::getline ( std::cin, myString )) { iss.str(myString); iss >> myString; if (!iss) std::cout << "Bad input" << std::endl; else std::cout << "You entered: " << myString << std::endl; } return 0; } #include <iostream> #include <string> #include <sstream> // TM DaWei void uhOh(std::string TroubleInRiverCity) { std::cerr << TroubleInRiverCity << std::endl; exit(1); } int main() { std::string myString; std::istringstream iss; while (std::getline ( std::cin, myString )) { iss.str(myString); iss >> myString; if (!iss) std::cout << "Bad input" << std::endl; else std::cout << "You entered: " << myString << std::endl; } return 0; } Sample run: (Toggle Plain Text) aaaa<space> You entered: aaaa bbb You entered: bbb ccc Bad Input. ddd Bad Input. aaaa<space> You entered: aaaa bbb You entered: bbb ccc Bad Input. ddd Bad Input. __________________ PFO - My daily dose of technology.

Apr 28th, 2006, 8:49 PM	#4
DaWei Resident Grouch Join Date: Jun 2005 Posts: 6,453 Rep Power: 10	I went to the doc and said, "Hey, Doc, my back hurts when I bend over to pick up my shoes!" He jes' said, "W'al.....don't DO that....". __________________ Abstraction doesn't make it impossible to write bad code; it makes it possible to write superior code. Contributor's Corner: Grumpy on C++ Exceptions DaWei on Pointers

Apr 29th, 2006, 8:46 AM	#6
nnxion Programming Guru Join Date: Jun 2005 Location: elemental plane Posts: 1,429 Rep Power: 5	Well this is probably a very bad way of doing it, but it works (Toggle Plain Text) #include <iostream> #include <sstream> // TM DaWei void uhOh(std::string TroubleInRiverCity) { std::cerr << TroubleInRiverCity << std::endl; exit(1); } int main() { std::string myString; std::istringstream iss; while (std::getline ( std::cin, myString )) { if(myString == "") { std::cout << "Enter some text" << std::endl; continue; } iss.str(myString); iss >> myString; if (!iss) { uhOh("Bad input"); if(iss.bad()) uhOh("Very bad"); } else { std::cout << "You entered: " << iss.str() << std::endl; iss.clear(); // probably very bad!! } } return 0; } #include <iostream> #include <sstream> // TM DaWei void uhOh(std::string TroubleInRiverCity) { std::cerr << TroubleInRiverCity << std::endl; exit(1); } int main() { std::string myString; std::istringstream iss; while (std::getline ( std::cin, myString )) { if(myString == "") { std::cout << "Enter some text" << std::endl; continue; } iss.str(myString); iss >> myString; if (!iss) { uhOh("Bad input"); if(iss.bad()) uhOh("Very bad"); } else { std::cout << "You entered: " << iss.str() << std::endl; iss.clear(); // probably very bad!! } } return 0; } If someone knows how to do it right, then please say so. __________________ "Employ your time in improving yourself by other men's writings, so that you shall gain easily what others have labored hard for." -- Socrates

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Programming Forums > Application Development > C++

stringstream expects a space at the end of input?