Dark95

'm having abit of trouble creating a login can someone run this code and see if it works

JAVA DAO
package SportsUserwebsite;

import java.io.*;
import java.sql.*;
import javax.naming.*;
import javax.sql.*;
import java.util.*;

public class SporticusUsersDAO
{
private Connection con;
private ResultSet loginSportsReset;
private ResultSet checkSportsUserReset;
private PreparedStatement insertSportsUser;
private PreparedStatement loginSportsUser;

private String Sportsusername;
private String FullName;
private String Address;
private String city;
private String country;
private String emailaddress;
private String userpassword;

private boolean UserLoginValid;

public SporticusUsersDAO() throws SQLException, NamingException
{

Context init = new InitialContext();
Context ctx = (Context) init.lookup("java:comp/env");
DataSource ds = (DataSource) ctx.lookup("jdbc/myDatabase");
con = ds.getConnection();
System.out.println("DB Connected");
insertSportsUser = con.prepareStatement("INSERT into SPORTSUSERS values(SportsuserID_seq.nextval,?,?,?,?,?,?,?,?,?,?,?,'','','','','1')");
loginSportsUser = con.prepareStatement("SELECT Sportsusername,userpassword FROM SPORTSUSERS");
}

//set methods
public void setSportsUsername(String SportsUsernameS)
{
Sportsusername = SportsUsernameS;
}
public void setFullName(String FullNameS)
{
FullName = FullNameS;
}
public void setAddress(String AddressS)
{
Address = AddressS;
}
public void setcity(String cityS)
{city=cityS;
}
public void setcountry(String countryS)
{ country = countryS;
}
public void setemailaddress(String emailaddressS)
{
emailaddress = emailaddressS;
}
public void setuserpassword(String userpasswordS)
{
userpassword = userpasswordS;
}


//get methods
public String getSportsUsername()
{
return Sportsusername;
}
public String getFullName()
{
return FullName;
}
public String getAddress()
{
return Address;
}
public String getcity()
{
return city;
}
public String getcountry()
{
return country;
}
public String getemailaddress()
{
return emailaddress;
}
public String getuserpassword()
{
return userpassword;
}

public boolean getUserLoginValid()
{
return UserLoginValid;
}

private boolean SportsUserNotFound = false;
public boolean getSportsUserNotFound()
{
return SportsUserNotFound;
}



public void SportsUserLogin()
{
String usernameLogin;
String passwordLogin;

System.out.println(getSportsUsername());
System.out.println(getuserpassword());
System.out.println(getUserLoginValid());

try
{
Statement stmt = con.createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_READ_ONLY);
loginSportsReset=stmt.executeQuery("SELECT Sportsusername,userpassword FROM SPORTSUSERS WHERE Sportsusername='"+getSportsUsername()+"'");

while(loginSportsReset.next())
{
usernameLogin=loginSportsReset.getString(1);
passwordLogin=loginSportsReset.getString(2);

if(usernameLogin.equals(getSportsUsername())&&passwordLogin.equals(getuserpassword()))
{
System.out.println("The user is now logged in");
UserLoginValid=true;
}

else if(!usernameLogin.equals(getSportsUsername())||!passwordLogin.equals(getuserpassword()))
{
System.out.println("The user is not logged in, please try again");
UserLoginValid=false;
}

}

}


catch (SQLException e)
{
System.out.print("Unfortunately an error has occurred");
e.printStackTrace();
}

finally
{
try{loginSportsReset.close(); }
catch(Exception ex) {}
System.out.println("Connection to DataBase closed");
}
}

private boolean RegisterSuccess;
public boolean getRegisterSuccess() { return RegisterSuccess;}

public void RegisterToSite()
{
String usernameRegister;
try
{
Statement stmt = con.createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_READ_ONLY);
checkSportsUserReset = stmt.executeQuery("SELECT Sportsusername FROM SPORTSUSERS WHERE Sportsusername='"+getSportsUsername()+"'");


if(checkSportsUserReset.next())
{
usernameRegister = checkSportsUserReset.getString(1);
if(usernameRegister.equals(getSportsUsername()))
{
System.out.println("Username already taken");
RegisterSuccess = false;
}
}

else
{

try
{
insertSportsUser.setString(1,getSportsUsername());
insertSportsUser.setString(2,getFullName());
insertSportsUser.setString(3,getAddress());
insertSportsUser.setString(4,getcity());
insertSportsUser.setString(5,getcountry());
insertSportsUser.setString(6,getemailaddress());
insertSportsUser.setString(7,getuserpassword());

insertSportsUser.executeUpdate();
RegisterSuccess=true;
System.out.println("User has been successfully added to the Database for the site\n");
}

catch (SQLException e)
{
System.out.print("Unfortunately an an error has occurred");
RegisterSuccess = false;
e.printStackTrace();
}
}
}
catch (SQLException e)
{
System.out.print("Unfortunately an an error has occurred");
e.printStackTrace();
}
}
}

JSPcode
<jsp:useBean id="myForm" class="SportsUserwebsite.SporticusUsersDAO" scope="session" />
<jsp:setProperty name="myForm" property="*"/>

<%
myForm.SportsUserLogin();
if(myForm.getUserLoginValid() == true)
{
%>
<jsp:forward page="Home.htm" />
<%
}
else if(myForm.getUserLoginValid() == false)
{
%>
<jsp:forward page="login.htm" />
<%
}
else if(myForm.getSportsUserNotFound() == true)
{
%>
<jsp:forward page="login.htm" />
<%
}
%>

Database Tables
CREATE TABLE SPORTSUSERS
(
SportsuserID NUMBER NOT NULL,
SportsUsername VARCHAR2(20) NOT NULL,
FullName VARCHAR2(20) NOT NULL,
Address VARCHAR2(20) NOT NULL,
city VARCHAR2(15) NOT NULL,
country VARCHAR2(20) NOT NULL,
emailaddress VARCHAR2(100) NOT NULL,
userpassword VARCHAR2(15) NOT NULL,
creditCardNo VARCHAR2(16),
creditCardType VARCHAR2(10)

);

Arevos

Gah! Use [code] tags!

Toro

yeah, no one will read your code now just b/c you dont have those tags.

Dark95

[package SportsUserwebsite;

import java.io.*;
import java.sql.*;
import javax.naming.*;
import javax.sql.*;
import java.util.*;

public class SporticusProductsDAO
{
private Connection conn;
private PreparedStatement selectBySportsProdName;
private PreparedStatement updateSportsProdPrice;
private PreparedStatement insertSportsProduct;
private ResultSet checkSportsProdRset;
private ResultSet SportsProdResultSet;
private ResultSet getSportsProductData;

private String SportsProdID;
private String SportsProdName;
private String SportsProdDesc;
private String SportsProdCategory;
private String SportsProdPrice;
private String SportsProdNumsold;
private String SportsProdInStock;
private String SportsProdImage;

public SporticusProductsDAO() throws SQLException, NamingException
{

Context init = new InitialContext();
Context ctx = (Context) init.lookup("java:comp/env");
DataSource ds = (DataSource) ctx.lookup("jdbc/myDatabase");
conn = ds.getConnection();
System.out.println("DB Connected");
insertSportsProduct = conn.prepareStatement("INSERT into SPORTSPRODUCTS values(SportsProdID_seq.nextval,?,?,?,?,?,?,?,?,?,?,?,'','','','','1')");
updateSportsProdPrice = conn.prepareStatement("UPDATE SPORTSPRODUCTS SET SportsProd_Price = ? WHERE SportsProd_Name = ?");
}

public void setSportsProdID(String ProdID) {SportsProdID = ProdID;}
public void setSportsProdName(String ProdName) {SportsProdName = ProdName;}
public void setSportsProdDesc(String ProdDesc) {SportsProdDesc = ProdDesc;}
public void setSportsProdCategory(String ProdCategory) {SportsProdCategory = ProdCategory;}
public void setSportsProdPrice(String ProdPrice) {SportsProdPrice = ProdPrice;}
public void setSportsProdNumsold(String ProdNumsold) {SportsProdNumsold = ProdNumsold;}
public void setSportsProdInStock(String ProdInStock) {SportsProdInStock = ProdInStock;}
public void setSportsProdImage(String ProdImage) {SportsProdImage = ProdImage;}


public String getSportsProdID() { return SportsProdID; }
public String getSportsProdName() { return SportsProdName; }
public String getSportsProdDesc() { return SportsProdDesc; }
public String getSportsProdCategory() { return SportsProdCategory; }
public String getSportsProdPrice() { return SportsProdPrice; }
public String getSportsProdNumsold() { return SportsProdNumsold; }
public String getSportsProdInStock() { return SportsProdInStock; }
public String getSportsProdImage() { return SportsProdImage; }


public List selectBySportsProdName(String SportsProdName) throws SQLException
{
ResultSet results = null;
results = null;
try {
//selectByTitleID.setString(1,tID);
Statement stmt = conn.createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_READ_ONLY);
SportsProdResultSet = stmt.executeQuery("SELECT SportsProdName,SportsProdDesc, FROM SPORTSPRODUCTS WHERE SportsProdName='"+getSportsProdName()+"'");

while(SportsProdResultSet.next())
System.out.println(SportsProdResultSet.getString(1)+ SportsProdResultSet.getString(2) +""+SportsProdResultSet.getString(3));
}


catch (SQLException e)
{
System.out.print("SQL Exception " + e);
System.exit(1);
}
return SportsProdResultSet;
}

/*
public ResultSet getSportsProductData(String query)
{
String SportsProdID;
String SportsProdName;
String SportsProdDesc;
String SportsProdCategory;
String SportsProdPrice;
String SportsProdNumsold;
String SportsProdInStock;
String SportsProdImage;

try
{
select = conn.createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_READ_ONLY);
getSportsProductData = select.executeQuery(query);

getData.beforeFirst();
getData.next();


System.out.println(getSportsProductData.getString("SportsProdID"));
System.out.println(getSportsProductData.getString("SportsProdName"));
System.out.println(getSportsProductData.getString("SportsProdDesc"));
System.out.println(getSportsProductData.getString("SportsProdCategory"));
System.out.println(getSportsProductData.getString("SportsProdPrice"));
System.out.println(getSportsProductData.getString("SportsProdNumsold"));
System.out.println(getSportsProductData.getString("SportsProdInStock"));
System.out.println(getSportsProductData.getString("SportsProdImage"));
}

catch (SQLException e)
{
System.out.println("SQL Exception" + e);
//System.exit(1);
}
return getSportsProductData;
}

public void closeConnection()
{
try
{
conn.close();
}
catch(SQLException e)
{

}
}
*/


public void addSportsProduct( String SportsProdID,
String SportsProdName,String SportsProdDesc,String SportsProdCategory,
String SportsProdPrice,String SportsProdNumsold,String SportsProdInStock,
String SportsProdImage)//add new product
{


//int cust_no = num1.intValue();

String prod = null;

try
{
conn.setAutoCommit(false);
Statement stmt = conn.createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_READ_ONLY);

checkSportsProdRset = stmt.executeQuery("INSERT INTO products VALUES(prod_id.NEXTVAL,'"+ getSportsProdName() +"','"+ getSportsProdDesc() +"','"+ getSportsProdCategory() +"','" + getSportsProdPrice() +"','"+ getSportsProdNumsold() +"','"+ getSportsProdInStock() +"','"+getSportsProdImage() +"','"+ "')");


try
{
conn.commit();
}

catch(SQLException e)
{
conn.rollback();
System.out.print("SQLException: could not commit" + e);
}
}
catch(SQLException e)
{
System.out.print("SQL Exception" + e);
e.printStackTrace();
}
try
{
conn.setAutoCommit(true);
}
catch(SQLException e)
{
System.out.print("SQL Exception" + e);
}
}
}
]









[<jsp:useBean id="myForm" class="Sportswebsite.UsersDAO" scope="session" />
<jsp:setProperty name="myForm" property="*"/>

<%
myForm.login();
if(myForm.getvalidLogin() == true)
{
%>
<jsp:forward page="Home.htm" />
<%
}
else if(myForm.getvalidLogin() == false)
{
%>
<jsp:forward page="login.htm" />
<%
}
else if(myForm.getUserNotFound() == true)
{
%>
<jsp:forward page="login.htm" />
<%
}
%>]




[CREATE TABLE SPORTSUSERS
(
SportsuserID NUMBER NOT NULL,
SportsUsername VARCHAR2(20) NOT NULL,
FullName VARCHAR2(20) NOT NULL,
Address VARCHAR2(20) NOT NULL,
city VARCHAR2(15) NOT NULL,
country VARCHAR2(20) NOT NULL,
emailaddress VARCHAR2(100) NOT NULL,
userpassword VARCHAR2(15) NOT NULL,
creditCardNo VARCHAR2(16),
creditCardType VARCHAR2(10)

);]