Programming Forums > Web Development and Design > JavaScript and Client-Side Browser Scripting

forcerr · Mar 9th, 2006, 9:20 AM

gives me an error, and doesnt link the printers in KS1 or KS2, any ideas??

error is... Expected: Next

HELLPPP!!!

' -- West Vew Primary School --
' Classroom Logon Script
' 1. Maps Network Drives
' 2. Maps Printers
' 3. Sets correct printer, according to keystage
'----------------------------------------------------------

Option Explicit
Dim objNetwork, Printer1, Printer2, Printer3, PrinterDriver1, PrinterDriver2, PrinterDriver3, Server, adsDomainGroups


'-- Setting Objects --
Set objNetwork = CreateObject("WScript.Network")
Set adsDomainGroups = GetObject("WinNT://" & domain)

'-- Read security group membership --
adsDomainGroups.Filter = Array("Group")
For Each adsGroup in adsDomainGroups
 Group = UCase(adsgroup.name)


'-- Removes the networked drives --
 On Error Resume Next
objNetwork.RemoveNetworkDrive "s:"
objNetwork.RemoveNetworkDrive "x:"



'-- Connects Printers --
Printer1 = "\\server\IT1"
Printer2 = "\\server\IR1600"
Printer3 = "\\server\KS1Printer"
PrinterDriver1 = "HP Laserjet 1300 PCL 5e"
PrinterDriver2 = "Canon iR1600-2000 PCL5e"
PrinterDriver3 = "Brother HL-1450 series"
objNetwork.AddWindowsPrinterConnection Printer1, PrinterDriver1
objNetwork.AddWindowsPrinterConnection Printer2, PrinterDriver2
objNetwork.AddWindowsPrinterConnection Printer3, PrinterDriver3

if group = UCASE("ks1") then
	objNetwork.SetDefaultPrinter Printer3
elseif group = UCASE("ks2") then
	objNetwork.SetDefaultPrinter Printer1
end if


'-- Maps Drives -- 
Server = "\\server"
objNetwork.MapNetworkDrive "s:", server & "\software"
objNetwork.MapNetworkDrive "x:", server & "\shared"


WScript.Quit

Infinite Recursion · Mar 9th, 2006, 9:32 AM

sounds like your FOR loop is missing a NEXT statement...
for reference: http://www.w3schools.com/vbscript/vbscript_looping.asp

forcerr · Mar 9th, 2006, 9:37 AM

Quote:

Originally Posted by Infinite Recursion

sounds like your FOR loop is missing a NEXT statement...
for reference: http://www.w3schools.com/vbscript/vbscript_looping.asp

what for loop??? sorry i'm not experienced with VB SCript at all

Pizentios · Mar 9th, 2006, 10:09 AM

the for loop that you have in your code ofcourse :-P

this is your code

(Toggle Plain Text)

For Each adsGroup in adsDomainGroups
 Group = UCase(adsgroup.name)

this is what it should be:

(Toggle Plain Text)

For Each adsGroup in adsDomainGroups
 Group = UCase(adsgroup.name)
Next

forcerr · Mar 9th, 2006, 10:30 AM

ha, i didnt even see that, half asleep, long day...

now i get the error, variable is undefined 'domain', dont have a domain variable? :s

DaWei · Mar 9th, 2006, 10:57 AM

Get some sleep

.

jaspalmxtech · Mar 9th, 2006, 11:39 AM

must be missing something . . .

DaWei · Mar 9th, 2006, 11:45 AM

@ Mr. Singh:

Quote:

Originally Posted by Forum Rules

Signatures Rules:

1. NO images in signatures - Large flashing images in between every other sentence are the most annoying thing in the world, therefore absolutely NO images are allowed in forum signatures.

2. Maximum length - The maximum length of a forum signature is 4 to 5 lines.

3. Font size - Please don�t increase font size beyond the default text size.

4. Links - You may link to your site, but no affiliate, drug, pornographic, hacking, warez, or otherwise offensive links allowed.

5. Language - All forum signatures must be in English.

You might read the rules regarding spamming, also, though there is room for interpretation there.

Infinite Recursion · Mar 9th, 2006, 2:03 PM

Holy shit... could you reduce the font size on the name please?

forcerr · Mar 10th, 2006, 3:24 AM

dnt hi-jack my thread pls, pm's are for stuff like that, anyway can anyone see any problems coz i cnt???

Mar 9th, 2006, 9:20 AM	#1
forcerr Newbie Join Date: Mar 2006 Posts: 8 Rep Power: 0	my logon script HELP gives me an error, and doesnt link the printers in KS1 or KS2, any ideas?? error is... Expected: Next HELLPPP!!! (Toggle Plain Text) ' -- West Vew Primary School -- ' Classroom Logon Script ' 1. Maps Network Drives ' 2. Maps Printers ' 3. Sets correct printer, according to keystage '---------------------------------------------------------- Option Explicit Dim objNetwork, Printer1, Printer2, Printer3, PrinterDriver1, PrinterDriver2, PrinterDriver3, Server, adsDomainGroups '-- Setting Objects -- Set objNetwork = CreateObject("WScript.Network") Set adsDomainGroups = GetObject("WinNT://" & domain) '-- Read security group membership -- adsDomainGroups.Filter = Array("Group") For Each adsGroup in adsDomainGroups Group = UCase(adsgroup.name) '-- Removes the networked drives -- On Error Resume Next objNetwork.RemoveNetworkDrive "s:" objNetwork.RemoveNetworkDrive "x:" '-- Connects Printers -- Printer1 = "\\server\IT1" Printer2 = "\\server\IR1600" Printer3 = "\\server\KS1Printer" PrinterDriver1 = "HP Laserjet 1300 PCL 5e" PrinterDriver2 = "Canon iR1600-2000 PCL5e" PrinterDriver3 = "Brother HL-1450 series" objNetwork.AddWindowsPrinterConnection Printer1, PrinterDriver1 objNetwork.AddWindowsPrinterConnection Printer2, PrinterDriver2 objNetwork.AddWindowsPrinterConnection Printer3, PrinterDriver3 if group = UCASE("ks1") then objNetwork.SetDefaultPrinter Printer3 elseif group = UCASE("ks2") then objNetwork.SetDefaultPrinter Printer1 end if '-- Maps Drives -- Server = "\\server" objNetwork.MapNetworkDrive "s:", server & "\software" objNetwork.MapNetworkDrive "x:", server & "\shared" WScript.Quit ' -- West Vew Primary School -- ' Classroom Logon Script ' 1. Maps Network Drives ' 2. Maps Printers ' 3. Sets correct printer, according to keystage '---------------------------------------------------------- Option Explicit Dim objNetwork, Printer1, Printer2, Printer3, PrinterDriver1, PrinterDriver2, PrinterDriver3, Server, adsDomainGroups '-- Setting Objects -- Set objNetwork = CreateObject("WScript.Network") Set adsDomainGroups = GetObject("WinNT://" & domain) '-- Read security group membership -- adsDomainGroups.Filter = Array("Group") For Each adsGroup in adsDomainGroups Group = UCase(adsgroup.name) '-- Removes the networked drives -- On Error Resume Next objNetwork.RemoveNetworkDrive "s:" objNetwork.RemoveNetworkDrive "x:" '-- Connects Printers -- Printer1 = "\\server\IT1" Printer2 = "\\server\IR1600" Printer3 = "\\server\KS1Printer" PrinterDriver1 = "HP Laserjet 1300 PCL 5e" PrinterDriver2 = "Canon iR1600-2000 PCL5e" PrinterDriver3 = "Brother HL-1450 series" objNetwork.AddWindowsPrinterConnection Printer1, PrinterDriver1 objNetwork.AddWindowsPrinterConnection Printer2, PrinterDriver2 objNetwork.AddWindowsPrinterConnection Printer3, PrinterDriver3 if group = UCASE("ks1") then objNetwork.SetDefaultPrinter Printer3 elseif group = UCASE("ks2") then objNetwork.SetDefaultPrinter Printer1 end if '-- Maps Drives -- Server = "\\server" objNetwork.MapNetworkDrive "s:", server & "\software" objNetwork.MapNetworkDrive "x:", server & "\shared" WScript.Quit

Mar 9th, 2006, 9:32 AM	#2
Infinite Recursion Programming Guru Join Date: Jul 2004 Location: United States Posts: 3,467 Rep Power: 8	sounds like your FOR loop is missing a NEXT statement... for reference: http://www.w3schools.com/vbscript/vbscript_looping.asp __________________ http://jasonpowers.net "There are a thousand hacking at the branches of evil to one who is striking at the root."

Mar 9th, 2006, 10:09 AM	#4
Pizentios Programming Guru Join Date: May 2004 Location: Brandon, Manitoba, Canada Posts: 2,023 Rep Power: 7	the for loop that you have in your code ofcourse :-P this is your code (Toggle Plain Text) For Each adsGroup in adsDomainGroups Group = UCase(adsgroup.name) For Each adsGroup in adsDomainGroups Group = UCase(adsgroup.name) this is what it should be: (Toggle Plain Text) For Each adsGroup in adsDomainGroups Group = UCase(adsgroup.name) Next For Each adsGroup in adsDomainGroups Group = UCase(adsgroup.name) Next __________________ Profanity is the one language that all programmers understand. Check out my Blog <---updated Nov 30 2007!

Mar 9th, 2006, 10:57 AM	#6
DaWei Resident Grouch Join Date: Jun 2005 Posts: 6,453 Rep Power: 10	Get some sleep . __________________ Abstraction doesn't make it impossible to write bad code; it makes it possible to write superior code. Contributor's Corner: Grumpy on C++ Exceptions DaWei on Pointers

Mar 9th, 2006, 11:39 AM	#7
jaspalmxtech Newbie Join Date: Oct 2005 Location: css ajax pear smarty php asp scripts web templates downloads jaspal forum http://www.aadhunik.com/ Posts: 3 Rep Power: 0	must be missing something . . . __________________ css ajax pear smarty php asp scripts web templates downloads jaspal forum http://www.aadhunik.com/

Mar 9th, 2006, 10:30 AM	#5
forcerr Newbie Join Date: Mar 2006 Posts: 8 Rep Power: 0	ha, i didnt even see that, half asleep, long day... now i get the error, variable is undefined 'domain', dont have a domain variable? :s

Mar 9th, 2006, 2:03 PM	#9
Infinite Recursion Programming Guru Join Date: Jul 2004 Location: United States Posts: 3,467 Rep Power: 8	Holy shit... could you reduce the font size on the name please? __________________ http://jasonpowers.net "There are a thousand hacking at the branches of evil to one who is striking at the root."

Mar 10th, 2006, 3:24 AM	#10
forcerr Newbie Join Date: Mar 2006 Posts: 8 Rep Power: 0	dnt hi-jack my thread pls, pm's are for stuff like that, anyway can anyone see any problems coz i cnt???

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Programming Forums > Web Development and Design > JavaScript and Client-Side Browser Scripting

my logon script HELP