Obtruse_Man4

I'm trying to incorporate a secure download script into an already coded file management system. I want the url path to be download.php?file=, and then the file name. The file name is taken from the variable .$file. How do I add the variable onto the end of the url? What I currently have below doesn't seem to work. It passed the error:

[PHP]$file_string = "<li>Get file: <a href="download.php?file=.$file."> ".$file."</a> (".human_file_size(filesize($file)).")</li>";[/PHP]

__________________
"I have many layer-eight problems in my life, including myself."

magic_e

Your causing php to think your finished with the string when you use the double quotes (") for the href=",

so this
[PHP]$file_string = "<li>Get file: <a href="download.php?file=.$file."> ".$file."</a> (".human_file_size(filesize($file)).")</li>";[/PHP]

should be this
[PHP]
$file_string = '<li>Get file: <a href="download.php?file='.$file.'"> "'.$file.'"</a> ("'.human_file_size(filesize($file)).'")</li>';[/PHP]


hope it helps

Magic E

Ooble

You can also use the backslash to "escape" the quotes:
[php]$file_string = "<li>Get file: <a href=\"download.php?file=$file\">$file</a> (" . human_file_size(filesize($file)) . ")</li>";
$file_string = '<li>Get file: <a href="download.php?file=' . $file . '"> "' . $file . '"</a> ("' . human_file_size(filesize($file)) . '")</li>';[/php]

__________________
Me :: You :: Them

Lich

That's the method I prefer, works for all the characters that PHP might interpret wrong

__________________
--John Cruz
Web Developer
www.cruzweb.net

Polyphemus_

Same for me

OpenLoop

And me.

But I don't use PHP, i just saw an opportunity to increase my post count.

Ooble

I prefer using single quotes myself. Because strings in single quotes aren't checked for variable names, they work faster.

__________________
Me :: You :: Them

Lich

In some cases it's alright to use, I just have the \ habit from unix and whatnot, so I stick with it

__________________
--John Cruz
Web Developer
www.cruzweb.net