Programming Forums > Application Development > C++

Brent · Aug 2nd, 2005, 12:02 PM

im created a simple chat program, but it doesnt send or receive messages very well, and you have to send a message before you can receive the one that was sent to you. does anyone have any suggestions?

here's the code for the server:

(Toggle Plain Text)

#include<winsock.h>
#include<iostream.h>
#include<string.h>
#include<conio.h>
#include<fstream.h>
#pragma comment(lib,"wsock32.lib")

#define MAX_CLIENTS 30

int net;
int client_count=0;

ofstream outfile;

char data[50];
char rdata[50];

SOCKET server;
SOCKET client;

int main()
{
	WORD sockversion;
	WSADATA wsaData;
	
	sockversion=MAKEWORD(1,1);
	WSAStartup(sockversion,&wsaData);
	
	if((server=socket(PF_INET,SOCK_STREAM,IPPROTO_TCP))!=INVALID_SOCKET)
	{
		sockaddr_in sin;
		sin.sin_family=PF_INET;
		sin.sin_port=htons(14567);
		sin.sin_addr.s_addr=INADDR_ANY;
		
		if((net=bind(server,(LPSOCKADDR)&sin,sizeof(sin)))!=SOCKET_ERROR)
		{
			if((net=listen(server,MAX_CLIENTS))!=SOCKET_ERROR)
			{
				client_count++;
				cout<<"client found\n";
				if(client_count<=MAX_CLIENTS)
				{
					if((client=accept(server,NULL,NULL))!=SOCKET_ERROR)
					{
						cout<<client_count<<'\n';
						do
						{
							cout<<"enter message: ";
							cin.get(data,49);
							cin.ignore(80,'\n');
							if((net=send(server,data,sizeof(data),NULL))!=SOCKET_ERROR || (net=recv(client,rdata,49,NULL))!=SOCKET_ERROR)
							{
								if(strlen(rdata)==NULL)
								{
									cout<<" ";
								}
								else
								{
									cout<<rdata<<'\n';
								}
							}
						}while(client_count!>MAX_CLIENTS);
					}
					else
					{
						cout<<"failed accept\n";
						WSACleanup();
						closesocket(server);
						closesocket(client);
					}
				}
				else
				{
					cout<<"server cant handle anymore clients";
					WSACleanup();
					closesocket(server);
					closesocket(client);
				}
			}
			else
			{
				client_count--;
				cout<<"failed listen\n";
				WSACleanup();
				closesocket(server);
				closesocket(client);
			}
		}
		else
		{
			cout<<"failed bind\n";
			WSACleanup();
			closesocket(server);
			closesocket(client);
		}
	}
	else
	{
		cout<<"invalid socket\n";
		WSACleanup();
		closesocket(server);
		closesocket(client);
	}
	return(client_count);
}

and here's the client:

(Toggle Plain Text)

#include<winsock.h>
#include<iostream.h>
#include<string.h>
#include<conio.h>
#include<fstream.h>
#pragma comment(lib,"wsock32.lib")

int net;
char data[50];
char rdata[50];

ofstream outfile;

SOCKET server;
SOCKET client;

int main()
{
	WORD sockversion;
	WSADATA wsaData;
	
	sockversion=MAKEWORD(1,1);
	WSAStartup(sockversion,&wsaData);
	
	if((client=socket(PF_INET,SOCK_STREAM,IPPROTO_TCP))!=INVALID_SOCKET)
	{
		sockaddr_in sin;
		sin.sin_family=PF_INET;
		sin.sin_port=htons(14567);
		sin.sin_addr.s_addr=inet_addr("127.0.0.1");
		
		sockaddr_in from;
		int fromlen=sizeof(from);
		
		if((net=connect(client,(LPSOCKADDR)&sin,sizeof(sin)))!=SOCKET_ERROR)
		{
			cout<<"<connected to "<<inet_ntoa(from.sin_addr)<<">"<<'\n';
			cout<<"<on port "<<"8888"<<">"<<'\n';
			do
			{	
				cout<<"enter a message ";
				cin.get(data,49);
				cin.ignore(80,'\n');
				cout<<rdata<<'\n';			
				if((net=send(client,data,sizeof(data),NULL))!=SOCKET_ERROR || (net=recv(server,rdata,49,NULL))!=SOCKET_ERROR)
				{
					if(strlen(rdata)==NULL)
					{
						cout<<" ";
					}
					else
					{
						cout<<rdata<<'\n';
					}
				}
			}while(!NULL);
		}
		else
		{
			cout<<"failed to connect to server\n";
			WSACleanup();
			closesocket(client);
			closesocket(server);
		}
	}
	else
	{
		cout<<"invalid socket\n";
		WSACleanup();
		closesocket(client);
		closesocket(server);
	}
}

Mjordan2nd · Aug 2nd, 2005, 12:35 PM

You'll probably have to use threads.

Brent · Aug 2nd, 2005, 6:27 PM

what the heck is that?

L7Sqr · Aug 2nd, 2005, 7:07 PM

On windows:
google says
On *nix:
man pthread

And lokks like theres now:
pthreads for win32

Brent · Aug 3rd, 2005, 3:54 PM

thanks

Brent · Aug 3rd, 2005, 4:01 PM

how would i use the select() function in these programs

rsnd · Aug 3rd, 2005, 7:05 PM

for Windows> check msdn.microsoft.com

for *nix...http://www.scit.wlv.ac.uk/~jphb/com...ets.html#select

Brent · Aug 5th, 2005, 7:39 AM

is it best to use TCP or UDP for a chat program, and could someone recomend a website with a tutorial or something.

Brent · Aug 7th, 2005, 8:41 PM

could someone show me how to do some simple multithreading

Infinite Recursion · Aug 8th, 2005, 7:52 AM

check this out:

http://www.geocities.com/SiliconVall.../dthreads.html

Aug 2nd, 2005, 12:02 PM	#1
Brent Highly Adaptive Penguin Join Date: May 2005 Location: United States Posts: 249 Rep Power: 4	problem with network program im created a simple chat program, but it doesnt send or receive messages very well, and you have to send a message before you can receive the one that was sent to you. does anyone have any suggestions? here's the code for the server: (Toggle Plain Text) #include<winsock.h> #include<iostream.h> #include<string.h> #include<conio.h> #include<fstream.h> #pragma comment(lib,"wsock32.lib") #define MAX_CLIENTS 30 int net; int client_count=0; ofstream outfile; char data[50]; char rdata[50]; SOCKET server; SOCKET client; int main() { WORD sockversion; WSADATA wsaData; sockversion=MAKEWORD(1,1); WSAStartup(sockversion,&wsaData); if((server=socket(PF_INET,SOCK_STREAM,IPPROTO_TCP))!=INVALID_SOCKET) { sockaddr_in sin; sin.sin_family=PF_INET; sin.sin_port=htons(14567); sin.sin_addr.s_addr=INADDR_ANY; if((net=bind(server,(LPSOCKADDR)&sin,sizeof(sin)))!=SOCKET_ERROR) { if((net=listen(server,MAX_CLIENTS))!=SOCKET_ERROR) { client_count++; cout<<"client found\n"; if(client_count<=MAX_CLIENTS) { if((client=accept(server,NULL,NULL))!=SOCKET_ERROR) { cout<<client_count<<'\n'; do { cout<<"enter message: "; cin.get(data,49); cin.ignore(80,'\n'); if((net=send(server,data,sizeof(data),NULL))!=SOCKET_ERROR \|\| (net=recv(client,rdata,49,NULL))!=SOCKET_ERROR) { if(strlen(rdata)==NULL) { cout<<" "; } else { cout<<rdata<<'\n'; } } }while(client_count!>MAX_CLIENTS); } else { cout<<"failed accept\n"; WSACleanup(); closesocket(server); closesocket(client); } } else { cout<<"server cant handle anymore clients"; WSACleanup(); closesocket(server); closesocket(client); } } else { client_count--; cout<<"failed listen\n"; WSACleanup(); closesocket(server); closesocket(client); } } else { cout<<"failed bind\n"; WSACleanup(); closesocket(server); closesocket(client); } } else { cout<<"invalid socket\n"; WSACleanup(); closesocket(server); closesocket(client); } return(client_count); } #include<winsock.h> #include<iostream.h> #include<string.h> #include<conio.h> #include<fstream.h> #pragma comment(lib,"wsock32.lib") #define MAX_CLIENTS 30 int net; int client_count=0; ofstream outfile; char data[50]; char rdata[50]; SOCKET server; SOCKET client; int main() { WORD sockversion; WSADATA wsaData; sockversion=MAKEWORD(1,1); WSAStartup(sockversion,&wsaData); if((server=socket(PF_INET,SOCK_STREAM,IPPROTO_TCP))!=INVALID_SOCKET) { sockaddr_in sin; sin.sin_family=PF_INET; sin.sin_port=htons(14567); sin.sin_addr.s_addr=INADDR_ANY; if((net=bind(server,(LPSOCKADDR)&sin,sizeof(sin)))!=SOCKET_ERROR) { if((net=listen(server,MAX_CLIENTS))!=SOCKET_ERROR) { client_count++; cout<<"client found\n"; if(client_count<=MAX_CLIENTS) { if((client=accept(server,NULL,NULL))!=SOCKET_ERROR) { cout<<client_count<<'\n'; do { cout<<"enter message: "; cin.get(data,49); cin.ignore(80,'\n'); if((net=send(server,data,sizeof(data),NULL))!=SOCKET_ERROR \|\| (net=recv(client,rdata,49,NULL))!=SOCKET_ERROR) { if(strlen(rdata)==NULL) { cout<<" "; } else { cout<<rdata<<'\n'; } } }while(client_count!>MAX_CLIENTS); } else { cout<<"failed accept\n"; WSACleanup(); closesocket(server); closesocket(client); } } else { cout<<"server cant handle anymore clients"; WSACleanup(); closesocket(server); closesocket(client); } } else { client_count--; cout<<"failed listen\n"; WSACleanup(); closesocket(server); closesocket(client); } } else { cout<<"failed bind\n"; WSACleanup(); closesocket(server); closesocket(client); } } else { cout<<"invalid socket\n"; WSACleanup(); closesocket(server); closesocket(client); } return(client_count); } and here's the client: (Toggle Plain Text) #include<winsock.h> #include<iostream.h> #include<string.h> #include<conio.h> #include<fstream.h> #pragma comment(lib,"wsock32.lib") int net; char data[50]; char rdata[50]; ofstream outfile; SOCKET server; SOCKET client; int main() { WORD sockversion; WSADATA wsaData; sockversion=MAKEWORD(1,1); WSAStartup(sockversion,&wsaData); if((client=socket(PF_INET,SOCK_STREAM,IPPROTO_TCP))!=INVALID_SOCKET) { sockaddr_in sin; sin.sin_family=PF_INET; sin.sin_port=htons(14567); sin.sin_addr.s_addr=inet_addr("127.0.0.1"); sockaddr_in from; int fromlen=sizeof(from); if((net=connect(client,(LPSOCKADDR)&sin,sizeof(sin)))!=SOCKET_ERROR) { cout<<"<connected to "<<inet_ntoa(from.sin_addr)<<">"<<'\n'; cout<<"<on port "<<"8888"<<">"<<'\n'; do { cout<<"enter a message "; cin.get(data,49); cin.ignore(80,'\n'); cout<<rdata<<'\n'; if((net=send(client,data,sizeof(data),NULL))!=SOCKET_ERROR \|\| (net=recv(server,rdata,49,NULL))!=SOCKET_ERROR) { if(strlen(rdata)==NULL) { cout<<" "; } else { cout<<rdata<<'\n'; } } }while(!NULL); } else { cout<<"failed to connect to server\n"; WSACleanup(); closesocket(client); closesocket(server); } } else { cout<<"invalid socket\n"; WSACleanup(); closesocket(client); closesocket(server); } } #include<winsock.h> #include<iostream.h> #include<string.h> #include<conio.h> #include<fstream.h> #pragma comment(lib,"wsock32.lib") int net; char data[50]; char rdata[50]; ofstream outfile; SOCKET server; SOCKET client; int main() { WORD sockversion; WSADATA wsaData; sockversion=MAKEWORD(1,1); WSAStartup(sockversion,&wsaData); if((client=socket(PF_INET,SOCK_STREAM,IPPROTO_TCP))!=INVALID_SOCKET) { sockaddr_in sin; sin.sin_family=PF_INET; sin.sin_port=htons(14567); sin.sin_addr.s_addr=inet_addr("127.0.0.1"); sockaddr_in from; int fromlen=sizeof(from); if((net=connect(client,(LPSOCKADDR)&sin,sizeof(sin)))!=SOCKET_ERROR) { cout<<"<connected to "<<inet_ntoa(from.sin_addr)<<">"<<'\n'; cout<<"<on port "<<"8888"<<">"<<'\n'; do { cout<<"enter a message "; cin.get(data,49); cin.ignore(80,'\n'); cout<<rdata<<'\n'; if((net=send(client,data,sizeof(data),NULL))!=SOCKET_ERROR \|\| (net=recv(server,rdata,49,NULL))!=SOCKET_ERROR) { if(strlen(rdata)==NULL) { cout<<" "; } else { cout<<rdata<<'\n'; } } }while(!NULL); } else { cout<<"failed to connect to server\n"; WSACleanup(); closesocket(client); closesocket(server); } } else { cout<<"invalid socket\n"; WSACleanup(); closesocket(client); closesocket(server); } }

Aug 2nd, 2005, 12:35 PM	#2
Mjordan2nd The Supreme Ruler Join Date: May 2004 Location: Houston Posts: 1,476 Rep Power: 6	You'll probably have to use threads. __________________ "Every gun that is made, every warship launched, every rocket signifies, in the final sense, a theft from those who hunger and are not fed, from those who are cold and are not clothed. The world in arms is not spending money alone. It is spending the sweat of its laborers, the genius of its scientists, the hopes of its children." - Dwight D. Eisenhower

Aug 2nd, 2005, 7:07 PM	#4
L7Sqr Hobbyist Programmer Join Date: Jun 2005 Location: here Posts: 114 Rep Power: 0	On windows: google says On *nix: man pthread And lokks like theres now: pthreads for win32 __________________ "...and though our kids are blessed their parents let them shoulder all the blame." - The Quiet Things That No One Ever Knows [BrandNew]

Aug 3rd, 2005, 7:05 PM	#7
rsnd Hobbyist Programmer Join Date: Jun 2005 Location: Helltown Posts: 162 Rep Power: 4	for Windows> check msdn.microsoft.com for *nix...http://www.scit.wlv.ac.uk/~jphb/com...ets.html#select __________________ Spread your wings and fly! Chicken!

Aug 8th, 2005, 7:52 AM	#10
Infinite Recursion Programming Guru Join Date: Jul 2004 Location: United States Posts: 3,466 Rep Power: 8	check this out: http://www.geocities.com/SiliconVall.../dthreads.html __________________ http://jasonpowers.net "There are a thousand hacking at the branches of evil to one who is striking at the root."

Aug 2nd, 2005, 6:27 PM	#3
Brent Highly Adaptive Penguin Join Date: May 2005 Location: United States Posts: 249 Rep Power: 4	what the heck is that?

Aug 3rd, 2005, 3:54 PM	#5
Brent Highly Adaptive Penguin Join Date: May 2005 Location: United States Posts: 249 Rep Power: 4	thanks

Aug 3rd, 2005, 4:01 PM	#6
Brent Highly Adaptive Penguin Join Date: May 2005 Location: United States Posts: 249 Rep Power: 4	how would i use the select() function in these programs

Aug 5th, 2005, 7:39 AM	#8
Brent Highly Adaptive Penguin Join Date: May 2005 Location: United States Posts: 249 Rep Power: 4	is it best to use TCP or UDP for a chat program, and could someone recomend a website with a tutorial or something.

Aug 7th, 2005, 8:41 PM	#9
Brent Highly Adaptive Penguin Join Date: May 2005 Location: United States Posts: 249 Rep Power: 4	could someone show me how to do some simple multithreading

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Programming Forums > Application Development > C++

problem with network program