Programming Forums > Script Programming > Bash / Shell Scripting

levk · Jul 22nd, 2005, 9:48 AM

I'm having problems with recognizing command line args in my script, whatever "if" I make, they all evaluate to true, what am I doing wrong? here's my test script:

(Toggle Plain Text)

#!/usr/bin/bash

if [ $1=blah ]; then
    echo no quotes
fi

if [ $1="blah" ]; then
    echo quotes
fi

if [ $1="foo" ]; then
    echo foo
fi

echo $1

And here's my output:

(Toggle Plain Text)

bash-2.05$ ./test.sh blah
no quotes
quotes
foo
blah
bash-2.05$

Thank you very much in advance

skuinders · Jul 22nd, 2005, 10:09 AM

(Toggle Plain Text)

if [ "$1" = "blah" ]; then
echo equals blah;
fi

levk · Jul 22nd, 2005, 10:26 AM

Thanks a lot, that worked; but now I have another problem: I need to execute the insides of the "if" if there was a particular argument or there were no arguments at all. Now it works for the particular arguments but givem me errors if I don't put any arguments; here's what my ifs look like:

(Toggle Plain Text)

if [ -z $1 -o "$1" = "unix" ]; then

And here's the error I'm getting:

(Toggle Plain Text)

bash-2.05$ ./logcollect.sh
./logcollect.sh: [: too many arguments
./logcollect.sh: [: too many arguments
./logcollect.sh: [: too many arguments
./logcollect.sh: [: too many arguments
./logcollect.sh: [: too many arguments
./logcollect.sh: [: too many arguments
./logcollect.sh: [: too many arguments
./logcollect.sh: [: too many arguments
./logcollect.sh: [: too many arguments
bash-2.05$

Thank you very much

Edit: it's one line for each "if" I have like that

skuinders · Jul 22nd, 2005, 10:31 AM

same fix

(Toggle Plain Text)

if [ -z "$1" -o "$1" = "unix" ]; then
   echo ok;
fi

levk · Jul 22nd, 2005, 10:35 AM

Doup! Thanks so much man

skuinders · Jul 22nd, 2005, 11:53 AM

You're welcome

Jul 22nd, 2005, 9:48 AM	#1
levk Newbie Join Date: Jul 2005 Posts: 7 Rep Power: 0	capturing and dispatching on command line arguments in bash I'm having problems with recognizing command line args in my script, whatever "if" I make, they all evaluate to true, what am I doing wrong? here's my test script: (Toggle Plain Text) #!/usr/bin/bash if [ $1=blah ]; then echo no quotes fi if [ $1="blah" ]; then echo quotes fi if [ $1="foo" ]; then echo foo fi echo $1 #!/usr/bin/bash if [ $1=blah ]; then echo no quotes fi if [ $1="blah" ]; then echo quotes fi if [ $1="foo" ]; then echo foo fi echo $1 And here's my output: (Toggle Plain Text) bash-2.05$ ./test.sh blah no quotes quotes foo blah bash-2.05$ bash-2.05$ ./test.sh blah no quotes quotes foo blah bash-2.05$ Thank you very much in advance

Jul 22nd, 2005, 10:09 AM	#2
skuinders Hobbyist Programmer Join Date: Jun 2005 Location: MA, US Posts: 204 Rep Power: 4	(Toggle Plain Text) if [ "$1" = "blah" ]; then echo equals blah; fi if [ "$1" = "blah" ]; then echo equals blah; fi __________________ "A stupid man's report of what a clever man says can never be accurate, because he unconciously translates what he hears into something he can understand." - B. Russell http://web.bryant.edu/~srk2

Jul 22nd, 2005, 10:26 AM	#3
levk Newbie Join Date: Jul 2005 Posts: 7 Rep Power: 0	Thanks a lot, that worked; but now I have another problem: I need to execute the insides of the "if" if there was a particular argument or there were no arguments at all. Now it works for the particular arguments but givem me errors if I don't put any arguments; here's what my ifs look like: (Toggle Plain Text) if [ -z $1 -o "$1" = "unix" ]; then if [ -z $1 -o "$1" = "unix" ]; then And here's the error I'm getting: (Toggle Plain Text) bash-2.05$ ./logcollect.sh ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments bash-2.05$ bash-2.05$ ./logcollect.sh ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments ./logcollect.sh: [: too many arguments bash-2.05$ Thank you very much Edit: it's one line for each "if" I have like that

Jul 22nd, 2005, 10:31 AM	#4
skuinders Hobbyist Programmer Join Date: Jun 2005 Location: MA, US Posts: 204 Rep Power: 4	same fix (Toggle Plain Text) if [ -z "$1" -o "$1" = "unix" ]; then echo ok; fi if [ -z "$1" -o "$1" = "unix" ]; then echo ok; fi __________________ "A stupid man's report of what a clever man says can never be accurate, because he unconciously translates what he hears into something he can understand." - B. Russell http://web.bryant.edu/~srk2

Jul 22nd, 2005, 11:53 AM	#6
skuinders Hobbyist Programmer Join Date: Jun 2005 Location: MA, US Posts: 204 Rep Power: 4	You're welcome __________________ "A stupid man's report of what a clever man says can never be accurate, because he unconciously translates what he hears into something he can understand." - B. Russell http://web.bryant.edu/~srk2

Jul 22nd, 2005, 10:35 AM	#5
levk Newbie Join Date: Jul 2005 Posts: 7 Rep Power: 0	Doup! Thanks so much man

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Programming Forums > Script Programming > Bash / Shell Scripting

capturing and dispatching on command line arguments in bash