Ooble

I prefer not to reinvent the wheel. Imagine if we all said stuff like that... "I need to create a presentation on our current budget for tomorrow's board meeting." "Oh, yeah, just whip an app up with GTK and the SDL - have fun!"

__________________
Me :: You :: Them

melbolt

I think it's good, here's how i look at it.

if it does exactly what you want it to and works efficiently in every environment in which you care to have it work in, then it's perfect code.

requirements!

it doesn't matter if it's the most efficient way to do it, if you want efficiency then you better do everything in assembly the loooooooooooooong way.

if your program meets the requirements perfectly, then it is a perfect program in my opinion.


it's like we say at work, "hey it works, it's good"

i do reccommend making things easier on yourself whenever possible though, time can be an issue, it's nice to investigate some useful namespaces and member functions.

looks good to me..

__________________
I have never let my schooling interfere with my education. -Mark Twain-

Xbox live gamertag: melbolt

DaWei

Doing everything in assembler the long ways doesn't produce efficiency. Even if one is talking ultimate performance, most coders have no inkling of how to achieve it, in assembler or otherwise. Melbolt's comment regarding meeting requirements is right on. Unfortunately, one of the hardest parts of the job is SETTING appropriate requirements and the other is VERIFYING if they've been met. If you can achieve both those, then, yes, it's good. Not perfect, but good. Once it's good, if it's any good, it has to last. An absolutely huge amount of the money spent on the code is spent AFTER it's been judged good. Dedicate yourself to "good", then "maintainable". Anything else is amateurish. Not a sin. Just not professional. "Not Good" is the sin, so learn to spot that stuff. You may not realize it, if your career revolves around desktop utilities and apps, but much of the code produced in the market today can be actually unsafe or life-threatening to the end user. Look to your code to be "good". If you do, accolades will follow, no need to seek them out.

__________________
Abstraction doesn't make it impossible to write bad code; it makes it possible to write superior code.
Contributor's Corner: Grumpy on C++ Exceptions DaWei on Pointers