Programming Forums > Application Development > C++

deanosrs · Feb 22nd, 2008, 10:10 AM

Hi,
I'm just trying to get two classes to succesfully be able to call functions within each others class. So I effectively have:

(Toggle Plain Text)

// in A's header file
class A {
public:
  B *b;
  void a_function(); // in this function, there's the line b->b_function2
  void a_function2();
};

// in B's header file
class B {
public:
  A *a;
  void b_function(); // in this function, there's the line a->a_function2
  void b_function2();
};

The problem I have at the moment is that I have to include in each header file, the other header file, which it doesn't like. I've also tried forward class definitions, but this doesn't work either, because the line class B; in A's header file isn't sufficient to tell A that B has a function called b_function2().

Any ideas? This has troubled me for a while and is a very difficult problem to google!!

Klarre · Feb 22nd, 2008, 10:23 AM

Google for "circular dependency".

deanosrs · Feb 22nd, 2008, 2:20 PM

I'm confused. Does that mean there is no possible way of doing this at all? Because that's what my google searching seems to suggest. How do people usually get round this problem? I tried making all my classes basically implement interfaces and include an interface file, but that gave me a linker error. Is there no way to do forward declaration of methods as well as classes?

grumpy · Feb 22nd, 2008, 2:41 PM

Use forward declarations and #include guards.

The forward declarations: in A's header file put a line "class B;" before the declaration of class A, and in B's header file place a line "class A;" before the declaration of class B. Do not #include the headers within each other. #include both header files within the .cpp files.

Also put an include guard in both files, to avoid circular inclusions (A.h #including B.h #including A.h ..... ad infinitum)

The net effect is that A's header will look like this. B's will be in a similar form.

(Toggle Plain Text)

#ifndef SOME_MACRO_UNIQUE_TO_A_HEADER
#define SOME_MACRO_UNIQUE_TO_A_HEADER

class B;

class A {
public:
  B *b;
  void a_function(); // in this function, there's the line b->b_function2
  void a_function2();
};

#endif

Keep in mind that forward references only allow declarations of pointers and references to the forward-declared class. If you need to call member functions, a forward definition is insufficient. it is necessary to have a complete definition (i.e. in code that calls a member function of A, it is necessary to #include A's header file).

Jabo · Feb 22nd, 2008, 6:51 PM

Wouldn't making each class a friend class to the other do the job for just calling functions?

grumpy · Feb 22nd, 2008, 11:46 PM

Quote:

Originally Posted by Jabo

Wouldn't making each class a friend class to the other do the job for just calling functions?

No.

Seif · Feb 23rd, 2008, 3:53 AM

Quote:

Originally Posted by Jabo

Wouldn't making each class a friend class to the other do the job for just calling functions?

The friend keyword would allow the classes to access all of each others public, private and protected data and functions. but would not resolve this cyclic dependancy issue.

Feb 22nd, 2008, 10:10 AM	#1
deanosrs Programmer Join Date: Apr 2006 Location: Bristol, UK Posts: 31 Rep Power: 0	two classes, call each others functions - how?!! Hi, I'm just trying to get two classes to succesfully be able to call functions within each others class. So I effectively have: (Toggle Plain Text) // in A's header file class A { public: B b; void a_function(); // in this function, there's the line b->b_function2 void a_function2(); }; // in B's header file class B { public: A a; void b_function(); // in this function, there's the line a->a_function2 void b_function2(); }; // in A's header file class A { public: B b; void a_function(); // in this function, there's the line b->b_function2 void a_function2(); }; // in B's header file class B { public: A a; void b_function(); // in this function, there's the line a->a_function2 void b_function2(); }; The problem I have at the moment is that I have to include in each header file, the other header file, which it doesn't like. I've also tried forward class definitions, but this doesn't work either, because the line class B; in A's header file isn't sufficient to tell A that B has a function called b_function2(). Any ideas? This has troubled me for a while and is a very difficult problem to google!!

Feb 22nd, 2008, 10:23 AM	#2
Klarre Game engine designer Join Date: May 2005 Location: Sweden Posts: 288 Rep Power: 4	Re: two classes, call each others functions - how?!! Google for "circular dependency". __________________ http://www.klarre.se

Feb 22nd, 2008, 2:20 PM	#3
deanosrs Programmer Join Date: Apr 2006 Location: Bristol, UK Posts: 31 Rep Power: 0	Re: two classes, call each others functions - how?!! I'm confused. Does that mean there is no possible way of doing this at all? Because that's what my google searching seems to suggest. How do people usually get round this problem? I tried making all my classes basically implement interfaces and include an interface file, but that gave me a linker error. Is there no way to do forward declaration of methods as well as classes?

Feb 22nd, 2008, 2:41 PM	#4
grumpy Programming Guru Join Date: Jun 2005 Location: Adelaide, South Australia Posts: 1,192 Rep Power: 5	Re: two classes, call each others functions - how?!! Use forward declarations and #include guards. The forward declarations: in A's header file put a line "class B;" before the declaration of class A, and in B's header file place a line "class A;" before the declaration of class B. Do not #include the headers within each other. #include both header files within the .cpp files. Also put an include guard in both files, to avoid circular inclusions (A.h #including B.h #including A.h ..... ad infinitum) The net effect is that A's header will look like this. B's will be in a similar form. (Toggle Plain Text) #ifndef SOME_MACRO_UNIQUE_TO_A_HEADER #define SOME_MACRO_UNIQUE_TO_A_HEADER class B; class A { public: B b; void a_function(); // in this function, there's the line b->b_function2 void a_function2(); }; #endif #ifndef SOME_MACRO_UNIQUE_TO_A_HEADER #define SOME_MACRO_UNIQUE_TO_A_HEADER class B; class A { public: B b; void a_function(); // in this function, there's the line b->b_function2 void a_function2(); }; #endif Keep in mind that forward references only allow declarations of pointers and references to the forward-declared class. If you need to call member functions, a forward definition is insufficient. it is necessary to have a complete definition (i.e. in code that calls a member function of A, it is necessary to #include A's header file).

Feb 22nd, 2008, 6:51 PM	#5
Jabo Not a user? Join Date: Sep 2007 Posts: 232 Rep Power: 1	Re: two classes, call each others functions - how?!! Wouldn't making each class a friend class to the other do the job for just calling functions?

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Using internal classes in STL functions	manannan	C++	4	May 31st, 2006 1:25 AM
What is the point of pure virtual functions?	aznluvsmc	C++	12	Apr 14th, 2006 6:48 PM
Could some please explain classes to me...	TCStyle	C++	10	Feb 20th, 2006 3:51 PM
Exporting Functions	victorsk	Visual Basic	1	May 18th, 2005 2:32 PM
User-defined creatNode and deleteNode functions for a doubly-linked list	jgs	C	2	Apr 28th, 2005 8:53 AM

Programming Forums > Application Development > C++

two classes, call each others functions - how?!!