Programming Forums > Application Development > C++

PhilBon · Feb 9th, 2008, 1:32 PM

What are the problems?

Brent · Feb 9th, 2008, 1:35 PM

The playback is extremely choppy, it is as if each chunk is playing several times before moving on to the next chunk in the list.

PhilBon · Feb 9th, 2008, 2:35 PM

Have you thought about making it so it has to have 5 items in the list before it's able to play? or something of that sort and when it plays an item it removes it, once the list is empty it puts it on hold.

The Dark · Feb 9th, 2008, 5:38 PM

You need to change your queueing code a bit. consider this code:

(Toggle Plain Text)

DWORD WINAPI FillOutput(LPVOID lpParameter)
{
	char data[1024];
	int addrlen=sizeof(sin);
	
	while(true)
	{
		if(Out < MAX_BUFFERS)
		{
			for(b=0; b<=(MAX_BUFFERS-Out); b++)
			{
				recvfrom(client,data,sizeof(data),0,(struct sockaddr*)&sin,&addrlen);
				strcpy(OutQueue[b].data,data);
				Out++;
			}
		}
	}

	return 0;
}

This will copy the received data to the start of the OutQueue each time round the while loop, even if that data hasn't been played yet. This is probably what is causing some of the chunks to play several times.

What you can do for a queue in a fixed buffer is to have a start index and an end index - both of these can just keep incrementing until they hit the OutQueue size and wrap back to the 0. You only need to play something if the start and end indexes are at different values.
Write your data to the end index and increment, read your data for playing from the start index and increment. You will still need to handle the case when you have too much data (e.g. the end index catches up with the start).
I hope that makes sense - I too afraid to re-read it

Brent · Feb 9th, 2008, 8:13 PM

Thanks for the solution Dark, im looking into it now.

Brent · Feb 9th, 2008, 8:26 PM

Ok so this is what your saying Dark:

I create two variables, lets say StartIndex and EndIndex, and every time I add a buffer to the queue I increment these values. So it might look something like this:

 c++ Syntax (Toggle Plain Text) 
 
int StartIndex, EndIndex;
 
DWORD WINAPI FillOutput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int addrlen=sizeof(sin),a;
 
	while(threadEnd == false)
	{
		if(StartIndex <= MAX_BUFFERS && EndIndex <= MAX_BUFFERS)
		{
			for(a=0; a<=(MAX_BUFFERS-Out); a++)
			{
				recvfrom(client,data,sizeof(data),0,(struct sockaddr*)&sin,&addrlen);
				strcpy(OutQueue[a].data,data);
				Out++;
			}
			StartIndex++;
			EndIndex++;
		}
	}
 
	return 0;
}
int StartIndex, EndIndex;

DWORD WINAPI FillOutput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int addrlen=sizeof(sin),a;
	
	while(threadEnd == false)
	{
		if(StartIndex <= MAX_BUFFERS && EndIndex <= MAX_BUFFERS)
		{
			for(a=0; a<=(MAX_BUFFERS-Out); a++)
			{
				recvfrom(client,data,sizeof(data),0,(struct sockaddr*)&sin,&addrlen);
				strcpy(OutQueue[a].data,data);
				Out++;
			}
			StartIndex++;
			EndIndex++;
		}
	}

	return 0;
}

The Dark · Feb 9th, 2008, 8:35 PM

Not quite. It might be better to call the variables WriteIndex and ReadIndex. When you write into the buffer, increment WriteIndex. When you read from the buffer, increment ReadIndex. When ReadIndex and WriteIndex have the same value, there is nothing in the buffer to read.
You don't need the inner for loop as the outer while loop takes care of everything.

Something like (untested):

 c++ Syntax (Toggle Plain Text) 
int WriteIndex = 0;
int ReadIndex = 0;
 
DWORD WINAPI FillOutput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int addrlen=sizeof(sin),a;
 
	while(threadEnd == false)
	{
            if ( (StartIndex + 1) % MAX_BUFFERS != EndIndex)
            {
		recvfrom(client,data,sizeof(data),0,(struct sockaddr*)&sin,&addrlen);
		strcpy(OutQueue[StartIndex].data,data);
		StartIndex = (StartIndex + 1) % MAX_BUFFERS;
	    }
	}
 
	return 0;
}
int WriteIndex = 0;
int ReadIndex = 0;

DWORD WINAPI FillOutput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int addrlen=sizeof(sin),a;
	
	while(threadEnd == false)
	{
            if ( (StartIndex + 1) % MAX_BUFFERS != EndIndex)
            {
		recvfrom(client,data,sizeof(data),0,(struct sockaddr*)&sin,&addrlen);
		strcpy(OutQueue[StartIndex].data,data);
		StartIndex = (StartIndex + 1) % MAX_BUFFERS;
	    }
	}

	return 0;
}

The "% MAX_BUFFERS" is to wrap the index back to zero if it goes past the end of the queue buffer.

Brent · Feb 9th, 2008, 9:23 PM

Ok, thank you for the clarification.

Brent · Feb 9th, 2008, 9:30 PM

I have done some re-coding using the suggestions but am still having problems. When I start the application and press the talk button, the program exits. Here is the code:

 c++ Syntax (Toggle Plain Text) 
 
#include<windows.h>
#include<windowsx.h>
#include<winsock2.h>
#pragma comment(lib,"ws2_32.lib")
#include"resource.h"
#include"audio_class.h"
 
#define BUFFERSIZE 1024
#define MAX_BUFFERS 12
 
#define UPPER_THRESHOLD 6 // Delay threshold
#define LOWER_THRESHOLD 0 // Delay threshold
 
HWND hwnd,Hwnd;
 
char strAddress[15];
bool connected=false,talk=false,threadEnd=false;
int error,client,port,len;
 
Audio sound;
 
const char g_szClassName[] = "myWindowClass";
 
WORD sockversion;
WSADATA wsaData;
 
sockaddr_in sin;
sockaddr_in bindAddr;
 
HMENU hMenu, hSubMenu;
 
BOOL CALLBACK dlgfunc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam);
BOOL CALLBACK conndlg(HWND Hwnd, UINT msg, WPARAM wParam, LPARAM lParam);
 
 
DWORD WINAPI recv_(LPVOID lpParameterm);
DWORD WINAPI send_(LPVOID lpParameter);
 
DWORD FillIn,FillOut,PlayOut,SendIn;
HANDLE Fill_In,Fill_Out,Play_Out,Send_In;
 
struct waveBuffers
{
	char data[BUFFERSIZE];
};
 
waveBuffers InQueue[MAX_BUFFERS];
waveBuffers OutQueue[MAX_BUFFERS];
 
int In,Out;
int WriteIndex = 0;
int ReadIndex = 0;
 
DWORD WINAPI FillInput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int a;
 
	while(threadEnd == false)
	{
		if ( (ReadIndex + 1) % MAX_BUFFERS != WriteIndex)
		{
			sound.GetInput(data);
			strcpy(InQueue[ReadIndex].data,data);
			ReadIndex = (ReadIndex + 1) % MAX_BUFFERS;
	    }
	}
	return 0;
}
 
 
 
 
 
DWORD WINAPI FillOutput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int addrlen=sizeof(sin),a;
 
	while(threadEnd == false)
	{
        if ( (WriteIndex + 1) % MAX_BUFFERS != ReadIndex)
		{
			recvfrom(client,data,sizeof(data),0,(struct sockaddr*)&sin,&addrlen);
			strcpy(OutQueue[WriteIndex].data,data);
			WriteIndex = (WriteIndex + 1) % MAX_BUFFERS;
	    }
	}
 
	return 0;
}
 
DWORD WINAPI PlayOutput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int a;
 
	while(threadEnd == false)
	{
		//if number of output buffers is greater than UPPER_THRESHOLD
		if((WriteIndex + 1) % MAX_BUFFERS != ReadIndex)
		{
			sound.Play(OutQueue[a].data);
			ZeroMemory(OutQueue[a].data, BUFFERSIZE);
			WriteIndex = (WriteIndex - 1);
 
		}
	}
 
	return 0;
}
 
DWORD WINAPI SendInput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int a;
 
	while(threadEnd == false)
	{
		if((ReadIndex + 1) % MAX_BUFFERS != WriteIndex)
		{
			sendto(client,InQueue[a].data,sizeof(InQueue[a].data),0,(struct sockaddr*)&sin,sizeof(sin));
			ZeroMemory(InQueue[a].data, BUFFERSIZE);
			ReadIndex = (ReadIndex - 1);
		}
	}
 
	return 0;
}
 
 
void Message(LPCSTR message)
{
    MessageBox(NULL, message, "Sound Error", MB_OK | MB_ICONSTOP);
}
 
int WINAPI WinMain (HINSTANCE h,HINSTANCE p,LPSTR lpstr,int nShow)
{		
	DialogBox(GetModuleHandle(NULL),MAKEINTRESOURCE(DIALOG2),Hwnd,conndlg);
	if(connected==true)
	{
		DialogBox(GetModuleHandle(NULL),MAKEINTRESOURCE(DIALOG1),hwnd,dlgfunc);
	}
 
	return 0;
}
 
BOOL CALLBACK conndlg(HWND Hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
{
	switch(msg)
	{
		case WM_INITDIALOG:
		{
			sockversion=WSAStartup(0x202,&wsaData);
 
			SetDlgItemText(Hwnd,IDC_IPADDR,"127.0.0.1");
			SetDlgItemText(Hwnd,IDC_PORT,"23097");	
		}	
		break;
		case WM_COMMAND:
		{
			switch(LOWORD(wParam))
	        {
				case IDOK:
				{
					client=socket(PF_INET,SOCK_DGRAM,0);
					if(client==INVALID_SOCKET)
					{	
						MessageBox(Hwnd,"Error creating socket","Error",NULL);
						closesocket(client);
					}	
 
					sin.sin_family=PF_INET;
 
					port = GetDlgItemInt(Hwnd,IDC_PORT,NULL,false);
					sin.sin_port = htons(port);
 
					GetDlgItemText(Hwnd,IDC_IPADDR,strAddress,15);
					sin.sin_addr.s_addr = inet_addr(strAddress);
 
					if((len=GetWindowTextLength(GetDlgItem(Hwnd,IDC_IPADDR))) > 0 &&
						(len=GetWindowTextLength(GetDlgItem(Hwnd,IDC_PORT))) > 0)
					{
						bindAddr.sin_family=PF_INET;
						bindAddr.sin_port=htons(port);
						bindAddr.sin_addr.s_addr=INADDR_ANY;
 
						error=bind(client,(LPSOCKADDR)&bindAddr,sizeof(bindAddr));
						if(error == SOCKET_ERROR)
						{
							MessageBox(Hwnd,"bind() error","Error",NULL);
						}
						else
						{
							connected=true;
							EndDialog(Hwnd,9);
							return TRUE;	
						}	
					}
					else
					{
						MessageBox(Hwnd,"Please enter an IP and port number","Msg",NULL);
					}
				}
				break;
				case IDCANCEL:
				{
					closesocket(client);
					WSACleanup();
					EndDialog(Hwnd,5);
					return NOT;
				}
				break;
				default:
					return FALSE; 
			}
		}
		break;
		case WM_CLOSE:
		{
			closesocket(client);
			WSACleanup();
			EndDialog(Hwnd,0);
		}
		break;
		default: 
			return FALSE;
	}	
	return TRUE;
}
 
BOOL CALLBACK dlgfunc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
{
	switch(msg)
	{
		case WM_INITDIALOG:
		{
			if((error=WSAAsyncSelect(client,hwnd,WM_SOCK,FD_CLOSE))==SOCKET_ERROR) 
			{	
				MessageBox(hwnd,"Select() error","Error",NULL);
				closesocket(client);
				return(false);
			}
		}
		break;
		case WM_CLOSE:
		{	
			talk=false;
			threadEnd=true;
 
 
 
			sound.Stop();
 
			closesocket(client);
			WSACleanup();
			EndDialog(hwnd,0);
		}
		break;
		case WM_COMMAND:
		switch(LOWORD(wParam))
        {
			case ID_FILE_EXIT:
			{
				int exit=MessageBox(hwnd,"Are you sure you want to quit?","Exit",MB_YESNO|MB_ICONQUESTION);
				if(exit==IDYES)
				{
					talk=false;
					threadEnd=true;
 
 
 
					sound.Stop();
					closesocket(client);
					WSACleanup();
					PostMessage(hwnd, WM_CLOSE, 0, 0);
				}
			}
            break;
			case IDOK:
			{	
				if(talk == false)
				{
					//int err = sound.StartAudio(1024,1,8000,8,0);  //begin audio 
					int err = sound.Start();
					if(err == 1)
					{
						MessageBox(hwnd,"Unable to Start Audio","Error",NULL);
						talk = false;
					}
					else
					{
						talk = true;
						threadEnd=false;
						SendDlgItemMessage(hwnd,IDOK,WM_SETTEXT,0,(LPARAM)"Push to stop");	
 
 
						DWORD FillIn,FillOut,PlayOut,SendIn;
						HANDLE Fill_In,Fill_Out,Play_Out,Send_In;
 
						Fill_In = CreateThread(NULL,0,FillInput,0,0,&FillIn);
						Fill_Out = CreateThread(NULL,0,FillOutput,0,0,&FillOut);
						Play_Out = CreateThread(NULL,0,PlayOutput,0,0,&PlayOut);
						Send_In = CreateThread(NULL,0,SendInput,0,0,&SendIn);
					}
				}	
				else
				{
					talk = false;
					threadEnd=true;
 
					CloseHandle(Fill_In);
					CloseHandle(Fill_Out);
					CloseHandle(Play_Out);
					CloseHandle(Send_In);
 
					sound.Stop();
 
					SendDlgItemMessage(hwnd,IDOK,WM_SETTEXT,0,(LPARAM)"Push to talk");	
				}
			}
			break;
		}
		break;
		default:
			return FALSE;
	}	
	return 0;
}
#include<windows.h>
#include<windowsx.h>
#include<winsock2.h>
#pragma comment(lib,"ws2_32.lib")
#include"resource.h"
#include"audio_class.h"

#define BUFFERSIZE 1024
#define MAX_BUFFERS 12

#define UPPER_THRESHOLD 6 // Delay threshold
#define LOWER_THRESHOLD 0 // Delay threshold

HWND hwnd,Hwnd;

char strAddress[15];
bool connected=false,talk=false,threadEnd=false;
int error,client,port,len;

Audio sound;

const char g_szClassName[] = "myWindowClass";

WORD sockversion;
WSADATA wsaData;

sockaddr_in sin;
sockaddr_in bindAddr;

HMENU hMenu, hSubMenu;

BOOL CALLBACK dlgfunc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam);
BOOL CALLBACK conndlg(HWND Hwnd, UINT msg, WPARAM wParam, LPARAM lParam);


DWORD WINAPI recv_(LPVOID lpParameterm);
DWORD WINAPI send_(LPVOID lpParameter);

DWORD FillIn,FillOut,PlayOut,SendIn;
HANDLE Fill_In,Fill_Out,Play_Out,Send_In;

struct waveBuffers
{
	char data[BUFFERSIZE];
};

waveBuffers InQueue[MAX_BUFFERS];
waveBuffers OutQueue[MAX_BUFFERS];

int In,Out;
int WriteIndex = 0;
int ReadIndex = 0;

DWORD WINAPI FillInput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int a;
	
	while(threadEnd == false)
	{
		if ( (ReadIndex + 1) % MAX_BUFFERS != WriteIndex)
		{
			sound.GetInput(data);
			strcpy(InQueue[ReadIndex].data,data);
			ReadIndex = (ReadIndex + 1) % MAX_BUFFERS;
	    }
	}
	return 0;
}





DWORD WINAPI FillOutput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int addrlen=sizeof(sin),a;
	
	while(threadEnd == false)
	{
        if ( (WriteIndex + 1) % MAX_BUFFERS != ReadIndex)
		{
			recvfrom(client,data,sizeof(data),0,(struct sockaddr*)&sin,&addrlen);
			strcpy(OutQueue[WriteIndex].data,data);
			WriteIndex = (WriteIndex + 1) % MAX_BUFFERS;
	    }
	}

	return 0;
}

DWORD WINAPI PlayOutput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int a;
	
	while(threadEnd == false)
	{
		//if number of output buffers is greater than UPPER_THRESHOLD
		if((WriteIndex + 1) % MAX_BUFFERS != ReadIndex)
		{
			sound.Play(OutQueue[a].data);
			ZeroMemory(OutQueue[a].data, BUFFERSIZE);
			WriteIndex = (WriteIndex - 1);
			
		}
	}
	
	return 0;
}

DWORD WINAPI SendInput(LPVOID lpParameter)
{
	char data[BUFFERSIZE];
	int a;
	
	while(threadEnd == false)
	{
		if((ReadIndex + 1) % MAX_BUFFERS != WriteIndex)
		{
			sendto(client,InQueue[a].data,sizeof(InQueue[a].data),0,(struct sockaddr*)&sin,sizeof(sin));
			ZeroMemory(InQueue[a].data, BUFFERSIZE);
			ReadIndex = (ReadIndex - 1);
		}
	}

	return 0;
}


void Message(LPCSTR message)
{
    MessageBox(NULL, message, "Sound Error", MB_OK | MB_ICONSTOP);
}
	
int WINAPI WinMain (HINSTANCE h,HINSTANCE p,LPSTR lpstr,int nShow)
{		
	DialogBox(GetModuleHandle(NULL),MAKEINTRESOURCE(DIALOG2),Hwnd,conndlg);
	if(connected==true)
	{
		DialogBox(GetModuleHandle(NULL),MAKEINTRESOURCE(DIALOG1),hwnd,dlgfunc);
	}
	
	return 0;
}

BOOL CALLBACK conndlg(HWND Hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
{
	switch(msg)
	{
		case WM_INITDIALOG:
		{
			sockversion=WSAStartup(0x202,&wsaData);
			
			SetDlgItemText(Hwnd,IDC_IPADDR,"127.0.0.1");
			SetDlgItemText(Hwnd,IDC_PORT,"23097");	
		}	
		break;
		case WM_COMMAND:
		{
			switch(LOWORD(wParam))
	        {
				case IDOK:
				{
					client=socket(PF_INET,SOCK_DGRAM,0);
					if(client==INVALID_SOCKET)
					{	
						MessageBox(Hwnd,"Error creating socket","Error",NULL);
						closesocket(client);
					}	
					
					sin.sin_family=PF_INET;
					
					port = GetDlgItemInt(Hwnd,IDC_PORT,NULL,false);
					sin.sin_port = htons(port);
					
					GetDlgItemText(Hwnd,IDC_IPADDR,strAddress,15);
					sin.sin_addr.s_addr = inet_addr(strAddress);
					
					if((len=GetWindowTextLength(GetDlgItem(Hwnd,IDC_IPADDR))) > 0 &&
						(len=GetWindowTextLength(GetDlgItem(Hwnd,IDC_PORT))) > 0)
					{
						bindAddr.sin_family=PF_INET;
						bindAddr.sin_port=htons(port);
						bindAddr.sin_addr.s_addr=INADDR_ANY;
							
						error=bind(client,(LPSOCKADDR)&bindAddr,sizeof(bindAddr));
						if(error == SOCKET_ERROR)
						{
							MessageBox(Hwnd,"bind() error","Error",NULL);
						}
						else
						{
							connected=true;
							EndDialog(Hwnd,9);
							return TRUE;	
						}	
					}
					else
					{
						MessageBox(Hwnd,"Please enter an IP and port number","Msg",NULL);
					}
				}
				break;
				case IDCANCEL:
				{
					closesocket(client);
					WSACleanup();
					EndDialog(Hwnd,5);
					return NOT;
				}
				break;
				default:
					return FALSE; 
			}
		}
		break;
		case WM_CLOSE:
		{
			closesocket(client);
			WSACleanup();
			EndDialog(Hwnd,0);
		}
		break;
		default: 
			return FALSE;
	}	
	return TRUE;
}

BOOL CALLBACK dlgfunc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
{
	switch(msg)
	{
		case WM_INITDIALOG:
		{
			if((error=WSAAsyncSelect(client,hwnd,WM_SOCK,FD_CLOSE))==SOCKET_ERROR) 
			{	
				MessageBox(hwnd,"Select() error","Error",NULL);
				closesocket(client);
				return(false);
			}
		}
		break;
		case WM_CLOSE:
		{	
			talk=false;
			threadEnd=true;
				

				
			sound.Stop();
				
			closesocket(client);
			WSACleanup();
			EndDialog(hwnd,0);
		}
		break;
		case WM_COMMAND:
		switch(LOWORD(wParam))
        {
			case ID_FILE_EXIT:
			{
				int exit=MessageBox(hwnd,"Are you sure you want to quit?","Exit",MB_YESNO|MB_ICONQUESTION);
				if(exit==IDYES)
				{
					talk=false;
					threadEnd=true;
			

				
					sound.Stop();
					closesocket(client);
					WSACleanup();
					PostMessage(hwnd, WM_CLOSE, 0, 0);
				}
			}
            break;
			case IDOK:
			{	
				if(talk == false)
				{
					//int err = sound.StartAudio(1024,1,8000,8,0);  //begin audio 
					int err = sound.Start();
					if(err == 1)
					{
						MessageBox(hwnd,"Unable to Start Audio","Error",NULL);
						talk = false;
					}
					else
					{
						talk = true;
						threadEnd=false;
						SendDlgItemMessage(hwnd,IDOK,WM_SETTEXT,0,(LPARAM)"Push to stop");	
						

						DWORD FillIn,FillOut,PlayOut,SendIn;
						HANDLE Fill_In,Fill_Out,Play_Out,Send_In;

						Fill_In = CreateThread(NULL,0,FillInput,0,0,&FillIn);
						Fill_Out = CreateThread(NULL,0,FillOutput,0,0,&FillOut);
						Play_Out = CreateThread(NULL,0,PlayOutput,0,0,&PlayOut);
						Send_In = CreateThread(NULL,0,SendInput,0,0,&SendIn);
					}
				}	
				else
				{
					talk = false;
					threadEnd=true;
					
					CloseHandle(Fill_In);
					CloseHandle(Fill_Out);
					CloseHandle(Play_Out);
					CloseHandle(Send_In);
					
					sound.Stop();
					
					SendDlgItemMessage(hwnd,IDOK,WM_SETTEXT,0,(LPARAM)"Push to talk");	
				}
			}
			break;
		}
		break;
		default:
			return FALSE;
	}	
	return 0;
}

The Dark · Feb 9th, 2008, 10:37 PM

You have two separate queues, input and output, so you will need two separate sets of ReadIndex and WriteIndex. It may even be worth making a queue class so you don't have to have the same code twice.

Also your PLayOutput and SendInput functions both use the variable a without setting a value into it.

Feb 9th, 2008, 1:32 PM	#11
PhilBon Hobbyist Programmer Join Date: Nov 2005 Posts: 171 Rep Power: 3	Re: Streaming Audio over network What are the problems?

Feb 9th, 2008, 1:35 PM	#12
Brent Highly Adaptive Penguin Join Date: May 2005 Location: United States Posts: 249 Rep Power: 4	Re: Streaming Audio over network The playback is extremely choppy, it is as if each chunk is playing several times before moving on to the next chunk in the list.

Feb 9th, 2008, 2:35 PM	#13
PhilBon Hobbyist Programmer Join Date: Nov 2005 Posts: 171 Rep Power: 3	Re: Streaming Audio over network Have you thought about making it so it has to have 5 items in the list before it's able to play? or something of that sort and when it plays an item it removes it, once the list is empty it puts it on hold.

Feb 9th, 2008, 5:38 PM	#14
The Dark Expert Programmer Join Date: Jun 2005 Posts: 816 Rep Power: 4	Re: Streaming Audio over network You need to change your queueing code a bit. consider this code: (Toggle Plain Text) DWORD WINAPI FillOutput(LPVOID lpParameter) { char data[1024]; int addrlen=sizeof(sin); while(true) { if(Out < MAX_BUFFERS) { for(b=0; b<=(MAX_BUFFERS-Out); b++) { recvfrom(client,data,sizeof(data),0,(struct sockaddr)&sin,&addrlen); strcpy(OutQueue[b].data,data); Out++; } } } return 0; } DWORD WINAPI FillOutput(LPVOID lpParameter) { char data[1024]; int addrlen=sizeof(sin); while(true) { if(Out < MAX_BUFFERS) { for(b=0; b<=(MAX_BUFFERS-Out); b++) { recvfrom(client,data,sizeof(data),0,(struct sockaddr)&sin,&addrlen); strcpy(OutQueue[b].data,data); Out++; } } } return 0; } This will copy the received data to the start of the OutQueue each time round the while loop, even if that data hasn't been played yet. This is probably what is causing some of the chunks to play several times. What you can do for a queue in a fixed buffer is to have a start index and an end index - both of these can just keep incrementing until they hit the OutQueue size and wrap back to the 0. You only need to play something if the start and end indexes are at different values. Write your data to the end index and increment, read your data for playing from the start index and increment. You will still need to handle the case when you have too much data (e.g. the end index catches up with the start). I hope that makes sense - I too afraid to re-read it

Feb 9th, 2008, 8:13 PM	#15
Brent Highly Adaptive Penguin Join Date: May 2005 Location: United States Posts: 249 Rep Power: 4	Re: Streaming Audio over network Thanks for the solution Dark, im looking into it now.

Feb 9th, 2008, 8:26 PM	#16
Brent Highly Adaptive Penguin Join Date: May 2005 Location: United States Posts: 249 Rep Power: 4	Re: Streaming Audio over network Ok so this is what your saying Dark: I create two variables, lets say StartIndex and EndIndex, and every time I add a buffer to the queue I increment these values. So it might look something like this: c++ Syntax (Toggle Plain Text) int StartIndex, EndIndex; DWORD WINAPI FillOutput(LPVOID lpParameter) { char data[BUFFERSIZE]; int addrlen=sizeof(sin),a; while(threadEnd == false) { if(StartIndex <= MAX_BUFFERS && EndIndex <= MAX_BUFFERS) { for(a=0; a<=(MAX_BUFFERS-Out); a++) { recvfrom(client,data,sizeof(data),0,(struct sockaddr)&sin,&addrlen); strcpy(OutQueue[a].data,data); Out++; } StartIndex++; EndIndex++; } } return 0; } int StartIndex, EndIndex; DWORD WINAPI FillOutput(LPVOID lpParameter) { char data[BUFFERSIZE]; int addrlen=sizeof(sin),a; while(threadEnd == false) { if(StartIndex <= MAX_BUFFERS && EndIndex <= MAX_BUFFERS) { for(a=0; a<=(MAX_BUFFERS-Out); a++) { recvfrom(client,data,sizeof(data),0,(struct sockaddr)&sin,&addrlen); strcpy(OutQueue[a].data,data); Out++; } StartIndex++; EndIndex++; } } return 0; }

Feb 9th, 2008, 8:35 PM	#17
The Dark Expert Programmer Join Date: Jun 2005 Posts: 816 Rep Power: 4	Re: Streaming Audio over network Not quite. It might be better to call the variables WriteIndex and ReadIndex. When you write into the buffer, increment WriteIndex. When you read from the buffer, increment ReadIndex. When ReadIndex and WriteIndex have the same value, there is nothing in the buffer to read. You don't need the inner for loop as the outer while loop takes care of everything. Something like (untested): c++ Syntax (Toggle Plain Text) int WriteIndex = 0; int ReadIndex = 0; DWORD WINAPI FillOutput(LPVOID lpParameter) { char data[BUFFERSIZE]; int addrlen=sizeof(sin),a; while(threadEnd == false) { if ( (StartIndex + 1) % MAX_BUFFERS != EndIndex) { recvfrom(client,data,sizeof(data),0,(struct sockaddr)&sin,&addrlen); strcpy(OutQueue[StartIndex].data,data); StartIndex = (StartIndex + 1) % MAX_BUFFERS; } } return 0; } int WriteIndex = 0; int ReadIndex = 0; DWORD WINAPI FillOutput(LPVOID lpParameter) { char data[BUFFERSIZE]; int addrlen=sizeof(sin),a; while(threadEnd == false) { if ( (StartIndex + 1) % MAX_BUFFERS != EndIndex) { recvfrom(client,data,sizeof(data),0,(struct sockaddr)&sin,&addrlen); strcpy(OutQueue[StartIndex].data,data); StartIndex = (StartIndex + 1) % MAX_BUFFERS; } } return 0; } The "% MAX_BUFFERS" is to wrap the index back to zero if it goes past the end of the queue buffer.

Feb 9th, 2008, 9:23 PM	#18
Brent Highly Adaptive Penguin Join Date: May 2005 Location: United States Posts: 249 Rep Power: 4	Re: Streaming Audio over network Ok, thank you for the clarification.

Feb 9th, 2008, 9:30 PM	#19
Brent Highly Adaptive Penguin Join Date: May 2005 Location: United States Posts: 249 Rep Power: 4	Re: Streaming Audio over network I have done some re-coding using the suggestions but am still having problems. When I start the application and press the talk button, the program exits. Here is the code: c++ Syntax (Toggle Plain Text) #include<windows.h> #include<windowsx.h> #include<winsock2.h> #pragma comment(lib,"ws2_32.lib") #include"resource.h" #include"audio_class.h" #define BUFFERSIZE 1024 #define MAX_BUFFERS 12 #define UPPER_THRESHOLD 6 // Delay threshold #define LOWER_THRESHOLD 0 // Delay threshold HWND hwnd,Hwnd; char strAddress[15]; bool connected=false,talk=false,threadEnd=false; int error,client,port,len; Audio sound; const char g_szClassName[] = "myWindowClass"; WORD sockversion; WSADATA wsaData; sockaddr_in sin; sockaddr_in bindAddr; HMENU hMenu, hSubMenu; BOOL CALLBACK dlgfunc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam); BOOL CALLBACK conndlg(HWND Hwnd, UINT msg, WPARAM wParam, LPARAM lParam); DWORD WINAPI recv_(LPVOID lpParameterm); DWORD WINAPI send_(LPVOID lpParameter); DWORD FillIn,FillOut,PlayOut,SendIn; HANDLE Fill_In,Fill_Out,Play_Out,Send_In; struct waveBuffers { char data[BUFFERSIZE]; }; waveBuffers InQueue[MAX_BUFFERS]; waveBuffers OutQueue[MAX_BUFFERS]; int In,Out; int WriteIndex = 0; int ReadIndex = 0; DWORD WINAPI FillInput(LPVOID lpParameter) { char data[BUFFERSIZE]; int a; while(threadEnd == false) { if ( (ReadIndex + 1) % MAX_BUFFERS != WriteIndex) { sound.GetInput(data); strcpy(InQueue[ReadIndex].data,data); ReadIndex = (ReadIndex + 1) % MAX_BUFFERS; } } return 0; } DWORD WINAPI FillOutput(LPVOID lpParameter) { char data[BUFFERSIZE]; int addrlen=sizeof(sin),a; while(threadEnd == false) { if ( (WriteIndex + 1) % MAX_BUFFERS != ReadIndex) { recvfrom(client,data,sizeof(data),0,(struct sockaddr)&sin,&addrlen); strcpy(OutQueue[WriteIndex].data,data); WriteIndex = (WriteIndex + 1) % MAX_BUFFERS; } } return 0; } DWORD WINAPI PlayOutput(LPVOID lpParameter) { char data[BUFFERSIZE]; int a; while(threadEnd == false) { //if number of output buffers is greater than UPPER_THRESHOLD if((WriteIndex + 1) % MAX_BUFFERS != ReadIndex) { sound.Play(OutQueue[a].data); ZeroMemory(OutQueue[a].data, BUFFERSIZE); WriteIndex = (WriteIndex - 1); } } return 0; } DWORD WINAPI SendInput(LPVOID lpParameter) { char data[BUFFERSIZE]; int a; while(threadEnd == false) { if((ReadIndex + 1) % MAX_BUFFERS != WriteIndex) { sendto(client,InQueue[a].data,sizeof(InQueue[a].data),0,(struct sockaddr)&sin,sizeof(sin)); ZeroMemory(InQueue[a].data, BUFFERSIZE); ReadIndex = (ReadIndex - 1); } } return 0; } void Message(LPCSTR message) { MessageBox(NULL, message, "Sound Error", MB_OK \| MB_ICONSTOP); } int WINAPI WinMain (HINSTANCE h,HINSTANCE p,LPSTR lpstr,int nShow) { DialogBox(GetModuleHandle(NULL),MAKEINTRESOURCE(DIALOG2),Hwnd,conndlg); if(connected==true) { DialogBox(GetModuleHandle(NULL),MAKEINTRESOURCE(DIALOG1),hwnd,dlgfunc); } return 0; } BOOL CALLBACK conndlg(HWND Hwnd, UINT msg, WPARAM wParam, LPARAM lParam) { switch(msg) { case WM_INITDIALOG: { sockversion=WSAStartup(0x202,&wsaData); SetDlgItemText(Hwnd,IDC_IPADDR,"127.0.0.1"); SetDlgItemText(Hwnd,IDC_PORT,"23097"); } break; case WM_COMMAND: { switch(LOWORD(wParam)) { case IDOK: { client=socket(PF_INET,SOCK_DGRAM,0); if(client==INVALID_SOCKET) { MessageBox(Hwnd,"Error creating socket","Error",NULL); closesocket(client); } sin.sin_family=PF_INET; port = GetDlgItemInt(Hwnd,IDC_PORT,NULL,false); sin.sin_port = htons(port); GetDlgItemText(Hwnd,IDC_IPADDR,strAddress,15); sin.sin_addr.s_addr = inet_addr(strAddress); if((len=GetWindowTextLength(GetDlgItem(Hwnd,IDC_IPADDR))) > 0 && (len=GetWindowTextLength(GetDlgItem(Hwnd,IDC_PORT))) > 0) { bindAddr.sin_family=PF_INET; bindAddr.sin_port=htons(port); bindAddr.sin_addr.s_addr=INADDR_ANY; error=bind(client,(LPSOCKADDR)&bindAddr,sizeof(bindAddr)); if(error == SOCKET_ERROR) { MessageBox(Hwnd,"bind() error","Error",NULL); } else { connected=true; EndDialog(Hwnd,9); return TRUE; } } else { MessageBox(Hwnd,"Please enter an IP and port number","Msg",NULL); } } break; case IDCANCEL: { closesocket(client); WSACleanup(); EndDialog(Hwnd,5); return NOT; } break; default: return FALSE; } } break; case WM_CLOSE: { closesocket(client); WSACleanup(); EndDialog(Hwnd,0); } break; default: return FALSE; } return TRUE; } BOOL CALLBACK dlgfunc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) { switch(msg) { case WM_INITDIALOG: { if((error=WSAAsyncSelect(client,hwnd,WM_SOCK,FD_CLOSE))==SOCKET_ERROR) { MessageBox(hwnd,"Select() error","Error",NULL); closesocket(client); return(false); } } break; case WM_CLOSE: { talk=false; threadEnd=true; sound.Stop(); closesocket(client); WSACleanup(); EndDialog(hwnd,0); } break; case WM_COMMAND: switch(LOWORD(wParam)) { case ID_FILE_EXIT: { int exit=MessageBox(hwnd,"Are you sure you want to quit?","Exit",MB_YESNO\|MB_ICONQUESTION); if(exit==IDYES) { talk=false; threadEnd=true; sound.Stop(); closesocket(client); WSACleanup(); PostMessage(hwnd, WM_CLOSE, 0, 0); } } break; case IDOK: { if(talk == false) { //int err = sound.StartAudio(1024,1,8000,8,0); //begin audio int err = sound.Start(); if(err == 1) { MessageBox(hwnd,"Unable to Start Audio","Error",NULL); talk = false; } else { talk = true; threadEnd=false; SendDlgItemMessage(hwnd,IDOK,WM_SETTEXT,0,(LPARAM)"Push to stop"); DWORD FillIn,FillOut,PlayOut,SendIn; HANDLE Fill_In,Fill_Out,Play_Out,Send_In; Fill_In = CreateThread(NULL,0,FillInput,0,0,&FillIn); Fill_Out = CreateThread(NULL,0,FillOutput,0,0,&FillOut); Play_Out = CreateThread(NULL,0,PlayOutput,0,0,&PlayOut); Send_In = CreateThread(NULL,0,SendInput,0,0,&SendIn); } } else { talk = false; threadEnd=true; CloseHandle(Fill_In); CloseHandle(Fill_Out); CloseHandle(Play_Out); CloseHandle(Send_In); sound.Stop(); SendDlgItemMessage(hwnd,IDOK,WM_SETTEXT,0,(LPARAM)"Push to talk"); } } break; } break; default: return FALSE; } return 0; } #include<windows.h> #include<windowsx.h> #include<winsock2.h> #pragma comment(lib,"ws2_32.lib") #include"resource.h" #include"audio_class.h" #define BUFFERSIZE 1024 #define MAX_BUFFERS 12 #define UPPER_THRESHOLD 6 // Delay threshold #define LOWER_THRESHOLD 0 // Delay threshold HWND hwnd,Hwnd; char strAddress[15]; bool connected=false,talk=false,threadEnd=false; int error,client,port,len; Audio sound; const char g_szClassName[] = "myWindowClass"; WORD sockversion; WSADATA wsaData; sockaddr_in sin; sockaddr_in bindAddr; HMENU hMenu, hSubMenu; BOOL CALLBACK dlgfunc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam); BOOL CALLBACK conndlg(HWND Hwnd, UINT msg, WPARAM wParam, LPARAM lParam); DWORD WINAPI recv_(LPVOID lpParameterm); DWORD WINAPI send_(LPVOID lpParameter); DWORD FillIn,FillOut,PlayOut,SendIn; HANDLE Fill_In,Fill_Out,Play_Out,Send_In; struct waveBuffers { char data[BUFFERSIZE]; }; waveBuffers InQueue[MAX_BUFFERS]; waveBuffers OutQueue[MAX_BUFFERS]; int In,Out; int WriteIndex = 0; int ReadIndex = 0; DWORD WINAPI FillInput(LPVOID lpParameter) { char data[BUFFERSIZE]; int a; while(threadEnd == false) { if ( (ReadIndex + 1) % MAX_BUFFERS != WriteIndex) { sound.GetInput(data); strcpy(InQueue[ReadIndex].data,data); ReadIndex = (ReadIndex + 1) % MAX_BUFFERS; } } return 0; } DWORD WINAPI FillOutput(LPVOID lpParameter) { char data[BUFFERSIZE]; int addrlen=sizeof(sin),a; while(threadEnd == false) { if ( (WriteIndex + 1) % MAX_BUFFERS != ReadIndex) { recvfrom(client,data,sizeof(data),0,(struct sockaddr)&sin,&addrlen); strcpy(OutQueue[WriteIndex].data,data); WriteIndex = (WriteIndex + 1) % MAX_BUFFERS; } } return 0; } DWORD WINAPI PlayOutput(LPVOID lpParameter) { char data[BUFFERSIZE]; int a; while(threadEnd == false) { //if number of output buffers is greater than UPPER_THRESHOLD if((WriteIndex + 1) % MAX_BUFFERS != ReadIndex) { sound.Play(OutQueue[a].data); ZeroMemory(OutQueue[a].data, BUFFERSIZE); WriteIndex = (WriteIndex - 1); } } return 0; } DWORD WINAPI SendInput(LPVOID lpParameter) { char data[BUFFERSIZE]; int a; while(threadEnd == false) { if((ReadIndex + 1) % MAX_BUFFERS != WriteIndex) { sendto(client,InQueue[a].data,sizeof(InQueue[a].data),0,(struct sockaddr)&sin,sizeof(sin)); ZeroMemory(InQueue[a].data, BUFFERSIZE); ReadIndex = (ReadIndex - 1); } } return 0; } void Message(LPCSTR message) { MessageBox(NULL, message, "Sound Error", MB_OK \| MB_ICONSTOP); } int WINAPI WinMain (HINSTANCE h,HINSTANCE p,LPSTR lpstr,int nShow) { DialogBox(GetModuleHandle(NULL),MAKEINTRESOURCE(DIALOG2),Hwnd,conndlg); if(connected==true) { DialogBox(GetModuleHandle(NULL),MAKEINTRESOURCE(DIALOG1),hwnd,dlgfunc); } return 0; } BOOL CALLBACK conndlg(HWND Hwnd, UINT msg, WPARAM wParam, LPARAM lParam) { switch(msg) { case WM_INITDIALOG: { sockversion=WSAStartup(0x202,&wsaData); SetDlgItemText(Hwnd,IDC_IPADDR,"127.0.0.1"); SetDlgItemText(Hwnd,IDC_PORT,"23097"); } break; case WM_COMMAND: { switch(LOWORD(wParam)) { case IDOK: { client=socket(PF_INET,SOCK_DGRAM,0); if(client==INVALID_SOCKET) { MessageBox(Hwnd,"Error creating socket","Error",NULL); closesocket(client); } sin.sin_family=PF_INET; port = GetDlgItemInt(Hwnd,IDC_PORT,NULL,false); sin.sin_port = htons(port); GetDlgItemText(Hwnd,IDC_IPADDR,strAddress,15); sin.sin_addr.s_addr = inet_addr(strAddress); if((len=GetWindowTextLength(GetDlgItem(Hwnd,IDC_IPADDR))) > 0 && (len=GetWindowTextLength(GetDlgItem(Hwnd,IDC_PORT))) > 0) { bindAddr.sin_family=PF_INET; bindAddr.sin_port=htons(port); bindAddr.sin_addr.s_addr=INADDR_ANY; error=bind(client,(LPSOCKADDR)&bindAddr,sizeof(bindAddr)); if(error == SOCKET_ERROR) { MessageBox(Hwnd,"bind() error","Error",NULL); } else { connected=true; EndDialog(Hwnd,9); return TRUE; } } else { MessageBox(Hwnd,"Please enter an IP and port number","Msg",NULL); } } break; case IDCANCEL: { closesocket(client); WSACleanup(); EndDialog(Hwnd,5); return NOT; } break; default: return FALSE; } } break; case WM_CLOSE: { closesocket(client); WSACleanup(); EndDialog(Hwnd,0); } break; default: return FALSE; } return TRUE; } BOOL CALLBACK dlgfunc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) { switch(msg) { case WM_INITDIALOG: { if((error=WSAAsyncSelect(client,hwnd,WM_SOCK,FD_CLOSE))==SOCKET_ERROR) { MessageBox(hwnd,"Select() error","Error",NULL); closesocket(client); return(false); } } break; case WM_CLOSE: { talk=false; threadEnd=true; sound.Stop(); closesocket(client); WSACleanup(); EndDialog(hwnd,0); } break; case WM_COMMAND: switch(LOWORD(wParam)) { case ID_FILE_EXIT: { int exit=MessageBox(hwnd,"Are you sure you want to quit?","Exit",MB_YESNO\|MB_ICONQUESTION); if(exit==IDYES) { talk=false; threadEnd=true; sound.Stop(); closesocket(client); WSACleanup(); PostMessage(hwnd, WM_CLOSE, 0, 0); } } break; case IDOK: { if(talk == false) { //int err = sound.StartAudio(1024,1,8000,8,0); //begin audio int err = sound.Start(); if(err == 1) { MessageBox(hwnd,"Unable to Start Audio","Error",NULL); talk = false; } else { talk = true; threadEnd=false; SendDlgItemMessage(hwnd,IDOK,WM_SETTEXT,0,(LPARAM)"Push to stop"); DWORD FillIn,FillOut,PlayOut,SendIn; HANDLE Fill_In,Fill_Out,Play_Out,Send_In; Fill_In = CreateThread(NULL,0,FillInput,0,0,&FillIn); Fill_Out = CreateThread(NULL,0,FillOutput,0,0,&FillOut); Play_Out = CreateThread(NULL,0,PlayOutput,0,0,&PlayOut); Send_In = CreateThread(NULL,0,SendInput,0,0,&SendIn); } } else { talk = false; threadEnd=true; CloseHandle(Fill_In); CloseHandle(Fill_Out); CloseHandle(Play_Out); CloseHandle(Send_In); sound.Stop(); SendDlgItemMessage(hwnd,IDOK,WM_SETTEXT,0,(LPARAM)"Push to talk"); } } break; } break; default: return FALSE; } return 0; }

Feb 9th, 2008, 10:37 PM	#20
The Dark Expert Programmer Join Date: Jun 2005 Posts: 816 Rep Power: 4	Re: Streaming Audio over network You have two separate queues, input and output, so you will need two separate sets of ReadIndex and WriteIndex. It may even be worth making a queue class so you don't have to have the same code twice. Also your PLayOutput and SendInput functions both use the variable a without setting a value into it.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Network Simulator design	renato	Software Design and Algorithms	2	Dec 11th, 2007 10:54 PM
An Audio and Video class for ruby	Master	Ruby	3	Mar 24th, 2006 5:49 AM
Streaming audio songs?	java_roshan	Coder's Corner Lounge	1	Oct 27th, 2005 1:35 PM
Code Request - Onboard Audio	Meecher	Other Programming Languages	7	Sep 20th, 2005 1:53 AM
Checking source codes of image, audio and video files	on_auc	C++	3	Feb 21st, 2005 8:36 PM

Programming Forums > Application Development > C++

Streaming Audio over network