Programming Forums > Application Development > C++

peaceofpi · Nov 24th, 2007, 1:05 PM

I'm recreating whatever things from algebra/trigonometry that I can think of as a learning exercise. I wanted to post the whole thing for feedback but I don't know how that'd go in this board (it is for support after all).

This function turns a degree measure into degrees, minutes, and seconds. It works fine but I want to know if there's a better way to put the results in one place rather than three stringstreams and three strings. I want the function to return a string because there are three numbers as an answer.

 c++ Syntax (Toggle Plain Text) 
string deg2dms(double deg)
{
	double n = deg;
	int degrees = (int)n;
	n -= degrees;
	n *= 60.0;
	int minutes = (int)n;
	n -= minutes;
	n *= 60.0;
	int seconds = (int)n;
	if ( (n - seconds) >= 0.5 )
		seconds += 1;
 
	stringstream degss;
	stringstream minss;
	stringstream secss;
	string degstr;
	string minstr;
	string secstr;
	degss << degrees;
	minss << minutes;
	secss << seconds;
	degss >> degstr;
	minss >> minstr;
	secss >> secstr;
	return degstr + " " + minstr + " " + secstr;
}
string deg2dms(double deg)
{
	double n = deg;
	int degrees = (int)n;
	n -= degrees;
	n *= 60.0;
	int minutes = (int)n;
	n -= minutes;
	n *= 60.0;
	int seconds = (int)n;
	if ( (n - seconds) >= 0.5 )
		seconds += 1;
	
	stringstream degss;
	stringstream minss;
	stringstream secss;
	string degstr;
	string minstr;
	string secstr;
	degss << degrees;
	minss << minutes;
	secss << seconds;
	degss >> degstr;
	minss >> minstr;
	secss >> secstr;
	return degstr + " " + minstr + " " + secstr;
}

DaWei · Nov 24th, 2007, 2:18 PM

The use of stringstreams, in this instance, amounts to a presentation issue. You have to deal with that, make the conversions, fiddlefart around, and convert back to presentation.

Your code doesn't look half bad, but you're expecting all your operations to work properly and magically. Get a life. Things don't always work out. Test for success and take appropriate actions if something fails.

Anything less is the action of an unemployable newbie or a schlock. Choose your category. Your potential employer is entitled to disagree.

Arla · Nov 24th, 2007, 2:22 PM

Personally I'd probably create a structure to house the three separate values and return that from the function. Stringing them together to return just means you end up with an amalgamated text string that you would then probably need to deconstruct to use elsewhere.

Jessehk · Nov 24th, 2007, 3:26 PM

Some people might think this is overcomplicated, but if you have Boost I like the Tuple library. It's specifically designed to make returning multple values from a function easier.

 c++ Syntax (Toggle Plain Text) 
#include <iostream>
 
#include <boost/tuple/tuple.hpp>
 
typedef boost::tuple<int, int, int> ResultType;
 
ResultType deg2dms( double deg ) {
    double n = deg;
 
    int degrees = static_cast<int>( n );
    n -= degrees;
    n *= 60.0;
 
    int minutes = static_cast<int>( n );
    n -= minutes;
    n *= 60.0;
 
    int seconds = static_cast<int>( n );
    if ( (n - seconds) >= 0.5 )
        seconds += 1;
 
    return ResultType( degrees, minutes, seconds );
}
 
int main() {
    ResultType result = deg2dms( 34.5 );
 
    //Access each element
    //In this case, we're accessing the degrees
    std::cout << result.get<0>() << std::endl;
 
    // Or, Something like this
    #define DEGREES 0
    #define MINUTES 1
    #define SECONDS 2
    std::cout << result.get<MINUTES>() << std::endl;
}
#include <iostream>

#include <boost/tuple/tuple.hpp>

typedef boost::tuple<int, int, int> ResultType;

ResultType deg2dms( double deg ) {
    double n = deg;

    int degrees = static_cast<int>( n );
    n -= degrees;
    n *= 60.0;

    int minutes = static_cast<int>( n );
    n -= minutes;
    n *= 60.0;

    int seconds = static_cast<int>( n );
    if ( (n - seconds) >= 0.5 )
        seconds += 1;
    
    return ResultType( degrees, minutes, seconds );
}

int main() {
    ResultType result = deg2dms( 34.5 );

    //Access each element
    //In this case, we're accessing the degrees
    std::cout << result.get<0>() << std::endl;

    // Or, Something like this
    #define DEGREES 0
    #define MINUTES 1
    #define SECONDS 2
    std::cout << result.get<MINUTES>() << std::endl;
}

I copied your algorithm, but converted it to use static_cast's instead. I can't comment on the algorithm itself.

peaceofpi · Nov 24th, 2007, 11:16 PM

Quote:

Originally Posted by DaWei

Your code doesn't look half bad

DaWei + praise = ?!

Quote:

Originally Posted by DaWei

(rest of it)

Phew, I thought I did a good job for a second!

Quote:

Originally Posted by Arla

Personally I'd probably create a structure to house the three separate values and return that from the function.

I'll see what I can do with that, but it's not making complete sense yet.

Jesse: Boost is nice (although I haven't gotten it to work yet) but I want to make something I can carry with me anywhere.

Arla · Nov 24th, 2007, 11:26 PM

Having done a bit of websurfing (sorry I use C# so didn't want to post code as my syntax would probably be a bit off) this site

http://www.cplusplus.com/doc/tutorial/classes.html

Seemed to have some good information on what I was meaning, create a class, with three int's in it (Degrees, Minutes and Seconds) and then have the function return your new class as it's result.

peaceofpi · Nov 24th, 2007, 11:45 PM

Well, I understand what you mean, but you can't return a class instance as a function result. Jesse's answer is basically what I want, but I was hoping for a solution within the standard headers.

edit: By the way, Jesse, I tried out the boost solution. It gave errors so I played around with the code (I've never used tuples or boost so it was guesswork) till it was satisfied:

 c++ Syntax (Toggle Plain Text) 
typedef boost::tuples::tuple<int,int,int> tuple;
 
tuple deg2dms( double deg ) 
{
	double n = deg;
 
	int degrees = static_cast<int>( n );
	n -= degrees;
	n *= 60.0;
 
	int minutes = static_cast<int>( n );
	n -= minutes;
	n *= 60.0;
 
	int seconds = static_cast<int>( n );
	if ( (n - seconds) >= 0.5 )
		seconds += 1;
 
	return tuple(degrees, minutes, seconds);
}
typedef boost::tuples::tuple<int,int,int> tuple;

tuple deg2dms( double deg ) 
{
	double n = deg;

	int degrees = static_cast<int>( n );
	n -= degrees;
	n *= 60.0;

	int minutes = static_cast<int>( n );
	n -= minutes;
	n *= 60.0;

	int seconds = static_cast<int>( n );
	if ( (n - seconds) >= 0.5 )
		seconds += 1;

	return tuple(degrees, minutes, seconds);
}

Can't cout<<deg2dms(x); though, apparently there's no << for tuples.

Jessehk · Nov 25th, 2007, 8:30 AM

Quote:

Originally Posted by peaceofpi

Can't cout<<deg2dms(x); though, apparently there's no << for tuples.

c++ Syntax (Toggle Plain Text)

#include "boost/tuple/tuple_io.hpp"

Which defines an operator<< that outputs things in the form

(Toggle Plain Text)

(x y z)

But if you really want to do it with standard headers, you should just make a custom struct and return it -- basically what Arla suggested.

Jessehk · Nov 25th, 2007, 9:05 AM

Quote:

Originally Posted by peaceofpi

Well, I understand what you mean, but you can't return a class instance as a function result.

Hold on a second. What do you mean?

 c++ Syntax (Toggle Plain Text) 
#include <iostream>
 
class Heading {
private:
    int degrees_;
    int minutes_;
    int seconds_;
public:
    Heading( int degrees, int minutes, int seconds );
 
    int degrees() const { return degrees_; }
    int minutes() const { return minutes_; }
    int seconds() const { return seconds_; }
};
 
std::ostream &operator<<( std::ostream &os, const Heading &heading ) {
    os << "(" << heading.degrees() << ", " << heading.minutes() << ", " << heading.seconds() << ")";
    return os;
}
 
Heading::Heading( int degrees, int minutes, int seconds ) :
    degrees_( degrees ),
    minutes_( minutes ),
    seconds_( seconds ) {}
 
Heading testFunction() {
    return Heading( 33, 5, 2 );
}
 
int main() {
    Heading heading = testFunction();
 
    std::cout << heading << std::endl;
}
#include <iostream>

class Heading {
private:
    int degrees_;
    int minutes_;
    int seconds_;
public:
    Heading( int degrees, int minutes, int seconds );
    
    int degrees() const { return degrees_; }
    int minutes() const { return minutes_; }
    int seconds() const { return seconds_; }
};

std::ostream &operator<<( std::ostream &os, const Heading &heading ) {
    os << "(" << heading.degrees() << ", " << heading.minutes() << ", " << heading.seconds() << ")";
    return os;
}

Heading::Heading( int degrees, int minutes, int seconds ) :
    degrees_( degrees ),
    minutes_( minutes ),
    seconds_( seconds ) {}

Heading testFunction() {
    return Heading( 33, 5, 2 );
}

int main() {
    Heading heading = testFunction();
    
    std::cout << heading << std::endl;
}

(Toggle Plain Text)

$ ./example
(33, 5, 2)

You are copying the instance on the return from the function (which does add overhead), but the same thing happens with Boost.Tuple. The only reason to use Boost.Tuple in this case in convenience.

peaceofpi · Nov 25th, 2007, 11:09 AM

Quote:

Originally Posted by Jessehk

c++ Syntax (Toggle Plain Text)

#include "boost/tuple/tuple_io.hpp"

That helps!

Oops, operator<< slipped my mind.

 c++ Syntax (Toggle Plain Text) 
using namespace boost::tuples;
tuple<int,string,int,string,int,string> deg2dms(double deg) 
{
	double n = deg;
 
	int degrees = static_cast<int>(n);
	n -= degrees;
	n *= 60.0;
 
	int minutes = static_cast<int>(n);
	n -= minutes;
	n *= 60.0;
 
	int seconds = static_cast<int>(n);
	if ( (n - seconds) >= 0.5 )
		seconds += 1;
 
	tuple<int,string,int,string,int,string> dms
	(degrees,"degrees,",minutes,"minutes,",seconds,"seconds");
	return dms;
}
using namespace boost::tuples;
tuple<int,string,int,string,int,string> deg2dms(double deg) 
{
	double n = deg;

	int degrees = static_cast<int>(n);
	n -= degrees;
	n *= 60.0;

	int minutes = static_cast<int>(n);
	n -= minutes;
	n *= 60.0;

	int seconds = static_cast<int>(n);
	if ( (n - seconds) >= 0.5 )
		seconds += 1;
		
	tuple<int,string,int,string,int,string> dms
	(degrees,"degrees,",minutes,"minutes,",seconds,"seconds");
	return dms;
}

Nov 24th, 2007, 1:05 PM	#1
peaceofpi hi: for(;;) goto hi; Join Date: Jun 2006 Posts: 91 Rep Power: 3	Is there a better way to do this? I'm recreating whatever things from algebra/trigonometry that I can think of as a learning exercise. I wanted to post the whole thing for feedback but I don't know how that'd go in this board (it is for support after all). This function turns a degree measure into degrees, minutes, and seconds. It works fine but I want to know if there's a better way to put the results in one place rather than three stringstreams and three strings. I want the function to return a string because there are three numbers as an answer. c++ Syntax (Toggle Plain Text) string deg2dms(double deg) { double n = deg; int degrees = (int)n; n -= degrees; n = 60.0; int minutes = (int)n; n -= minutes; n = 60.0; int seconds = (int)n; if ( (n - seconds) >= 0.5 ) seconds += 1; stringstream degss; stringstream minss; stringstream secss; string degstr; string minstr; string secstr; degss << degrees; minss << minutes; secss << seconds; degss >> degstr; minss >> minstr; secss >> secstr; return degstr + " " + minstr + " " + secstr; } string deg2dms(double deg) { double n = deg; int degrees = (int)n; n -= degrees; n = 60.0; int minutes = (int)n; n -= minutes; n = 60.0; int seconds = (int)n; if ( (n - seconds) >= 0.5 ) seconds += 1; stringstream degss; stringstream minss; stringstream secss; string degstr; string minstr; string secstr; degss << degrees; minss << minutes; secss << seconds; degss >> degstr; minss >> minstr; secss >> secstr; return degstr + " " + minstr + " " + secstr; } __________________ How do you play Religious Roulette? Stand around in a circle and blaspheme till someone gets struck by lightning.

Nov 24th, 2007, 2:18 PM	#2
DaWei Resident Grouch Join Date: Jun 2005 Posts: 6,453 Rep Power: 10	Re: Is there a better way to do this? The use of stringstreams, in this instance, amounts to a presentation issue. You have to deal with that, make the conversions, fiddlefart around, and convert back to presentation. Your code doesn't look half bad, but you're expecting all your operations to work properly and magically. Get a life. Things don't always work out. Test for success and take appropriate actions if something fails. Anything less is the action of an unemployable newbie or a schlock. Choose your category. Your potential employer is entitled to disagree. __________________ Abstraction doesn't make it impossible to write bad code; it makes it possible to write superior code. Contributor's Corner: Grumpy on C++ Exceptions DaWei on Pointers

Nov 24th, 2007, 2:22 PM	#3
Arla Hobbyist Programmer Join Date: Mar 2005 Posts: 208 Rep Power: 4	Re: Is there a better way to do this? Personally I'd probably create a structure to house the three separate values and return that from the function. Stringing them together to return just means you end up with an amalgamated text string that you would then probably need to deconstruct to use elsewhere.

Nov 24th, 2007, 3:26 PM	#4
Jessehk The Oblivious One Join Date: May 2005 Location: Ontario, Canada Posts: 644 Rep Power: 4	Re: Is there a better way to do this? Some people might think this is overcomplicated, but if you have Boost I like the Tuple library. It's specifically designed to make returning multple values from a function easier. c++ Syntax (Toggle Plain Text) #include <iostream> #include <boost/tuple/tuple.hpp> typedef boost::tuple<int, int, int> ResultType; ResultType deg2dms( double deg ) { double n = deg; int degrees = static_cast<int>( n ); n -= degrees; n = 60.0; int minutes = static_cast<int>( n ); n -= minutes; n = 60.0; int seconds = static_cast<int>( n ); if ( (n - seconds) >= 0.5 ) seconds += 1; return ResultType( degrees, minutes, seconds ); } int main() { ResultType result = deg2dms( 34.5 ); //Access each element //In this case, we're accessing the degrees std::cout << result.get<0>() << std::endl; // Or, Something like this #define DEGREES 0 #define MINUTES 1 #define SECONDS 2 std::cout << result.get<MINUTES>() << std::endl; } #include <iostream> #include <boost/tuple/tuple.hpp> typedef boost::tuple<int, int, int> ResultType; ResultType deg2dms( double deg ) { double n = deg; int degrees = static_cast<int>( n ); n -= degrees; n = 60.0; int minutes = static_cast<int>( n ); n -= minutes; n = 60.0; int seconds = static_cast<int>( n ); if ( (n - seconds) >= 0.5 ) seconds += 1; return ResultType( degrees, minutes, seconds ); } int main() { ResultType result = deg2dms( 34.5 ); //Access each element //In this case, we're accessing the degrees std::cout << result.get<0>() << std::endl; // Or, Something like this #define DEGREES 0 #define MINUTES 1 #define SECONDS 2 std::cout << result.get<MINUTES>() << std::endl; } I copied your algorithm, but converted it to use static_cast's instead. I can't comment on the algorithm itself. __________________ Dr. Zoidberg: [ecstatic] I'm going to a movie... with FRIENDS!

Nov 24th, 2007, 11:26 PM	#6
Arla Hobbyist Programmer Join Date: Mar 2005 Posts: 208 Rep Power: 4	Re: Is there a better way to do this? Having done a bit of websurfing (sorry I use C# so didn't want to post code as my syntax would probably be a bit off) this site http://www.cplusplus.com/doc/tutorial/classes.html Seemed to have some good information on what I was meaning, create a class, with three int's in it (Degrees, Minutes and Seconds) and then have the function return your new class as it's result.

Nov 24th, 2007, 11:45 PM	#7
peaceofpi hi: for(;;) goto hi; Join Date: Jun 2006 Posts: 91 Rep Power: 3	Re: Is there a better way to do this? Well, I understand what you mean, but you can't return a class instance as a function result. Jesse's answer is basically what I want, but I was hoping for a solution within the standard headers. edit: By the way, Jesse, I tried out the boost solution. It gave errors so I played around with the code (I've never used tuples or boost so it was guesswork) till it was satisfied: c++ Syntax (Toggle Plain Text) typedef boost::tuples::tuple<int,int,int> tuple; tuple deg2dms( double deg ) { double n = deg; int degrees = static_cast<int>( n ); n -= degrees; n = 60.0; int minutes = static_cast<int>( n ); n -= minutes; n = 60.0; int seconds = static_cast<int>( n ); if ( (n - seconds) >= 0.5 ) seconds += 1; return tuple(degrees, minutes, seconds); } typedef boost::tuples::tuple<int,int,int> tuple; tuple deg2dms( double deg ) { double n = deg; int degrees = static_cast<int>( n ); n -= degrees; n = 60.0; int minutes = static_cast<int>( n ); n -= minutes; n = 60.0; int seconds = static_cast<int>( n ); if ( (n - seconds) >= 0.5 ) seconds += 1; return tuple(degrees, minutes, seconds); } Can't `cout<<deg2dms(x);` though, apparently there's no << for tuples. __________________ How do you play Religious Roulette? Stand around in a circle and blaspheme till someone gets struck by lightning. Last edited by peaceofpi; Nov 25th, 2007 at 12:11 AM.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Programming Forums > Application Development > C++

Is there a better way to do this?