![]() |
|
![]() |
|
|
Thread Tools | Display Modes |
|
|
#1 |
|
Hobbyist Programmer
|
intensive code review
this is the capstone project for my GUI programming class. my group is making a program to handle and manage studnets and tutors signing in and out of the schools math center.
so far we have a basic sign in and out for studnents with time stamping, adding new students, reading and writing student list to disk. when the program loads it checks to see if the file of students exists then reads it or makes a new one. the tutor tab doesnt do anything. the admin tab is buggy but the change student info works.it is not finished and is a work in progerss. Would you all please look over our code and see what should be changed, comment style, class structure, better OO modling, problem solving, break up the large class file into smaller peaces and so on.
__________________
i dont know much about programming but i try to help |
|
|
|
|
|
#2 |
|
Newbie
|
Good Work
I think you made a very good work.The GUI is excellent.
![]() Computer Science & Information Technology Engineer. My Place on the net : http://www.codemiles.com Last edited by msi_333; May 29th, 2007 at 11:49 AM. |
|
|
|
|
|
#3 |
|
Hobbyist Programmer
|
i am more conserned about the code rather than how it looks
__________________
i dont know much about programming but i try to help |
|
|
|
|
|
#4 |
|
Professional Programmer
|
If it were mine I would definitely make an effort at moving some code out of MathTracker.java. There's way too much in there that could easily be moved to other classes imo.
|
|
|
|
|
|
#5 |
|
Hobbyist Programmer
|
why? all the code is related. more lines means its better!
__________________
i dont know much about programming but i try to help |
|
|
|
|
|
#6 | |
|
Professional Programmer
|
Actually all the classes in MathTracker.java should stay in separate files. There's no point in making one big file.
Quote:
__________________
Don't take life too seriously, it's not permanent ! |
|
|
|
|
|
|
#7 |
|
Newbie
|
Yes
IT is a good Design is to make small classes and using OOP Concepts ,to make it readable and easy to understand and also easy to add more function to it
![]() |
|
|
|
|
|
#8 | |
|
Hobbyist Programmer
|
Quote:
do you have any suggestions to convise my group to slipt it up? I said it was way too difficult to browse the file considering there are like 30 methods and 10 classes all in one file! args!!
__________________
i dont know much about programming but i try to help |
|
|
|
|
|
|
#9 | |
|
Professional Programmer
|
Well, what if : your GUI would be 10times more complex ? what then? there's no point in making a 3000 lines file. Imagine working on line 789 and 1934
. It would be a nightmare. Similar code is grouped in separate folders: You can have a folder for the GUI stuff and another for the rest of your logic ... and so on , depending on your project.+ what msi_333 said Quote:
And another thing: What if you had 2 windows . The first being MathTracker.java and the next Something.java, and they would need essentially the same inner classes .What would you do then ? where would you put the inner classes ? Something.java or MathTracker.java ). The best place for them is in other files.
__________________
Don't take life too seriously, it's not permanent ! |
|
|
|
|
|
|
#10 |
|
Hobbyist Programmer
|
thanks. I do understand these reasons, I just have a hard time explaining what I know is right to people. I will write these notes down and present it to the group. I hope i don't come off as a conceited smart ass.
![]()
__________________
i dont know much about programming but i try to help |
|
|
|
![]() |
| Bookmarks |
| Currently Active Users Viewing This Thread: 1 (0 members and 1 guests) | |
| Thread Tools | |
| Display Modes | |
|
|
Similar Threads
|
||||
| Thread | Thread Starter | Forum | Replies | Last Post |
| review my code | mrynit | Java | 8 | Apr 29th, 2007 10:52 PM |
| EXECryptor software protection | Jean5 | C++ | 35 | Oct 10th, 2006 7:10 PM |
| How to post a question | nnxion | C++ | 10 | Jun 3rd, 2005 11:53 AM |
| How to post a question | nnxion | C++ | 0 | Jun 3rd, 2005 8:55 AM |
| How to post a question | nnxion | C | 0 | Jun 3rd, 2005 8:55 AM |