Programming Forums - help for (for)

Programming Forums (http://www.programmingforums.org/forumindex.php)

- PHP (http://www.programmingforums.org/forum29.html)

- - help for (for) (http://www.programmingforums.org/showthread.php?t=15500)

<? 

$c = $_POST['col'];

$r = $_POST['rw'];

?>

	

<? 

	for($cvchk = 1; $cchk<= $c; $cchk ++)

		{

			echo $cchk."<br>";

			

		for($rchk = 1; $rchk<= $r; $rchk ++)

				{ 

					echo $rchk." ";

				}

		}		

		

?>

i don't know what is wrong with this one
i want the output to become this one

1 2 3 4
2 3 4 1
3 4 1 2
4 1 2 3

i really kinda new with this thanks a lot guys

guys can you help me out with this one.. :icon_redface:

Re: help for (for)

Couple of things, firtsly could you use code tags to place code in a post.

Secondly welcome to the forums.

OK one of your first problems was your initial for statement had seom variables named wrongly

for($cvchk = 1; $cchk <= $c; $cchk ++)

then there were a few other problems to such as at no point were you specifying to start from any number other than 1, so it would always count from 1-4.

you were also echoing the value of cchk for no reason.

here is the code i come up with not the best for many reasons, such as im not a great programmer/scripter plus i don't know the PHP language but here it is anyway

<? 
$c = $_POST['col'];
$r = $_POST['rw'];
?>
 
<? 
for($cvchk = 1; $cvchk <= $c; $cvchk ++)
{
   $x = $cvchk;
   for($rchk = 1; $rchk <= $r; $rchk ++)
   {  
      if ($x > 4)
      {
         $x = 1;  
      }
      echo $x." ";
      $x += 1;
   }
   echo "<br />";
} 
?>

As you can see i also check to see if x goes above 4 if so it returns it to 1, this ensure that it doesn't produce this outcome

1234
2345
3456
4567

Also this is unchecked but to make this work for any number of rows, so the highest number = the number of ros simple change this

if ($x > 4)
{
     $x = 1;  
}
.....
if ($x > $r)
{
      $x = 1;  
}

Hope this helped if you need anything else just ask.

Re: help for (for)

This is a bit more memory intensive and slower as well, but I like how it works:

<?php
// Get matrix size
$rowSize = $_POST['rw'];
$colSize = $_POST['col'];
?>
<?php
// Construct matrix
$shiftable = array();
for($i = 0; $i < $rowSize; $i++){
        $temp = array();
        for($j = 0; $j < $colSize; $j++){
                array_push($temp, $j);
        }
        array_push($shiftable, $temp);
        shiftRow($shiftable, $i, $i);        // Shift matrix accordingly
}
?>
<pre>
<?php
// Print matrix
foreach($shiftable as $row){
        foreach($row as $j => $value){
                echo str_pad($value, 2, ' ', STR_PAD_LEFT);
        }
        echo "\n";
}
?>
</pre>
<?php
// Row shifting function
function shiftRow(&$dArray, $shiftRow, $shiftAmount){
        for($i = 0; $i < $shiftAmount; $i++){
                array_push($dArray[$shiftRow], array_shift($dArray[$shiftRow]));
        }
}
?>