Programming Forums > Script Programming > Python

coldDeath · Nov 17th, 2005, 3:36 PM

Sane I looked over your code, thats the sort of way I need to be thinking about my code, such as the get_data() function

Ooble · Nov 17th, 2005, 5:08 PM

Well, not nasty, but y'know... if it's a simple app, I wouldn't overcomplicate it like that.

Cerulean · Nov 17th, 2005, 5:46 PM

Bear in mind that functions should generally do one thing and do it well. The fact that get_data collects data but also writes and reads to the console makes it seem a little sloppy, plus the fact that the methods are ~two lines long implies that they shouldn't be methods. Seems a little like you've taken a simple program without functions and just sliced it up to use them.
Also, why do you pass `info` to `main` when `info` is already a global?

Sane · Nov 17th, 2005, 6:57 PM

Quote:

Originally Posted by Cerulean

Seems a little like you've taken a simple program without functions and just sliced it up to use them.

I did that to organize ideas.

It's a good idea to get in that habit for when you really need it.

But the main function is needed to make it cleanly recursive.

Also, I keep in mind I've seen professional code with one line functions, just for the sake of organization in a giant class.

Quote:

Originally Posted by Cerulean

Also, why do you pass `info` to `main` when `info` is already a global?

It's a coding habit I guess.

Dietrich · Nov 18th, 2005, 10:58 AM

You are on the way to Python Nebula!

Just a hint, since you don't do any calculations with your numeric input, keep 'em all strings and use only raw_input().

The input() function has a nasty habit, it actually uses raw_input() and then converts the value to a number with the eval() function. This function is much too general, since some nasty person could tell it to erase your hard drive and it would do it!!!!!! It's much saver to use raw_input() and then process the string to a number in your code with one of the less general functions available.

Let's not forget, Python was developed to be readable, at least compared to Perl code!

Arevos · Nov 18th, 2005, 2:04 PM

Quote:

Originally Posted by Cerulean

plus the fact that the methods are ~two lines long implies that they shouldn't be methods.

Not if these those methods prevent you repeating yourself, or make the code clearer.

For instance:

(Toggle Plain Text)

def all(s):
   for x in s:
      if x: return False
   return True

This is a small function, but terribly useful, as you can use it to check whether any object fails a condition in a sequence:

(Toggle Plain Text)

# ensure all values are less than 5
assert all(i < 5 for i in my_list)

Indeed, one could go further and just use one-liners:

(Toggle Plain Text)

def count(s):
   return sum(1 for x in s)

def all(s):
   return count(1 for x in s if not x) == 0

Cerulean · Nov 18th, 2005, 4:24 PM

Of course, and there are obvious merits in boosting readability, but is it really necessary in something like this? I think it qualifies as a waste of important time.

Sane · Nov 18th, 2005, 8:02 PM

My time? Important? :eek:

Pfft.

Arevos · Nov 19th, 2005, 3:09 AM

Quote:

Originally Posted by Sane

(Toggle Plain Text)

def give_data(data, info):
    i = 0
    for i in range(len(info)):
        print "What %s: %s"%( info[i], data[i] )
        i += 1

Shouldn't this be:

(Toggle Plain Text)

def give_data(data, info):
    for i in range(len(info)):
        print "What %s: %s"%( info[i], data[i] )

...?

Quote:

Originally Posted by Cerulean

Of course, and there are obvious merits in boosting readability, but is it really necessary in something like this? I think it qualifies as a waste of important time.

Well, it teaches good programming structure, which is always useful

Sane · Nov 19th, 2005, 9:31 AM

Hahaha, sorry. That's what happens when I get too used to one language over another (Turing).

Nov 17th, 2005, 3:36 PM	#11
coldDeath Expert Programmer Join Date: Aug 2005 Location: UK Posts: 862 Rep Power: 4	Sane I looked over your code, thats the sort of way I need to be thinking about my code, such as the get_data() function __________________ Programming Tutorials - Linux Installation Guide - Learn Python - Learn C++ Got Slack? Join us at #programmingforums @ irc.freenode.net! My software never has bugs. It just develops random features.

Nov 17th, 2005, 5:08 PM	#12
Ooble I eat cake for breakfast. Join Date: Jul 2004 Location: In my box. Posts: 4,434 Rep Power: 9	Well, not nasty, but y'know... if it's a simple app, I wouldn't overcomplicate it like that. __________________ Me :: You :: Them

Nov 18th, 2005, 10:58 AM	#15
Dietrich Professional Programmer Join Date: Feb 2005 Posts: 434 Rep Power: 4	You are on the way to Python Nebula! Just a hint, since you don't do any calculations with your numeric input, keep 'em all strings and use only raw_input(). The input() function has a nasty habit, it actually uses raw_input() and then converts the value to a number with the eval() function. This function is much too general, since some nasty person could tell it to erase your hard drive and it would do it!!!!!! It's much saver to use raw_input() and then process the string to a number in your code with one of the less general functions available. Let's not forget, Python was developed to be readable, at least compared to Perl code! __________________ I looked it up on the Intergnats!

Nov 18th, 2005, 8:02 PM	#18
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 1,890 Rep Power: 5	My time? Important? :eek: Pfft. __________________ Waterloo's Canadian Computing Competition (CCC) - Stage 2 Problems, Solutions, and Test Data

Nov 19th, 2005, 9:31 AM	#20
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 1,890 Rep Power: 5	Hahaha, sorry. That's what happens when I get too used to one language over another (Turing). __________________ Waterloo's Canadian Computing Competition (CCC) - Stage 2 Problems, Solutions, and Test Data

Nov 17th, 2005, 5:46 PM	#13
Cerulean Professional Programmer Join Date: Apr 2005 Location: London, England Posts: 459 Rep Power: 4	Bear in mind that functions should generally do one thing and do it well. The fact that get_data collects data but also writes and reads to the console makes it seem a little sloppy, plus the fact that the methods are ~two lines long implies that they shouldn't be methods. Seems a little like you've taken a simple program without functions and just sliced it up to use them. Also, why do you pass `info` to `main` when `info` is already a global?

Nov 18th, 2005, 4:24 PM	#17
Cerulean Professional Programmer Join Date: Apr 2005 Location: London, England Posts: 459 Rep Power: 4	Of course, and there are obvious merits in boosting readability, but is it really necessary in something like this? I think it qualifies as a waste of important time.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Programming Forums > Script Programming > Python

Python Info prog.