Programming Forums > Application Development > C++

layer · Apr 28th, 2005, 12:26 AM

Hehe, well, I said I was done for the day, but it's now 12:10 AM and it's a new day. So, I have a question, would someone mind proof-reading this segment of code? It's a function to listen for WinSock. I know that it is probably way off and not functional, but I'm trying, especially with the paremeters in the function, I don't think I placed them 'inside' the function correctly...

(Toggle Plain Text)

int WinSockListen(int Ip, int Port, int backlog){
    listenS = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
    if (listenS == INVALID_SOCKET) 
    {
                WinSockCloseSocket(listenS);
                WinSockClose();
                return EXIT_SUCCESS;
    }
    SOCKADDR_IN info;
    info.sin_family = AF_INET;
    info.sin_addr.s_addr = Ip;
    info.sin_port = htons(Port);
    ret = bind(listenS,(LPSOCKADDR)&info,sizeof(struct sockaddr));
    if (ret == SOCKET_ERROR)
    {
            WinSockCloseSocket(listenS);
            WinSockClose();
            return EXIT_SUCCESS;
    }
    ret = listen(listenS, backlog);
    if (ret == SOCKET_ERROR)
    {
            WinSockCloseSocket(listenS);
            WinSockClose();
            return EXIT_SUCCESS;
    }
}

I think Ip (the first paremeter) should be a string, but I get this error when I label it as string inside the paremeters:

Quote:

Compiler: Default compiler
Executing g++.exe...
g++.exe "C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp" -o "C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.exe" -I"C:\Dev-Cpp\lib\gcc\mingw32\3.4.2\include" -I"C:\Dev-Cpp\include\c++\3.4.2\backward" -I"C:\Dev-Cpp\include\c++\3.4.2\mingw32" -I"C:\Dev-Cpp\include\c++\3.4.2" -I"C:\Dev-Cpp\include" -L"C:\Dev-Cpp\lib" -lwsock32
C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp:28: error: `string' was not declared in this scope
C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp:28: error: expected primary-expression before "int"
C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp:28: error: expected primary-expression before "int"
C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp:28: error: initializer expression list treated as compound expression
C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp:28: error: expected `,' or `;' before '{' token

Execution terminated

But when I change Ip to int in the paremeters, it compiles fine... But could someone please point out where I may be going wrong somewhere in the code?

Ok, I just tested the "WinSockListen" function roughly, and heres what I get when trying to compile... I know it's gotta be something simple because its an invalid conversion! :eek: Am I supposed to change the paremeters in WinSockListen? Well, here is the attmept I have made to use the WinSockListen function in my code:

(Toggle Plain Text)

case WM_COMMAND:
         if((HWND)lParam == hconnectIP)
             {
                         char IpMem[40];
                         char sPort[10];
                         GetWindowText(hPortData, sPort, sizeof(sPort)); 
                         char sIp[30];
                         GetWindowText(hIPData, sIp, sizeof(sIp));
                         strcat(IpMem, sIp);
                         strcat(IpMem, ":");
                         strcat(IpMem, sPort);
                         MessageBox(NULL, IpMem, "Ip and Port", MB_OK);
                         WinSockListen(sIp, sPort, 5);
                         MessageBox(NULL, "worked?", "DEBUG", MB_OK);
             }
        break;

And here are the errors I get when trying to compile all of my code with that:

Quote:

Compiler: Default compiler
Executing g++.exe...
g++.exe "C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp" -o "C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.exe" -I"C:\Dev-Cpp\lib\gcc\mingw32\3.4.2\include" -I"C:\Dev-Cpp\include\c++\3.4.2\backward" -I"C:\Dev-Cpp\include\c++\3.4.2\mingw32" -I"C:\Dev-Cpp\include\c++\3.4.2" -I"C:\Dev-Cpp\include" -L"C:\Dev-Cpp\lib" -lwsock32
C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp: In function `LRESULT WindowProcedure(HWND__*, UINT, WPARAM, LPARAM)':
C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp:214: error: invalid conversion from `char*' to `int'
C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp:214: error: initializing argument 1 of `int WinSockListen(int, int, int)'
C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp:214: error: invalid conversion from `char*' to `int'
C:\Documents and Settings\MYNAME\Desktop\WinSock #2\server.cpp:214: error: initializing argument 2 of `int WinSockListen(int, int, int)'

Execution terminated

Soo... Would someone be oh so kind and point out where I'm going wrong? I hope I provided enough information (I think I provided plenty

)
Again, thanks in advance...

PS,
You don't have to write any code for me :p I'd rather learn, I just need to know where I'm going wrong so I can do a little research and see how to fix it :o

layer · Apr 28th, 2005, 12:50 PM

Well, obviously it's because sIp and sPort are declared as "char"'s when the paremeters for WinSockListen() are "int"'s. So, any wa around this?

kirkl_uk · Apr 28th, 2005, 1:31 PM

Well, first of all you need to make the function consistent with the parameters you pass. Anyway, this thread should help:

http://www.programmingforums.org/for...ead.php?t=3602

It discusses how to convert a string to an int, so it may prove useful.

kirkl_uk

layer · Apr 28th, 2005, 2:19 PM

Gotchya, totally forgot about atoi... :o Thanks!!

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Apr 28th, 2005, 12:50 PM	#2
layer Hobbyist Programmer Join Date: Feb 2005 Posts: 112 Rep Power: 4	Well, obviously it's because sIp and sPort are declared as "char"'s when the paremeters for WinSockListen() are "int"'s. So, any wa around this?

Apr 28th, 2005, 1:31 PM	#3
kirkl_uk Programmer Join Date: Apr 2005 Location: England Posts: 86 Rep Power: 4	Well, first of all you need to make the function consistent with the parameters you pass. Anyway, this thread should help: http://www.programmingforums.org/for...ead.php?t=3602 It discusses how to convert a string to an int, so it may prove useful. kirkl_uk

Apr 28th, 2005, 2:19 PM	#4
layer Hobbyist Programmer Join Date: Feb 2005 Posts: 112 Rep Power: 4	Gotchya, totally forgot about atoi... :o Thanks!!

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Programming Forums > Application Development > C++

Could someone proof-read this please?