Programming Forums > Application Development > C++

Arnack · May 4th, 2008, 9:30 AM

I haven't used C++ in a while, and right when I get back to starting up again, I fall upon this simple error in my simple code here:

 C++ Syntax (Toggle Plain Text) 
#include <iostream.h>
#include <stdio.h>
#include <string> 
using namespace std;	
 
int main(void)
{
int number1;
int number2;
int number3;
int number4;
int sum;
string relay;
 
cout<<"I'm going to add these numbers you give me. First Number: ";
cin>>number1;
cout<<"next number: ";
cin>>number2;
cout<<"and the next number: ";
cin>>number3;
cout<<"and the last number: ";
cin>>number4;
sum=(number1+number2+number3+number4);
 
{
if(sum < 10){
       relay = "small.";
}
if (sum > 10) && (sum >50)
{
       relay = "big.";
}
 
 
cout<<"Your number is " << relay << "\n";
 
 
system("PAUSE");
#include <iostream.h>
#include <stdio.h>
#include <string> 
using namespace std;	

int main(void)
{
int number1;
int number2;
int number3;
int number4;
int sum;
string relay;

cout<<"I'm going to add these numbers you give me. First Number: ";
cin>>number1;
cout<<"next number: ";
cin>>number2;
cout<<"and the next number: ";
cin>>number3;
cout<<"and the last number: ";
cin>>number4;
sum=(number1+number2+number3+number4);

{
if(sum < 10){
       relay = "small.";
}
if (sum > 10) && (sum >50)
{
       relay = "big.";
}


cout<<"Your number is " << relay << "\n";


system("PAUSE");

It comes out with errors such as: expected
`;' before '(' token
expected identifier before '(' token

Any help, please?

Klarre · May 4th, 2008, 10:19 AM

Error:
if (sum > 10) && (sum >50)

Should be:
if ( (sum > 10) && (sum >50) )

Arnack · May 4th, 2008, 10:38 AM

Silly me

Thanks... and just out of curiosity, how can I get the program to go back to the start after ending instead of "Press any key to continue" and the command prompt exits?

Klarre · May 4th, 2008, 10:42 AM

Try changing system("PAUSE"); to cin.get();

Arnack · May 4th, 2008, 10:59 AM

Okay- all that happens is that when I input all 4 numbers the screen just exits.

peaceofpi · May 4th, 2008, 11:00 AM

1. You don't need stdio.h (it should be cstdio for c++ anyway).
2. iostream.h should be iostream
3. As for your last question: place everything from the first to the last cout in a while (true) { } loop or something of the sort.
4. Don't forget to return 0; and close main.

Arnack · May 4th, 2008, 11:25 AM

Thanks, peaceofpi. That was helpful and I've fixed my problem; yes I want to get deeper and more complicated in this simple program I have built.

 C++ Syntax (Toggle Plain Text) 
#include <iostream>
#include <string> 
using namespace std;	
 
int main(void)
{
system("TITLE Addition");
system("COLOR 3");
int number1;
int number2;
int number3;
int number4;
int sum;
int one = 1;
string yesno;
string relay;
 
while (true)
{
cout<<"I'm going to add these numbers you give me. First Number: ";
cin>>number1;
cout<<"next number: ";
cin>>number2;
cout<<"and the next number: ";
cin>>number3;
cout<<"and the last number: ";
cin>>number4;
sum=(number1+number2+number3+number4);
 
 
if(sum < 10) {
relay = "small";
cout<<"Your number is " << sum << " and it is a " << relay << " number. \n";
}
else if ( sum > 10 && sum < 50 ) {
relay = "big";
cout<<"Your number is " << sum << " and it is a " << relay << " number. \n";
}
else if (sum > 50 && sum <150 ) {
relay = "large";
cout<<"Your number is " << sum << " and it is a " << relay << " number. \n";
}
else { 
cout<<"You have a really big number \n" ;
}
 
cout<<"Try again? Y/N: ";
cin>> yesno;
if (yesno == "Y") {
return 0;
}
else if (yesno == "N") {
system("pause");
}
}
}
#include <iostream>
#include <string> 
using namespace std;	

int main(void)
{
system("TITLE Addition");
system("COLOR 3");
int number1;
int number2;
int number3;
int number4;
int sum;
int one = 1;
string yesno;
string relay;

while (true)
{
cout<<"I'm going to add these numbers you give me. First Number: ";
cin>>number1;
cout<<"next number: ";
cin>>number2;
cout<<"and the next number: ";
cin>>number3;
cout<<"and the last number: ";
cin>>number4;
sum=(number1+number2+number3+number4);


if(sum < 10) {
relay = "small";
cout<<"Your number is " << sum << " and it is a " << relay << " number. \n";
}
else if ( sum > 10 && sum < 50 ) {
relay = "big";
cout<<"Your number is " << sum << " and it is a " << relay << " number. \n";
}
else if (sum > 50 && sum <150 ) {
relay = "large";
cout<<"Your number is " << sum << " and it is a " << relay << " number. \n";
}
else { 
cout<<"You have a really big number \n" ;
}

cout<<"Try again? Y/N: ";
cin>> yesno;
if (yesno == "Y") {
return 0;
}
else if (yesno == "N") {
system("pause");
}
}
}

As you see here, I have added a "Try Again?" question at the end of the program. I have ran into a problem, though. When I type in "Y" it simply exits the program. When I type in "N" it asks me to press any key to continue, and then it starts the program over again.
But what I have done is basically reversed the Y/N if statements:

 C++ Syntax (Toggle Plain Text) 
if (yesno == "Y") {
system("pause");
}
else if (yesno == "N") {
return 0;
if (yesno == "Y") {
system("pause");
}
else if (yesno == "N") {
return 0;

which works perfectly.

Sane · May 4th, 2008, 11:31 AM

(Toggle Plain Text)

if (yesno == "Y") {
return 0;
}
else if (yesno == "N") {
system("pause");
}

The command "return" exits from main. Therefore, if they enter "Y", main is exited. You want the program to terminate if they hit "N", otherwise ignore the input.

(Toggle Plain Text)

        cout << "Try again? Y/N: ";
        cin >> yesno;
        if(yesno == "N") {
            return 0;
        }
    }
}

By the way, you should probably practice proper indenting style. It makes code a lot more readable. One popular method is 4 spaces per block, keeping the open bracket on the same line as what opens the block, and the close bracket on a new line a level down (as shown in my posted code).

Arnack · May 4th, 2008, 11:39 AM

Thanks a lot

I will also try proper indenting techniques as well.

peaceofpi · May 4th, 2008, 2:20 PM

Here's your code indented and fixed up a bit.

 c++ Syntax (Toggle Plain Text) 
#include <iostream>
#include <string> 
using namespace std;    
 
int main(void)
{
    system("TITLE Addition");
    system("COLOR 3");
    int number1 = 0, number2 = 0, number3 = 0, number4 = 0, sum = 0;
    // int one = 1; <-- never used
    string yesno;
    // string relay; <-- useless
    bool bCont = true;
    while (bCont) {
        cout<<"I'm going to add these numbers you give me. First Number: ";
        cin>>number1;
        cout<<"next number: ";
        cin>>number2;
        cout<<"and the next number: ";
        cin>>number3;
        cout<<"and the last number: ";
        cin>>number4;
        sum = number1 + number2 + number3 + number4;
 
        if(sum < 10)
            cout<<"Your number is " << sum << " and it is a small number. \n";
        else if ( sum > 10 && sum < 50 )
            cout<<"Your number is " << sum << " and it is a big number. \n";
        else if (sum > 50 && sum <150 )
            cout<<"Your number is " << sum << " and it is a large number. \n";
        else
            cout<<"You have a really big number \n" ;
 
        cout<<"Try again? Y/N: ";
        cin>> yesno;
        if (yesno == "Y" || yesno == "y")
            continue;
        else
            bCont = false;
    }
    cin.get();
    return 0;
}
#include <iostream>
#include <string> 
using namespace std;    

int main(void)
{
    system("TITLE Addition");
    system("COLOR 3");
    int number1 = 0, number2 = 0, number3 = 0, number4 = 0, sum = 0;
    // int one = 1; <-- never used
    string yesno;
    // string relay; <-- useless
    bool bCont = true;
    while (bCont) {
        cout<<"I'm going to add these numbers you give me. First Number: ";
        cin>>number1;
        cout<<"next number: ";
        cin>>number2;
        cout<<"and the next number: ";
        cin>>number3;
        cout<<"and the last number: ";
        cin>>number4;
        sum = number1 + number2 + number3 + number4;
        
        if(sum < 10)
            cout<<"Your number is " << sum << " and it is a small number. \n";
        else if ( sum > 10 && sum < 50 )
            cout<<"Your number is " << sum << " and it is a big number. \n";
        else if (sum > 50 && sum <150 )
            cout<<"Your number is " << sum << " and it is a large number. \n";
        else
            cout<<"You have a really big number \n" ;
            
        cout<<"Try again? Y/N: ";
        cin>> yesno;
        if (yesno == "Y" || yesno == "y")
            continue;
        else
            bCont = false;
    }
    cin.get();
    return 0;
}

May 4th, 2008, 9:30 AM	#1
Arnack Programmer Join Date: Jul 2005 Posts: 66 Rep Power: 4	Simple if statement question :( I haven't used C++ in a while, and right when I get back to starting up again, I fall upon this simple error in my simple code here: C++ Syntax (Toggle Plain Text) #include <iostream.h> #include <stdio.h> #include <string> using namespace std; int main(void) { int number1; int number2; int number3; int number4; int sum; string relay; cout<<"I'm going to add these numbers you give me. First Number: "; cin>>number1; cout<<"next number: "; cin>>number2; cout<<"and the next number: "; cin>>number3; cout<<"and the last number: "; cin>>number4; sum=(number1+number2+number3+number4); { if(sum < 10){ relay = "small."; } if (sum > 10) && (sum >50) { relay = "big."; } cout<<"Your number is " << relay << "\n"; system("PAUSE"); #include <iostream.h> #include <stdio.h> #include <string> using namespace std; int main(void) { int number1; int number2; int number3; int number4; int sum; string relay; cout<<"I'm going to add these numbers you give me. First Number: "; cin>>number1; cout<<"next number: "; cin>>number2; cout<<"and the next number: "; cin>>number3; cout<<"and the last number: "; cin>>number4; sum=(number1+number2+number3+number4); { if(sum < 10){ relay = "small."; } if (sum > 10) && (sum >50) { relay = "big."; } cout<<"Your number is " << relay << "\n"; system("PAUSE"); It comes out with errors such as: expected `;' before '(' token expected identifier before '(' token Any help, please? __________________ Ack Network UNDER CONSTRUCTION Now hiring staff of all sorts.

May 4th, 2008, 10:19 AM	#2
Klarre Game engine designer Join Date: May 2005 Location: Sweden Posts: 297 Rep Power: 4	Re: Simple if statement question :( Error: if (sum > 10) && (sum >50) Should be: if ( (sum > 10) && (sum >50) ) __________________ http://www.klarre.se

May 4th, 2008, 10:38 AM	#3
Arnack Programmer Join Date: Jul 2005 Posts: 66 Rep Power: 4	Re: Simple if statement question :( Silly me Thanks... and just out of curiosity, how can I get the program to go back to the start after ending instead of "Press any key to continue" and the command prompt exits? __________________ Ack Network UNDER CONSTRUCTION Now hiring staff of all sorts.

May 4th, 2008, 10:42 AM	#4
Klarre Game engine designer Join Date: May 2005 Location: Sweden Posts: 297 Rep Power: 4	Re: Simple if statement question :( Try changing system("PAUSE"); to cin.get(); __________________ http://www.klarre.se

May 4th, 2008, 10:59 AM	#5
Arnack Programmer Join Date: Jul 2005 Posts: 66 Rep Power: 4	Re: Simple if statement question :( Okay- all that happens is that when I input all 4 numbers the screen just exits. __________________ Ack Network UNDER CONSTRUCTION Now hiring staff of all sorts.

May 4th, 2008, 11:00 AM	#6
peaceofpi hi: for(;;) goto hi; Join Date: Jun 2006 Posts: 87 Rep Power: 3	Re: Simple if statement question :( 1. You don't need stdio.h (it should be cstdio for c++ anyway). 2. iostream.h should be iostream 3. As for your last question: place everything from the first to the last `cout` in a `while (true) { }` loop or something of the sort. 4. Don't forget to `return 0;` and close main. __________________ How do you play Religious Roulette? Stand around in a circle and blaspheme till someone gets struck by lightning.

May 4th, 2008, 11:25 AM	#7
Arnack Programmer Join Date: Jul 2005 Posts: 66 Rep Power: 4	Re: Simple if statement question :( Thanks, peaceofpi. That was helpful and I've fixed my problem; yes I want to get deeper and more complicated in this simple program I have built. C++ Syntax (Toggle Plain Text) #include <iostream> #include <string> using namespace std; int main(void) { system("TITLE Addition"); system("COLOR 3"); int number1; int number2; int number3; int number4; int sum; int one = 1; string yesno; string relay; while (true) { cout<<"I'm going to add these numbers you give me. First Number: "; cin>>number1; cout<<"next number: "; cin>>number2; cout<<"and the next number: "; cin>>number3; cout<<"and the last number: "; cin>>number4; sum=(number1+number2+number3+number4); if(sum < 10) { relay = "small"; cout<<"Your number is " << sum << " and it is a " << relay << " number. \n"; } else if ( sum > 10 && sum < 50 ) { relay = "big"; cout<<"Your number is " << sum << " and it is a " << relay << " number. \n"; } else if (sum > 50 && sum <150 ) { relay = "large"; cout<<"Your number is " << sum << " and it is a " << relay << " number. \n"; } else { cout<<"You have a really big number \n" ; } cout<<"Try again? Y/N: "; cin>> yesno; if (yesno == "Y") { return 0; } else if (yesno == "N") { system("pause"); } } } #include <iostream> #include <string> using namespace std; int main(void) { system("TITLE Addition"); system("COLOR 3"); int number1; int number2; int number3; int number4; int sum; int one = 1; string yesno; string relay; while (true) { cout<<"I'm going to add these numbers you give me. First Number: "; cin>>number1; cout<<"next number: "; cin>>number2; cout<<"and the next number: "; cin>>number3; cout<<"and the last number: "; cin>>number4; sum=(number1+number2+number3+number4); if(sum < 10) { relay = "small"; cout<<"Your number is " << sum << " and it is a " << relay << " number. \n"; } else if ( sum > 10 && sum < 50 ) { relay = "big"; cout<<"Your number is " << sum << " and it is a " << relay << " number. \n"; } else if (sum > 50 && sum <150 ) { relay = "large"; cout<<"Your number is " << sum << " and it is a " << relay << " number. \n"; } else { cout<<"You have a really big number \n" ; } cout<<"Try again? Y/N: "; cin>> yesno; if (yesno == "Y") { return 0; } else if (yesno == "N") { system("pause"); } } } As you see here, I have added a "Try Again?" question at the end of the program. I have ran into a problem, though. When I type in "Y" it simply exits the program. When I type in "N" it asks me to press any key to continue, and then it starts the program over again. But what I have done is basically reversed the Y/N if statements: C++ Syntax (Toggle Plain Text) if (yesno == "Y") { system("pause"); } else if (yesno == "N") { return 0; if (yesno == "Y") { system("pause"); } else if (yesno == "N") { return 0; which works perfectly. __________________ Ack Network UNDER CONSTRUCTION Now hiring staff of all sorts.

May 4th, 2008, 11:31 AM	#8
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 1,835 Rep Power: 5	Re: Simple if statement question :( (Toggle Plain Text) if (yesno == "Y") { return 0; } else if (yesno == "N") { system("pause"); } if (yesno == "Y") { return 0; } else if (yesno == "N") { system("pause"); } The command "return" exits from main. Therefore, if they enter "Y", main is exited. You want the program to terminate if they hit "N", otherwise ignore the input. (Toggle Plain Text) cout << "Try again? Y/N: "; cin >> yesno; if(yesno == "N") { return 0; } } } cout << "Try again? Y/N: "; cin >> yesno; if(yesno == "N") { return 0; } } } By the way, you should probably practice proper indenting style. It makes code a lot more readable. One popular method is 4 spaces per block, keeping the open bracket on the same line as what opens the block, and the close bracket on a new line a level down (as shown in my posted code). __________________ Waterloo's Canadian Computing Competition (CCC) - Stage 2 Problems, Solutions, and Test Data Last edited by Sane; May 4th, 2008 at 11:42 AM.

May 4th, 2008, 11:39 AM	#9
Arnack Programmer Join Date: Jul 2005 Posts: 66 Rep Power: 4	Re: Simple if statement question :( Thanks a lot I will also try proper indenting techniques as well. __________________ Ack Network UNDER CONSTRUCTION Now hiring staff of all sorts.

May 4th, 2008, 2:20 PM	#10
peaceofpi hi: for(;;) goto hi; Join Date: Jun 2006 Posts: 87 Rep Power: 3	Re: Simple if statement question :( Here's your code indented and fixed up a bit. c++ Syntax (Toggle Plain Text) #include <iostream> #include <string> using namespace std; int main(void) { system("TITLE Addition"); system("COLOR 3"); int number1 = 0, number2 = 0, number3 = 0, number4 = 0, sum = 0; // int one = 1; <-- never used string yesno; // string relay; <-- useless bool bCont = true; while (bCont) { cout<<"I'm going to add these numbers you give me. First Number: "; cin>>number1; cout<<"next number: "; cin>>number2; cout<<"and the next number: "; cin>>number3; cout<<"and the last number: "; cin>>number4; sum = number1 + number2 + number3 + number4; if(sum < 10) cout<<"Your number is " << sum << " and it is a small number. \n"; else if ( sum > 10 && sum < 50 ) cout<<"Your number is " << sum << " and it is a big number. \n"; else if (sum > 50 && sum <150 ) cout<<"Your number is " << sum << " and it is a large number. \n"; else cout<<"You have a really big number \n" ; cout<<"Try again? Y/N: "; cin>> yesno; if (yesno == "Y" \|\| yesno == "y") continue; else bCont = false; } cin.get(); return 0; } #include <iostream> #include <string> using namespace std; int main(void) { system("TITLE Addition"); system("COLOR 3"); int number1 = 0, number2 = 0, number3 = 0, number4 = 0, sum = 0; // int one = 1; <-- never used string yesno; // string relay; <-- useless bool bCont = true; while (bCont) { cout<<"I'm going to add these numbers you give me. First Number: "; cin>>number1; cout<<"next number: "; cin>>number2; cout<<"and the next number: "; cin>>number3; cout<<"and the last number: "; cin>>number4; sum = number1 + number2 + number3 + number4; if(sum < 10) cout<<"Your number is " << sum << " and it is a small number. \n"; else if ( sum > 10 && sum < 50 ) cout<<"Your number is " << sum << " and it is a big number. \n"; else if (sum > 50 && sum <150 ) cout<<"Your number is " << sum << " and it is a large number. \n"; else cout<<"You have a really big number \n" ; cout<<"Try again? Y/N: "; cin>> yesno; if (yesno == "Y" \|\| yesno == "y") continue; else bCont = false; } cin.get(); return 0; } __________________ How do you play Religious Roulette? Stand around in a circle and blaspheme till someone gets struck by lightning.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
very simple question. make button change number in edit box	nickm	Delphi	2	Apr 29th, 2006 10:47 PM
A simple programming question	punter	C#	8	Jan 5th, 2006 4:04 PM
A simple question	Master	C++	9	Dec 24th, 2005 2:20 PM
Simple c# question	nez	C#	8	Jul 1st, 2005 6:29 PM
Simple (stupid cause I don't know it) basic question	massive-war	C++	17	Apr 11th, 2005 11:03 PM

Programming Forums > Application Development > C++

Simple if statement question :(