Programming Forums > Web Development and Design > PHP

kishou · Jan 23rd, 2008, 10:23 AM

im just wondering but why won't this isset() function not working? it still inerts the values nito my MySQL database even if the comment box isnt filled out. and thanks!
here's my code:

(Toggle Plain Text)

<?php
if (!isset($_POST['comment'])
{
die("Please out whole form.");
}
else
$con = mysql_connect("localhost","kishou","0973059457");
if (!$con)
{
die('Could not connect: ' . mysql_error());
}
mysql_select_db("aaabatt_mainwebsite", $con);
$name = mysql_real_escape_string($_POST['name']);
$email = mysql_real_escape_string($_POST['email']);
$comment = mysql_real_escape_string($_POST['comment']);
$sql=("INSERT INTO Comments (name, email, comment)
VALUES
('$name','$email','$comment')");
if (!mysql_query($sql,$con))
{
die('Error: ' . mysql_error());
}
mysql_close($con)


?>
<?php
//Redirect Browser
header("Location: http://www.kishouvision.com/tutorials/commentshow.php");
?>
<html>
<head>
<title>
</title>
</head>
<body>
</body>
</html>

kruptof · Jan 23rd, 2008, 10:29 AM

The variable is set but it's empty. Try using the is_empty function

Sane · Jan 23rd, 2008, 1:06 PM

Someone should probably edit his post to censor his MySQL password. Just because it's localhost doesn't necessarily mean its safe.

kishou · Jan 23rd, 2008, 1:30 PM

Quote:

Originally Posted by Sane

Someone should probably edit his post to censor his MySQL password. Just because it's localhost doesn't necessarily mean its safe.

oh thats no my username or password.

Sane · Jan 23rd, 2008, 1:37 PM

Thank goodness. ^_^

You had me worried. And while I'm here, to elaborate on kruptof's well-spotted catch: isset only checks to see if the variable exists. It's useful to stop a user from directly accessing the .php script (where no post data is being sent). In such an event, isset will return false for any corresponding $_POST keys.

kishou · Jan 23rd, 2008, 4:45 PM

Quote:

Originally Posted by Sane

Thank goodness. ^_^

You had me worried. And while I'm here, to elaborate on kruptof's well-spotted catch: isset only checks to see if the variable exists. It's useful to stop a user from directly accessing the .php script (where no post data is being sent). In such an event, isset will return false for any corresponding $_POST keys.

lol. i think i'll just use if (empty ($_POST['comment')
ok now wth? i cant use print,echo, or die...

kishou · Jan 23rd, 2008, 8:26 PM

ok i figured out why lol. all i had to do was just change it to: if ($_POST['comment']==false)
hahhah wow.

titaniumdecoy · Jan 23rd, 2008, 8:50 PM

Quote:

Originally Posted by kishou

oh thats no my username or password.

It's not his, it's his client's.

kishou · Jan 23rd, 2008, 9:03 PM

Quote:

Originally Posted by titaniumdecoy

It's not his, it's his client's.

uh oh speghatti ohs!

Jan 23rd, 2008, 10:23 AM	#1
kishou Programmer Join Date: May 2007 Posts: 52 Rep Power: 2	isset() help im just wondering but why won't this isset() function not working? it still inerts the values nito my MySQL database even if the comment box isnt filled out. and thanks! here's my code: (Toggle Plain Text) <?php if (!isset($_POST['comment']) { die("Please out whole form."); } else $con = mysql_connect("localhost","kishou","0973059457"); if (!$con) { die('Could not connect: ' . mysql_error()); } mysql_select_db("aaabatt_mainwebsite", $con); $name = mysql_real_escape_string($_POST['name']); $email = mysql_real_escape_string($_POST['email']); $comment = mysql_real_escape_string($_POST['comment']); $sql=("INSERT INTO Comments (name, email, comment) VALUES ('$name','$email','$comment')"); if (!mysql_query($sql,$con)) { die('Error: ' . mysql_error()); } mysql_close($con) ?> <?php //Redirect Browser header("Location: http://www.kishouvision.com/tutorials/commentshow.php"); ?> <html> <head> <title> </title> </head> <body> </body> </html> <?php if (!isset($_POST['comment']) { die("Please out whole form."); } else $con = mysql_connect("localhost","kishou","0973059457"); if (!$con) { die('Could not connect: ' . mysql_error()); } mysql_select_db("aaabatt_mainwebsite", $con); $name = mysql_real_escape_string($_POST['name']); $email = mysql_real_escape_string($_POST['email']); $comment = mysql_real_escape_string($_POST['comment']); $sql=("INSERT INTO Comments (name, email, comment) VALUES ('$name','$email','$comment')"); if (!mysql_query($sql,$con)) { die('Error: ' . mysql_error()); } mysql_close($con) ?> <?php //Redirect Browser header("Location: http://www.kishouvision.com/tutorials/commentshow.php"); ?> <html> <head> <title> </title> </head> <body> </body> </html>

Jan 23rd, 2008, 1:06 PM	#3
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 2,034 Rep Power: 6	Re: isset() help Someone should probably edit his post to censor his MySQL password. Just because it's localhost doesn't necessarily mean its safe.

Jan 23rd, 2008, 1:37 PM	#5
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 2,034 Rep Power: 6	Re: isset() help Thank goodness. ^_^ You had me worried. And while I'm here, to elaborate on kruptof's well-spotted catch: isset only checks to see if the variable exists. It's useful to stop a user from directly accessing the .php script (where no post data is being sent). In such an event, isset will return false for any corresponding $_POST keys.

Jan 23rd, 2008, 8:26 PM	#7
kishou Programmer Join Date: May 2007 Posts: 52 Rep Power: 2	Re: isset() help ok i figured out why lol. all i had to do was just change it to: if ($_POST['comment']==false) hahhah wow.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
BH Hotkeys	brownhead	Visual Basic	1	Apr 27th, 2006 6:42 PM

Programming Forums > Web Development and Design > PHP

isset() help