Programming Forums > Web Development and Design > PHP

drifter · Apr 10th, 2006, 1:56 PM

Ok, I have this code

<?php
	if( $content == NULL )
	{
	include(home . ".php");
	}
	else
	{
	$content = $_GET["content"];
	include($content . ".php");
	}
?>

when coupled with...

(Toggle Plain Text)

<a href="index.php?content=about">About</a>

it's suppose to link the "about.php" page, to the table cell on the site.

It was working before... for the longest time actually.
Suddenly and Randomly it isn't anymore.

Any Ideas?

Thanks

mongeau · Apr 10th, 2006, 2:17 PM

Did you recently upgrade your PHP?

EDIT: Just add "extract($_GET);" before the if statement. It will work.

drifter · Apr 10th, 2006, 2:22 PM

nope, I am using a WAMP server to test it, it worked(or did before today anyway) there.
And the site that it is being tested in is showing

PHP: 4.4.0-3.rhel3.art (/usr/bin/php)

as the version.

mongeau · Apr 10th, 2006, 2:24 PM

Read my post above...

Use "extract($_GET);" before your if statement. This will extract all GET variables.

The reason for this is simple. If you don't extract the $content variable before the statement, it is always going to be null because you haven't assigned it any value, and hence why it never enters the else part of your if statement. Just a bit of a logic error really. :p

Your updated code should look like this:

(Toggle Plain Text)

<?php
	extract($_GET); //extracts the $content variable
   
        if( $content == NULL )
	{
	     include(home . ".php");
	}
	else
	{
	     include($content . ".php");
	}
?>

Booooze · Apr 10th, 2006, 2:27 PM

check your php.ini for registered globals property. try changing. your $content value depends on whether or not the globals is turned on or off. that's probably why. it would also explain why it stopped working (thats if it changed).

mongeau · Apr 10th, 2006, 2:29 PM

Quote:

Originally Posted by Booooze

check your php.ini for registered globals property. try changing. your $content value depends on whether or not the globals is turned on or off. that's probably why. it would also explain why it stopped working.

Doubt it. Re-look at his if statement. He says if $content is null (which it always will be since he didn't extract the Get variables) then include home.php. He never enters the else part of the if statement, since the first part is always true. It has nothing to do with the php.ini file.

drifter · Apr 10th, 2006, 2:40 PM

Quote:

Originally Posted by mongeau

Read my post above...

Use "extract($_GET);" before your if statement. This will extract all GET variables.

The reason for this is simple. If you don't extract the $content variable before the statement, it is always going to be null because you haven't assigned it any value, and hence why it never enters the else part of your if statement. Just a bit of a logic error really. :p

Your updated code should look like this:

(Toggle Plain Text)

<?php
	extract($_GET); //extracts the $content variable
   
        if( $content == NULL )
	{
	     include(home . ".php");
	}
	else
	{
	     include($content . ".php");
	}
?>

That works, thanks alot!

Booooze · Apr 10th, 2006, 2:48 PM

Yeah, It was just along shot. If it was working earlier, then it wasn't likely. Plus he didn't upgrade php either. Just a suggestion, figured it shouldn't be overlooked.

ASHORY · Apr 10th, 2006, 5:32 PM

so why did you use
include(home . ".php");
like that not like that
include("home.php");

Ooble · Apr 10th, 2006, 7:41 PM

Using the extract function or turning on the register_globals setting is generally considered bad practice, as not conforming to strict PHP standards can result in loopholes and security flaws. Of course, the same could happen even without using these, but it's much less likely. I would personally do it like this:

[php]$content = isset($_GET['content']) ? $_GET['content'] : null;

if ($content)
{
include($content . '.php');
}
else
{
include('home.php');
}[/php]

Apr 10th, 2006, 1:56 PM	#1
drifter Programmer Join Date: Jul 2004 Location: Halifax, Nova Scotia Posts: 39 Rep Power: 0	Stupid Problem.... Ok, I have this code (Toggle Plain Text) <?php if( $content == NULL ) { include(home . ".php"); } else { $content = $_GET["content"]; include($content . ".php"); } ?> <?php if( $content == NULL ) { include(home . ".php"); } else { $content = $_GET["content"]; include($content . ".php"); } ?> when coupled with... (Toggle Plain Text) <a href="index.php?content=about">About</a> <a href="index.php?content=about">About</a> it's suppose to link the "about.php" page, to the table cell on the site. It was working before... for the longest time actually. Suddenly and Randomly it isn't anymore. Any Ideas? Thanks __________________ Only two things are infinite, the universe and human stupidity, and im not sure about the former.

Apr 10th, 2006, 2:17 PM	#2
mongeau Newbie Join Date: Apr 2006 Location: Fargo, ND Posts: 29 Rep Power: 0	Did you recently upgrade your PHP? EDIT: Just add "extract($_GET);" before the if statement. It will work. __________________ I wish I was you, so I could be friends with me.

Apr 10th, 2006, 2:22 PM	#3
drifter Programmer Join Date: Jul 2004 Location: Halifax, Nova Scotia Posts: 39 Rep Power: 0	nope, I am using a WAMP server to test it, it worked(or did before today anyway) there. And the site that it is being tested in is showing PHP: 4.4.0-3.rhel3.art (/usr/bin/php) as the version. __________________ Only two things are infinite, the universe and human stupidity, and im not sure about the former.

Apr 10th, 2006, 2:24 PM	#4
mongeau Newbie Join Date: Apr 2006 Location: Fargo, ND Posts: 29 Rep Power: 0	Read my post above... Use "extract($_GET);" before your if statement. This will extract all GET variables. The reason for this is simple. If you don't extract the $content variable before the statement, it is always going to be null because you haven't assigned it any value, and hence why it never enters the else part of your if statement. Just a bit of a logic error really. :p Your updated code should look like this: (Toggle Plain Text) <?php extract($_GET); //extracts the $content variable if( $content == NULL ) { include(home . ".php"); } else { include($content . ".php"); } ?> <?php extract($_GET); //extracts the $content variable if( $content == NULL ) { include(home . ".php"); } else { include($content . ".php"); } ?> __________________ I wish I was you, so I could be friends with me.

Apr 10th, 2006, 5:32 PM	#9
ASHORY Programmer Join Date: Dec 2004 Location: Egypt Posts: 30 Rep Power: 0	so why did you use include(home . ".php"); like that not like that include("home.php"); __________________ "^Ahmed.SHOukRY^" http://www.ashory.741.com

Apr 10th, 2006, 2:27 PM	#5
Booooze Expert Programmer Join Date: Mar 2006 Location: Igloo Posts: 710 Rep Power: 3	check your php.ini for registered globals property. try changing. your $content value depends on whether or not the globals is turned on or off. that's probably why. it would also explain why it stopped working (thats if it changed).

Apr 10th, 2006, 2:48 PM	#8
Booooze Expert Programmer Join Date: Mar 2006 Location: Igloo Posts: 710 Rep Power: 3	Yeah, It was just along shot. If it was working earlier, then it wasn't likely. Plus he didn't upgrade php either. Just a suggestion, figured it shouldn't be overlooked.

Apr 10th, 2006, 7:41 PM	#10
Ooble I eat cake for breakfast. Join Date: Jul 2004 Location: In my box. Posts: 4,434 Rep Power: 9	Using the extract function or turning on the register_globals setting is generally considered bad practice, as not conforming to strict PHP standards can result in loopholes and security flaws. Of course, the same could happen even without using these, but it's much less likely. I would personally do it like this: [php]$content = isset($_GET['content']) ? $_GET['content'] : null; if ($content) { include($content . '.php'); } else { include('home.php'); }[/php] __________________ Me :: You :: Them

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Programming Forums > Web Development and Design > PHP

Stupid Problem....