Programming Forums > Web Development and Design > PHP

grimpirate · Jan 27th, 2008, 8:59 PM

Made this function to filter out results from an array of arrays:

 php Syntax (Toggle Plain Text) 
<pre>
<?php
$data = array(
			array('volume' => 67, 'edition' => 2),
			array('volume' => 86, 'edition' => 1),
			array('volume' => 85, 'edition' => 6),
			array('volume' => 98, 'edition' => 2),
			array('volume' => 86, 'edition' => 6),
			array('volume' => 67, 'edition' => array(
				array('volume' => 67, 'edition' => 2),
				array('volume' => 86, 'edition' => 1),
				array('volume' => 85, 'edition' => 6),
				array('volume' => 98, 'edition' => 2),
				array('volume' => 86, 'edition' => 6),
				array('volume' => 67, 'edition' => array(
					array('volume' => 67, 'edition' => 2),
					array('volume' => 86, 'edition' => 1),
					array('volume' => 85, 'edition' => 6),
					array('volume' => 98, 'edition' => 2),
					array('volume' => 86, 'edition' => 6),
					array('volume' => 67, 'edition' => 7)
				))
			))
		);
 
$data = attenuate($data, 'edition', 'GTLT', 1, 9, 'volume', 'gt', 70);
print_r($data);
 
function attenuate(){
	switch(func_num_args()){
		case 0:
			return false;
			break;
		case 1:
			if(is_array(reset(func_get_args()))) return reset(func_get_args());
			else return false;
			break;
		default:
			$args = func_get_args();
			$data = array_shift($args);
			if(!is_array($data)) return false;
			if(is_array(reset($args))) $args = array_pop($args);
			$attenParam = array();
			reset($args);
			do{
				$temp = array();
				array_push($temp, current($args));	// attenuation key
				array_push($temp, next($args));		// attenuation range
				// attenuation values
				if(preg_match('/^((l|g)t){0,1}(eq){0,1}i*$/i', end($temp)))
					array_push($temp, array(next($args)));
				elseif(preg_match('/^((l|g)t)(?(?<=lt)(eq){0,1}gt(eq){0,1}|(eq){0,1}lt(eq){0,1})i*$/i', end($temp)))
					array_push($temp, array(next($args), next($args)));
				else
					return false;
				next($args);
				array_push($attenParam, $temp);
			}while(key($args) !== null);
 
			foreach($data as $dataKey => $dataValue){
				if(is_array($dataValue)){
					$dataValue = attenuate($dataValue, $args);
					if(count(array_diff_assoc($data[$dataKey], $dataValue)) > 0)
						unset($data[$dataKey]);
				}else{
					foreach($attenParam as $value){
						$key = reset($value);
						if(!strcmp($dataKey, $key)){
							$attenOp = next($value);
							$attenVal = end($value);
							$caseSensitive = true;
							if(stripos($attenOp, 'i') !== false) $caseSensitive = false;
							$attenOp = preg_replace('/i*/i', '', $attenOp);
							foreach($attenVal as $attenKey => $attenCond){
								if(is_string($dataValue)){
									if($caseSensitive)
										$attenVal[$attenKey] = strnatcmp($dataValue, $attenCond);
									else
										$attenVal[$attenKey] = strnatcasecmp($dataValue, $attenCond);
								}else{
									if($dataValue < $attenCond)
										$attenVal[$attenKey] = -1;
									elseif($dataValue > $attenCond)
										$attenVal[$attenKey] = 1;
									else
										$attenVal[$attenKey] = 0;
								}
							}
							if(!strcasecmp('EQ', $attenOp)){
								if(reset($attenVal) != 0)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GT', $attenOp)){
								if(reset($attenVal) != 1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GTEQ', $attenOp)){
								if(reset($attenVal) == -1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LT', $attenOp)){
								if(reset($attenVal) != -1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LTEQ', $attenOp)){
								if(reset($attenVal) == 1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GTLT', $attenOp)){
								if(reset($attenVal) < 1 || end($attenVal) > -1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GTEQLT', $attenOp)){
								if(reset($attenVal) < 0 || end($attenVal) > -1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LTGT', $attenOp)){
								if(reset($attenVal) > -1 && end($attenVal) < 1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LTEQGT', $attenOp)){
								if(reset($attenVal) > 0 && end($attenVal) < 1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GTLTEQ', $attenOp)){
								if(reset($attenVal) < 1 || end($attenVal) > 0)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GTEQLTEQ', $attenOp)){
								if(reset($attenVal) < 0 || end($attenVal) > 0)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LTGTEQ', $attenOp)){
								if(reset($attenVal) > -1 && end($attenVal) < 0)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LTEQGTEQ', $attenOp)){
								if(reset($attenVal) > 0 && end($attenVal) < 0)
									unset($data[$dataKey]);
							}
 
						}
					}
				}
			}
			return $data;
			break;
	}
}
?>
</pre>
<pre>
<?php
$data = array(
			array('volume' => 67, 'edition' => 2),
			array('volume' => 86, 'edition' => 1),
			array('volume' => 85, 'edition' => 6),
			array('volume' => 98, 'edition' => 2),
			array('volume' => 86, 'edition' => 6),
			array('volume' => 67, 'edition' => array(
				array('volume' => 67, 'edition' => 2),
				array('volume' => 86, 'edition' => 1),
				array('volume' => 85, 'edition' => 6),
				array('volume' => 98, 'edition' => 2),
				array('volume' => 86, 'edition' => 6),
				array('volume' => 67, 'edition' => array(
					array('volume' => 67, 'edition' => 2),
					array('volume' => 86, 'edition' => 1),
					array('volume' => 85, 'edition' => 6),
					array('volume' => 98, 'edition' => 2),
					array('volume' => 86, 'edition' => 6),
					array('volume' => 67, 'edition' => 7)
				))
			))
		);
		
$data = attenuate($data, 'edition', 'GTLT', 1, 9, 'volume', 'gt', 70);
print_r($data);

function attenuate(){
	switch(func_num_args()){
		case 0:
			return false;
			break;
		case 1:
			if(is_array(reset(func_get_args()))) return reset(func_get_args());
			else return false;
			break;
		default:
			$args = func_get_args();
			$data = array_shift($args);
			if(!is_array($data)) return false;
			if(is_array(reset($args))) $args = array_pop($args);
			$attenParam = array();
			reset($args);
			do{
				$temp = array();
				array_push($temp, current($args));	// attenuation key
				array_push($temp, next($args));		// attenuation range
				// attenuation values
				if(preg_match('/^((l|g)t){0,1}(eq){0,1}i*$/i', end($temp)))
					array_push($temp, array(next($args)));
				elseif(preg_match('/^((l|g)t)(?(?<=lt)(eq){0,1}gt(eq){0,1}|(eq){0,1}lt(eq){0,1})i*$/i', end($temp)))
					array_push($temp, array(next($args), next($args)));
				else
					return false;
				next($args);
				array_push($attenParam, $temp);
			}while(key($args) !== null);
			
			foreach($data as $dataKey => $dataValue){
				if(is_array($dataValue)){
					$dataValue = attenuate($dataValue, $args);
					if(count(array_diff_assoc($data[$dataKey], $dataValue)) > 0)
						unset($data[$dataKey]);
				}else{
					foreach($attenParam as $value){
						$key = reset($value);
						if(!strcmp($dataKey, $key)){
							$attenOp = next($value);
							$attenVal = end($value);
							$caseSensitive = true;
							if(stripos($attenOp, 'i') !== false) $caseSensitive = false;
							$attenOp = preg_replace('/i*/i', '', $attenOp);
							foreach($attenVal as $attenKey => $attenCond){
								if(is_string($dataValue)){
									if($caseSensitive)
										$attenVal[$attenKey] = strnatcmp($dataValue, $attenCond);
									else
										$attenVal[$attenKey] = strnatcasecmp($dataValue, $attenCond);
								}else{
									if($dataValue < $attenCond)
										$attenVal[$attenKey] = -1;
									elseif($dataValue > $attenCond)
										$attenVal[$attenKey] = 1;
									else
										$attenVal[$attenKey] = 0;
								}
							}
							if(!strcasecmp('EQ', $attenOp)){
								if(reset($attenVal) != 0)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GT', $attenOp)){
								if(reset($attenVal) != 1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GTEQ', $attenOp)){
								if(reset($attenVal) == -1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LT', $attenOp)){
								if(reset($attenVal) != -1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LTEQ', $attenOp)){
								if(reset($attenVal) == 1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GTLT', $attenOp)){
								if(reset($attenVal) < 1 || end($attenVal) > -1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GTEQLT', $attenOp)){
								if(reset($attenVal) < 0 || end($attenVal) > -1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LTGT', $attenOp)){
								if(reset($attenVal) > -1 && end($attenVal) < 1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LTEQGT', $attenOp)){
								if(reset($attenVal) > 0 && end($attenVal) < 1)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GTLTEQ', $attenOp)){
								if(reset($attenVal) < 1 || end($attenVal) > 0)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('GTEQLTEQ', $attenOp)){
								if(reset($attenVal) < 0 || end($attenVal) > 0)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LTGTEQ', $attenOp)){
								if(reset($attenVal) > -1 && end($attenVal) < 0)
									unset($data[$dataKey]);
							}elseif(!strcasecmp('LTEQGTEQ', $attenOp)){
								if(reset($attenVal) > 0 && end($attenVal) < 0)
									unset($data[$dataKey]);
							}
							
						}
					}
				}
			}
			return $data;
			break;
	}
}
?>
</pre>

I don't know seems like I'm doing too much, works well though. Here's the output

(Toggle Plain Text)

Array
(
    [2] => Array
        (
            [volume] => 85
            [edition] => 6
        )

    [3] => Array
        (
            [volume] => 98
            [edition] => 2
        )

    [4] => Array
        (
            [volume] => 86
            [edition] => 6
        )

)

Suggestions for improvement?

Sane · Jan 27th, 2008, 9:40 PM

Yikes. That does not look like a healthy piece of code at all.

Could you specify the input/output in the format of a problem statement?

More specifically, for every possible inputted array, what is the desired output? I can't bother myself to decipher your cryptic code. It would be easier if you explained.

grimpirate · Jan 27th, 2008, 10:45 PM

Input: array of values or of nested arrays
Procedure: unset values that are =, <, >, <=, >= (and permutations of those) of some range
Output: filtered array

titaniumdecoy · Jan 27th, 2008, 11:31 PM

I would create a function for each sort descriptor and build an array of containing references to the appropriate sort descriptors.

Sane · Jan 27th, 2008, 11:49 PM

I'm not sure if it's the same thing as what titaniumdecoy is saying, but I'm sure your code would be much more stable, readable, extendable, and simpler, if you were to write a callback function that does the desired filtering, and pass that callback function into 'attenuate'.

Attenuate then asks the callback function whether or not a specific item should be filtered.

Then it's left up to the one who's implementing the function to modify the callback, or pass through his/her own callback. It's also more powerful than leaving it up to the limitations of your debilitating 'GT/LT/EQ' scheme.

grimpirate · Jan 28th, 2008, 10:09 AM

Attenuate is the filtering function. It doesn't make much sense to me to write another function that would aid this one. I'd still have to know how they want to filter the results so I don't understand how the GT/LT/EQ is debilitating. I can explain algorithmically what the function is doing.

If 0 arguments are passed return an error
If 1 argument is passed return the array or return error
If more than one argument is passed assume the first argument is an array, if not return error
If remaining arguments were passed as an array pop them from the passed arguments array
Take the first argument of the remaining args and assume it is the key to filter by
Take the second argument of the remaining args and assume it is the operation to be performed
If the operation is LT|GT|EQ|LTEQ|GTEQ then only take one argument as the filter value
If the the operation is LTGT|GTLT|LTEQGT|GTEQLT|LTGTEQ|GTLTEQ|LTEQGTEQ|GTEQLTEQ then take the next two arguments as the filtering value
Repeat until there are no more arguments left
Look at each value of the array, if it's an array then recurse the function
If the returned result is different from the value then unset that portion of the array
If the value is not an array then proceed to filter results only if the key passed through parameters is the same as the current key of the data
If an i was present in the filtering operation then assume we want case insensitivity of strings
Check the actual value to determine if it is a string or not
Irrelevant of the type of checking denote that a value greater results in 1 a value less than results in -1 and equality results in 0
Based on the previous results and the operation type determine the range of values which satisfy the filtering operation and unset any that do not
Return the filtered array

Sane · Jan 28th, 2008, 10:53 AM

But you have one function that processes the array. And in that same function, you test whether or not it's a valid item to include. If you want to modify the method of filtering (not the values involved) you need to modify the entire outerworking of the same function that's doing the processing. That's bad coding.

Pass through a static callback function that will determine whether or not its argument is a valid item. The parts of your program that change become isolated from the static parts. Just leave it up to the one who's writing the callback function to worry about how it's being filtered.

If these specifications need to be set dynamically on run-time, according to the user's request, then you can work your way around that. But it's silly to invent your own ASCII logic gates to be interpreted with yet more boolean logic.

With this change you don't need to worry about your own wonky optional parameters. It would make your code capable of being changed in a second flat. The code would be much shorter and clearer. It would also fix your nest of around 11 indents for some of the blocks (horrific!). I suggest you stick to conventional coding unless there's a clear reason why it can not work more efficiently any other way.

As an aside, this very much reminds me of something from over a year ago... I went through almost this exact same situation as you are going through now. I wrote a hash table that would take optional parameters, in its lookup() function, to filter results on a set of logical conditions. I thought I was being clever because it replicated behaviour similar to MySQL, which does use ASCII logic.

But what did not occur to me, is my (brilliant) own logic scheme became absolutely useless as soon as I tried to interface a database client over top. My client could not control the optional parameters that went through, because optional parameters are specified statically on run-time. My method only worked as long as all interfacing to the lookup function was hard-coded.

The reason this logic scheme works for MySQL is because it's not as though their string is parsed into a list of parameters and then passed through a function, and reinterpreted. It's all handled in a very direct way. Presumably with some very clever algorithms too, such as the Horn formula framework. This isn't the only reason your custom approach can fail; it can be plain out difficult to work with, or the requirements of the algorithm can change. In which case you might need to extend the inner portion of your function to be even worse off than it is right now.

grimpirate · Jan 31st, 2008, 11:48 AM

Alright Sane this is what I managed to come up with after checking out the PHP site and reading what you were saying. I didn't quite understand you at first until I found this example on the PHP site.

 PHP Syntax (Toggle Plain Text) 
<pre>
<?php
$data = array(
			array('volume' => 67, 'edition' => 2),
			array('volume' => 86, 'edition' => 1),
			array('volume' => 85, 'edition' => 6),
			array('volume' => 98, 'edition' => 2),
			array('volume' => 86, 'edition' => 6),
			array('volume' => 67, 'edition' => array(
				array('volume' => 67, 'edition' => 2),
				array('volume' => 86, 'edition' => 1),
				array('volume' => 85, 'edition' => 6),
				array('volume' => 98, 'edition' => 2),
				array('volume' => 86, 'edition' => 6),
				array('volume' => 67, 'edition' => array(
					array('volume' => 67, 'edition' => 2),
					array('volume' => 86, 'edition' => 1),
					array('volume' => 85, 'edition' => 6),
					array('volume' => 98, 'edition' => 2),
					array('volume' => 86, 'edition' => 6),
					array('volume' => 67, 'edition' => 7)
				))
			))
		);
 
$callback_func = create_function('$key, $value', 'return ($value < 2 || $value > 70) ? true : false;');
 
print_r(array_filter_multi($data, $callback_func, null));
 
function array_filter_multi($array, $callback, $filtered_output = ""){
	$ret = array();
	foreach($array as $key=>$value){
		if($callback($key,$value)){
			if(is_array($value)){
				$ret[$key] = array_filter_multi($value, $callback, $filtered_output);
			}elseif(is_object($value)){
				$ret[$key] = array_filter_multi(get_object_vars($value), $callback, $filtered_output);
			}else{    
				$ret[$key]=$value;
			}
		}else{
			$ret[$key]=$filtered_output;
		}
	}
	return $ret;
}
?>
</pre>
<pre>
<?php
$data = array(
			array('volume' => 67, 'edition' => 2),
			array('volume' => 86, 'edition' => 1),
			array('volume' => 85, 'edition' => 6),
			array('volume' => 98, 'edition' => 2),
			array('volume' => 86, 'edition' => 6),
			array('volume' => 67, 'edition' => array(
				array('volume' => 67, 'edition' => 2),
				array('volume' => 86, 'edition' => 1),
				array('volume' => 85, 'edition' => 6),
				array('volume' => 98, 'edition' => 2),
				array('volume' => 86, 'edition' => 6),
				array('volume' => 67, 'edition' => array(
					array('volume' => 67, 'edition' => 2),
					array('volume' => 86, 'edition' => 1),
					array('volume' => 85, 'edition' => 6),
					array('volume' => 98, 'edition' => 2),
					array('volume' => 86, 'edition' => 6),
					array('volume' => 67, 'edition' => 7)
				))
			))
		);

$callback_func = create_function('$key, $value', 'return ($value < 2 || $value > 70) ? true : false;');

print_r(array_filter_multi($data, $callback_func, null));

function array_filter_multi($array, $callback, $filtered_output = ""){
	$ret = array();
	foreach($array as $key=>$value){
		if($callback($key,$value)){
			if(is_array($value)){
				$ret[$key] = array_filter_multi($value, $callback, $filtered_output);
			}elseif(is_object($value)){
				$ret[$key] = array_filter_multi(get_object_vars($value), $callback, $filtered_output);
			}else{    
				$ret[$key]=$value;
			}
		}else{
			$ret[$key]=$filtered_output;
		}
	}
	return $ret;
}
?>
</pre>

Sane · Jan 31st, 2008, 12:39 PM

Very nice!

If that still meets your initial requirements, I'd say that's a much nicer solution, yes?

And if you don't want to worry about the bad garbage cleanup of "create_function", you could also pass through a named function like so, I believe...

 PHP Syntax (Toggle Plain Text) 
function callback_func($key, $value) { return ($value < 2 || $value > 70); }
 
print_r(array_filter_multi($data, $callback_func, null));
function callback_func($key, $value) { return ($value < 2 || $value > 70); }

print_r(array_filter_multi($data, $callback_func, null));

I'm not as sure about that. But it should work.
By the way, ? true : false is a redundant statement.

grimpirate · Jan 31st, 2008, 3:22 PM

Ok here's what all of this was intended to do:

 PHP Syntax (Toggle Plain Text) 
<pre>
<?php
$data = array(
			array('volume' => 67, 'edition' => 2),
			array('volume' => 86, 'edition' => 1),
			array('volume' => 85, 'edition' => 6),
			array('volume' => 98, 'edition' => 2),
			array('volume' => 86, 'edition' => 6),
			array('volume' => 67, 'edition' => array(
				array('volume' => 67, 'edition' => 2),
				array('volume' => 86, 'edition' => 1),
				array('volume' => 85, 'edition' => 6),
				array('volume' => 98, 'edition' => 2),
				array('volume' => 86, 'edition' => 6),
				array('volume' => 67, 'edition' => array(
					array('volume' => 67, 'edition' => 2),
					array('volume' => 86, 'edition' => 1),
					array('volume' => 85, 'edition' => 6),
					array('volume' => 98, 'edition' => 2),
					array('volume' => 86, 'edition' => 6),
					array('volume' => 67, 'edition' => 7)
				))
			))
		);
 
$callback_func = create_function('$key, $value', 'return ($value < 8 || $value > 70);');
 
$output = array_filter_multi($data, $callback_func, null);
$output = array_transect($output, $data);
$output = array_liken($output, $data);
$output = cull($output, array(array('volume', SORT_ASC), array('edition', SORT_DESC)));
print_r($output);
 
function array_liken($new, $old){
	$ret = array();
	reset($new);
	reset($old);
	while(null !== $key = key($new)){
		$newValue = current($new);
		$oldValue = $old[$key];
		if(is_array($newValue)){
			if(count($newValue) == count($oldValue))
				$ret[$key]=$newValue;
				array_liken($newValue, $oldValue);
		}elseif(is_object($newValue)){
			if(count(get_object_vars($newValue)) == count(get_object_vars($oldValue)))
				$ret[$key]=$newValue;
				array_liken(get_object_vars($newValue), get_object_vars($oldValue));
		}else{
			$ret[$key]=$newValue;
		}
		next($new);
	}
	return $ret;
}
 
function array_transect($new, $old){
	$ret = array();
	reset($new);
	reset($old);
	while(null !== $key = key($new)){
		$newValue = current($new);
		$oldValue = $old

Jan 27th, 2008, 8:59 PM	#1
grimpirate King of Portal Join Date: Sep 2005 Posts: 431 Rep Power: 4	Function too convoluted? Made this function to filter out results from an array of arrays: php Syntax (Toggle Plain Text) <pre> <?php $data = array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => 7) )) )) ); $data = attenuate($data, 'edition', 'GTLT', 1, 9, 'volume', 'gt', 70); print_r($data); function attenuate(){ switch(func_num_args()){ case 0: return false; break; case 1: if(is_array(reset(func_get_args()))) return reset(func_get_args()); else return false; break; default: $args = func_get_args(); $data = array_shift($args); if(!is_array($data)) return false; if(is_array(reset($args))) $args = array_pop($args); $attenParam = array(); reset($args); do{ $temp = array(); array_push($temp, current($args)); // attenuation key array_push($temp, next($args)); // attenuation range // attenuation values if(preg_match('/^((l\|g)t){0,1}(eq){0,1}i$/i', end($temp))) array_push($temp, array(next($args))); elseif(preg_match('/^((l\|g)t)(?(?<=lt)(eq){0,1}gt(eq){0,1}\|(eq){0,1}lt(eq){0,1})i$/i', end($temp))) array_push($temp, array(next($args), next($args))); else return false; next($args); array_push($attenParam, $temp); }while(key($args) !== null); foreach($data as $dataKey => $dataValue){ if(is_array($dataValue)){ $dataValue = attenuate($dataValue, $args); if(count(array_diff_assoc($data[$dataKey], $dataValue)) > 0) unset($data[$dataKey]); }else{ foreach($attenParam as $value){ $key = reset($value); if(!strcmp($dataKey, $key)){ $attenOp = next($value); $attenVal = end($value); $caseSensitive = true; if(stripos($attenOp, 'i') !== false) $caseSensitive = false; $attenOp = preg_replace('/i/i', '', $attenOp); foreach($attenVal as $attenKey => $attenCond){ if(is_string($dataValue)){ if($caseSensitive) $attenVal[$attenKey] = strnatcmp($dataValue, $attenCond); else $attenVal[$attenKey] = strnatcasecmp($dataValue, $attenCond); }else{ if($dataValue < $attenCond) $attenVal[$attenKey] = -1; elseif($dataValue > $attenCond) $attenVal[$attenKey] = 1; else $attenVal[$attenKey] = 0; } } if(!strcasecmp('EQ', $attenOp)){ if(reset($attenVal) != 0) unset($data[$dataKey]); }elseif(!strcasecmp('GT', $attenOp)){ if(reset($attenVal) != 1) unset($data[$dataKey]); }elseif(!strcasecmp('GTEQ', $attenOp)){ if(reset($attenVal) == -1) unset($data[$dataKey]); }elseif(!strcasecmp('LT', $attenOp)){ if(reset($attenVal) != -1) unset($data[$dataKey]); }elseif(!strcasecmp('LTEQ', $attenOp)){ if(reset($attenVal) == 1) unset($data[$dataKey]); }elseif(!strcasecmp('GTLT', $attenOp)){ if(reset($attenVal) < 1 \|\| end($attenVal) > -1) unset($data[$dataKey]); }elseif(!strcasecmp('GTEQLT', $attenOp)){ if(reset($attenVal) < 0 \|\| end($attenVal) > -1) unset($data[$dataKey]); }elseif(!strcasecmp('LTGT', $attenOp)){ if(reset($attenVal) > -1 && end($attenVal) < 1) unset($data[$dataKey]); }elseif(!strcasecmp('LTEQGT', $attenOp)){ if(reset($attenVal) > 0 && end($attenVal) < 1) unset($data[$dataKey]); }elseif(!strcasecmp('GTLTEQ', $attenOp)){ if(reset($attenVal) < 1 \|\| end($attenVal) > 0) unset($data[$dataKey]); }elseif(!strcasecmp('GTEQLTEQ', $attenOp)){ if(reset($attenVal) < 0 \|\| end($attenVal) > 0) unset($data[$dataKey]); }elseif(!strcasecmp('LTGTEQ', $attenOp)){ if(reset($attenVal) > -1 && end($attenVal) < 0) unset($data[$dataKey]); }elseif(!strcasecmp('LTEQGTEQ', $attenOp)){ if(reset($attenVal) > 0 && end($attenVal) < 0) unset($data[$dataKey]); } } } } } return $data; break; } } ?> </pre> <pre> <?php $data = array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => 7) )) )) ); $data = attenuate($data, 'edition', 'GTLT', 1, 9, 'volume', 'gt', 70); print_r($data); function attenuate(){ switch(func_num_args()){ case 0: return false; break; case 1: if(is_array(reset(func_get_args()))) return reset(func_get_args()); else return false; break; default: $args = func_get_args(); $data = array_shift($args); if(!is_array($data)) return false; if(is_array(reset($args))) $args = array_pop($args); $attenParam = array(); reset($args); do{ $temp = array(); array_push($temp, current($args)); // attenuation key array_push($temp, next($args)); // attenuation range // attenuation values if(preg_match('/^((l\|g)t){0,1}(eq){0,1}i$/i', end($temp))) array_push($temp, array(next($args))); elseif(preg_match('/^((l\|g)t)(?(?<=lt)(eq){0,1}gt(eq){0,1}\|(eq){0,1}lt(eq){0,1})i$/i', end($temp))) array_push($temp, array(next($args), next($args))); else return false; next($args); array_push($attenParam, $temp); }while(key($args) !== null); foreach($data as $dataKey => $dataValue){ if(is_array($dataValue)){ $dataValue = attenuate($dataValue, $args); if(count(array_diff_assoc($data[$dataKey], $dataValue)) > 0) unset($data[$dataKey]); }else{ foreach($attenParam as $value){ $key = reset($value); if(!strcmp($dataKey, $key)){ $attenOp = next($value); $attenVal = end($value); $caseSensitive = true; if(stripos($attenOp, 'i') !== false) $caseSensitive = false; $attenOp = preg_replace('/i/i', '', $attenOp); foreach($attenVal as $attenKey => $attenCond){ if(is_string($dataValue)){ if($caseSensitive) $attenVal[$attenKey] = strnatcmp($dataValue, $attenCond); else $attenVal[$attenKey] = strnatcasecmp($dataValue, $attenCond); }else{ if($dataValue < $attenCond) $attenVal[$attenKey] = -1; elseif($dataValue > $attenCond) $attenVal[$attenKey] = 1; else $attenVal[$attenKey] = 0; } } if(!strcasecmp('EQ', $attenOp)){ if(reset($attenVal) != 0) unset($data[$dataKey]); }elseif(!strcasecmp('GT', $attenOp)){ if(reset($attenVal) != 1) unset($data[$dataKey]); }elseif(!strcasecmp('GTEQ', $attenOp)){ if(reset($attenVal) == -1) unset($data[$dataKey]); }elseif(!strcasecmp('LT', $attenOp)){ if(reset($attenVal) != -1) unset($data[$dataKey]); }elseif(!strcasecmp('LTEQ', $attenOp)){ if(reset($attenVal) == 1) unset($data[$dataKey]); }elseif(!strcasecmp('GTLT', $attenOp)){ if(reset($attenVal) < 1 \|\| end($attenVal) > -1) unset($data[$dataKey]); }elseif(!strcasecmp('GTEQLT', $attenOp)){ if(reset($attenVal) < 0 \|\| end($attenVal) > -1) unset($data[$dataKey]); }elseif(!strcasecmp('LTGT', $attenOp)){ if(reset($attenVal) > -1 && end($attenVal) < 1) unset($data[$dataKey]); }elseif(!strcasecmp('LTEQGT', $attenOp)){ if(reset($attenVal) > 0 && end($attenVal) < 1) unset($data[$dataKey]); }elseif(!strcasecmp('GTLTEQ', $attenOp)){ if(reset($attenVal) < 1 \|\| end($attenVal) > 0) unset($data[$dataKey]); }elseif(!strcasecmp('GTEQLTEQ', $attenOp)){ if(reset($attenVal) < 0 \|\| end($attenVal) > 0) unset($data[$dataKey]); }elseif(!strcasecmp('LTGTEQ', $attenOp)){ if(reset($attenVal) > -1 && end($attenVal) < 0) unset($data[$dataKey]); }elseif(!strcasecmp('LTEQGTEQ', $attenOp)){ if(reset($attenVal) > 0 && end($attenVal) < 0) unset($data[$dataKey]); } } } } } return $data; break; } } ?> </pre> I don't know seems like I'm doing too much, works well though. Here's the output (Toggle Plain Text) Array ( [2] => Array ( [volume] => 85 [edition] => 6 ) [3] => Array ( [volume] => 98 [edition] => 2 ) [4] => Array ( [volume] => 86 [edition] => 6 ) ) Array ( [2] => Array ( [volume] => 85 [edition] => 6 ) [3] => Array ( [volume] => 98 [edition] => 2 ) [4] => Array ( [volume] => 86 [edition] => 6 ) ) Suggestions for improvement? __________________ Lo, there do I see my father. 'Lo, there do I see My mother, and my sisters, and my brothers. 'Lo, there do I see The line of my people... Back to the beginning. 'Lo, they do call to me. They bid me take my place among them. In the halls of Valhalla... Where the brave... May live... ...forever.. GrimBB \| Mimesis

Jan 27th, 2008, 9:40 PM	#2
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 1,869 Rep Power: 5	Re: Function too convoluted? Yikes. That does not look like a healthy piece of code at all. Could you specify the input/output in the format of a problem statement? More specifically, for every possible inputted array, what is the desired output? I can't bother myself to decipher your cryptic code. It would be easier if you explained.

Jan 27th, 2008, 10:45 PM	#3
grimpirate King of Portal Join Date: Sep 2005 Posts: 431 Rep Power: 4	Re: Function too convoluted? Input: array of values or of nested arrays Procedure: unset values that are =, <, >, <=, >= (and permutations of those) of some range Output: filtered array __________________ Lo, there do I see my father. 'Lo, there do I see My mother, and my sisters, and my brothers. 'Lo, there do I see The line of my people... Back to the beginning. 'Lo, they do call to me. They bid me take my place among them. In the halls of Valhalla... Where the brave... May live... ...forever.. GrimBB \| Mimesis

Jan 27th, 2008, 11:31 PM	#4
titaniumdecoy Expert Programmer Join Date: Nov 2005 Posts: 855 Rep Power: 3	Re: Function too convoluted? I would create a function for each sort descriptor and build an array of containing references to the appropriate sort descriptors.

Jan 27th, 2008, 11:49 PM	#5
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 1,869 Rep Power: 5	Re: Function too convoluted? I'm not sure if it's the same thing as what titaniumdecoy is saying, but I'm sure your code would be much more stable, readable, extendable, and simpler, if you were to write a callback function that does the desired filtering, and pass that callback function into 'attenuate'. Attenuate then asks the callback function whether or not a specific item should be filtered. Then it's left up to the one who's implementing the function to modify the callback, or pass through his/her own callback. It's also more powerful than leaving it up to the limitations of your debilitating 'GT/LT/EQ' scheme.

Jan 28th, 2008, 10:09 AM	#6
grimpirate King of Portal Join Date: Sep 2005 Posts: 431 Rep Power: 4	Re: Function too convoluted? Attenuate is the filtering function. It doesn't make much sense to me to write another function that would aid this one. I'd still have to know how they want to filter the results so I don't understand how the GT/LT/EQ is debilitating. I can explain algorithmically what the function is doing. If 0 arguments are passed return an error If 1 argument is passed return the array or return error If more than one argument is passed assume the first argument is an array, if not return error If remaining arguments were passed as an array pop them from the passed arguments array Take the first argument of the remaining args and assume it is the key to filter by Take the second argument of the remaining args and assume it is the operation to be performed If the operation is LT\|GT\|EQ\|LTEQ\|GTEQ then only take one argument as the filter value If the the operation is LTGT\|GTLT\|LTEQGT\|GTEQLT\|LTGTEQ\|GTLTEQ\|LTEQGTEQ\|GTEQLTEQ then take the next two arguments as the filtering value Repeat until there are no more arguments left Look at each value of the array, if it's an array then recurse the function If the returned result is different from the value then unset that portion of the array If the value is not an array then proceed to filter results only if the key passed through parameters is the same as the current key of the data If an i was present in the filtering operation then assume we want case insensitivity of strings Check the actual value to determine if it is a string or not Irrelevant of the type of checking denote that a value greater results in 1 a value less than results in -1 and equality results in 0 Based on the previous results and the operation type determine the range of values which satisfy the filtering operation and unset any that do not Return the filtered array __________________ Lo, there do I see my father. 'Lo, there do I see My mother, and my sisters, and my brothers. 'Lo, there do I see The line of my people... Back to the beginning. 'Lo, they do call to me. They bid me take my place among them. In the halls of Valhalla... Where the brave... May live... ...forever.. GrimBB \| Mimesis

Jan 28th, 2008, 10:53 AM	#7
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 1,869 Rep Power: 5	Re: Function too convoluted? But you have one function that processes the array. And in that same function, you test whether or not it's a valid item to include. If you want to modify the method of filtering (not the values involved) you need to modify the entire outerworking of the same function that's doing the processing. That's bad coding. Pass through a static callback function that will determine whether or not its argument is a valid item. The parts of your program that change become isolated from the static parts. Just leave it up to the one who's writing the callback function to worry about how it's being filtered. If these specifications need to be set dynamically on run-time, according to the user's request, then you can work your way around that. But it's silly to invent your own ASCII logic gates to be interpreted with yet more boolean logic. With this change you don't need to worry about your own wonky optional parameters. It would make your code capable of being changed in a second flat. The code would be much shorter and clearer. It would also fix your nest of around 11 indents for some of the blocks (horrific!). I suggest you stick to conventional coding unless there's a clear reason why it can not work more efficiently any other way. As an aside, this very much reminds me of something from over a year ago... I went through almost this exact same situation as you are going through now. I wrote a hash table that would take optional parameters, in its lookup() function, to filter results on a set of logical conditions. I thought I was being clever because it replicated behaviour similar to MySQL, which does use ASCII logic. But what did not occur to me, is my (brilliant) own logic scheme became absolutely useless as soon as I tried to interface a database client over top. My client could not control the optional parameters that went through, because optional parameters are specified statically on run-time. My method only worked as long as all interfacing to the lookup function was hard-coded. The reason this logic scheme works for MySQL is because it's not as though their string is parsed into a list of parameters and then passed through a function, and reinterpreted. It's all handled in a very direct way. Presumably with some very clever algorithms too, such as the Horn formula framework. This isn't the only reason your custom approach can fail; it can be plain out difficult to work with, or the requirements of the algorithm can change. In which case you might need to extend the inner portion of your function to be even worse off than it is right now.

Jan 31st, 2008, 11:48 AM	#8
grimpirate King of Portal Join Date: Sep 2005 Posts: 431 Rep Power: 4	Re: Function too convoluted? Alright Sane this is what I managed to come up with after checking out the PHP site and reading what you were saying. I didn't quite understand you at first until I found this example on the PHP site. PHP Syntax (Toggle Plain Text) <pre> <?php $data = array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => 7) )) )) ); $callback_func = create_function('$key, $value', 'return ($value < 2 \|\| $value > 70) ? true : false;'); print_r(array_filter_multi($data, $callback_func, null)); function array_filter_multi($array, $callback, $filtered_output = ""){ $ret = array(); foreach($array as $key=>$value){ if($callback($key,$value)){ if(is_array($value)){ $ret[$key] = array_filter_multi($value, $callback, $filtered_output); }elseif(is_object($value)){ $ret[$key] = array_filter_multi(get_object_vars($value), $callback, $filtered_output); }else{ $ret[$key]=$value; } }else{ $ret[$key]=$filtered_output; } } return $ret; } ?> </pre> <pre> <?php $data = array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => array( array('volume' => 67, 'edition' => 2), array('volume' => 86, 'edition' => 1), array('volume' => 85, 'edition' => 6), array('volume' => 98, 'edition' => 2), array('volume' => 86, 'edition' => 6), array('volume' => 67, 'edition' => 7) )) )) ); $callback_func = create_function('$key, $value', 'return ($value < 2 \|\| $value > 70) ? true : false;'); print_r(array_filter_multi($data, $callback_func, null)); function array_filter_multi($array, $callback, $filtered_output = ""){ $ret = array(); foreach($array as $key=>$value){ if($callback($key,$value)){ if(is_array($value)){ $ret[$key] = array_filter_multi($value, $callback, $filtered_output); }elseif(is_object($value)){ $ret[$key] = array_filter_multi(get_object_vars($value), $callback, $filtered_output); }else{ $ret[$key]=$value; } }else{ $ret[$key]=$filtered_output; } } return $ret; } ?> </pre> __________________ Lo, there do I see my father. 'Lo, there do I see My mother, and my sisters, and my brothers. 'Lo, there do I see The line of my people... Back to the beginning. 'Lo, they do call to me. They bid me take my place among them. In the halls of Valhalla... Where the brave... May live... ...forever.. GrimBB \| Mimesis

Jan 31st, 2008, 12:39 PM	#9
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 1,869 Rep Power: 5	Re: Function too convoluted? Very nice! If that still meets your initial requirements, I'd say that's a much nicer solution, yes? And if you don't want to worry about the bad garbage cleanup of "create_function", you could also pass through a named function like so, I believe... PHP Syntax (Toggle Plain Text) function callback_func($key, $value) { return ($value < 2 \|\| $value > 70); } print_r(array_filter_multi($data, $callback_func, null)); function callback_func($key, $value) { return ($value < 2 \|\| $value > 70); } print_r(array_filter_multi($data, $callback_func, null)); I'm not as sure about that. But it should work. By the way, `? true : false` is a redundant statement.

Programming Forums > Web Development and Design > PHP

Function too convoluted?