Programming Forums > Application Development > C++

Z3nathur · Jul 31st, 2007, 6:25 PM

ok don't post a fixed version of this code(my guess is it wouldnt be trying for anyone here) i want to troubleshoot this one myself but i thought i might post it anyways to give you guys an idea of what i'm thinking about. Keep in mind i've only been looking at C++ code for about a day or so and tonight i'm headed out to buy a text for C++ programming. So i'm flying on logic and learning the basics by search.

(Toggle Plain Text)

#include <iostream>

using namespace std;

int main()
{
    float age = 0;
    float human_age;
    int state 1;
    int choice2; 
    char nothing;
    cout << "Welcome to Z3nathur's first conversion tool" << endl;
    
    while( state = 1)
    cout << "Choose your method of conversion and press enter to continue" << endl;
    cout << "1) Dog years -> Human Years" << endl;
    cout << "2) Human years -> Dog years" << endl;
    cin >> choice2;
        if (choice2 = 1)
        {
        cout << "How old is your dog in dog years?" << endl;
        cin >> age;
        human_age = age/7;
        cout << "Your dog is " << age << " years old in dog years and " << human_age << " years old in human years" << endl;
        cin.get();
        state ++;
        }
    
        if (choice2 = 2)
        {
        cout << "How old is your dog in human years?" << endl;
        cin >> human_age;
        age = human_age*7;
        cout << "Your dog is " << age << " years old in dog years and " << human_age << " years old in human years" << endl;
        cin.get();
        state ++;   
        }
    while( state = 2)
    {
    state = 1;
    }
    cout << "Press any key to continue";
    cin >> nothing;
    return 0;
}

snipertomcat · Jul 31st, 2007, 6:29 PM

First off, note that variables in c++ are one word (or words seperated by an underscore rather than a space).

EX:
int var
char char_variable
string this_is_a_string

Z3nathur · Jul 31st, 2007, 6:53 PM

hmm need to find a more portable solution for

(Toggle Plain Text)

 system("cls");

Z3nathur · Jul 31st, 2007, 6:55 PM

i meant to use a compilation of the two lines

(Toggle Plain Text)

 
int state;
state = 1;

Z3nathur · Jul 31st, 2007, 6:57 PM

which i have since changed lol. thanks though!

DaWei · Jul 31st, 2007, 8:31 PM

To test your code, enter things a careless user might enter instead of the things you expect. For instance, enter 'z' for age.

The Dark · Jul 31st, 2007, 9:15 PM

Remember to use braces around multiple statements e.g. (I fixed the indenting):

(Toggle Plain Text)

    while( state = 1)
      cout << "Choose your method of conversion and press enter to continue" << endl;
      cout << "1) Dog years -> Human Years" << endl;
      ....

will run the first cout over and over and never get to the second cout.
it should be

(Toggle Plain Text)

    while( state = 1)
    {
      cout << "Choose your method of conversion and press enter to continue" << endl;
      cout << "1) Dog years -> Human Years" << endl;
      ...
    }

While we are looking at the while statement, note that "=" is assignment, whereas "==" is comparison. So your while statement

(Toggle Plain Text)

    while( state = 1)

is assigning 1 to state and then checking whether it is non-zero. Change it to:

(Toggle Plain Text)

    while( state == 1)

Z3nathur · Aug 1st, 2007, 2:22 AM

man, i was NOT expecting this kind of support! thank you guys, seriously.

peace_of_mind · Aug 1st, 2007, 9:18 AM

I think you'll find that if you show that you're working on the problem yourself and always start by posting the code you already have worked on and have a bit of patience that you'll get this level of assistance pretty much every time.

Jul 31st, 2007, 6:25 PM	#1
Z3nathur Newbie Join Date: Jul 2007 Posts: 17 Rep Power: 0	Posting this so you can get an idea of what i'm thinking and overlooking ok don't post a fixed version of this code(my guess is it wouldnt be trying for anyone here) i want to troubleshoot this one myself but i thought i might post it anyways to give you guys an idea of what i'm thinking about. Keep in mind i've only been looking at C++ code for about a day or so and tonight i'm headed out to buy a text for C++ programming. So i'm flying on logic and learning the basics by search. (Toggle Plain Text) #include <iostream> using namespace std; int main() { float age = 0; float human_age; int state 1; int choice2; char nothing; cout << "Welcome to Z3nathur's first conversion tool" << endl; while( state = 1) cout << "Choose your method of conversion and press enter to continue" << endl; cout << "1) Dog years -> Human Years" << endl; cout << "2) Human years -> Dog years" << endl; cin >> choice2; if (choice2 = 1) { cout << "How old is your dog in dog years?" << endl; cin >> age; human_age = age/7; cout << "Your dog is " << age << " years old in dog years and " << human_age << " years old in human years" << endl; cin.get(); state ++; } if (choice2 = 2) { cout << "How old is your dog in human years?" << endl; cin >> human_age; age = human_age7; cout << "Your dog is " << age << " years old in dog years and " << human_age << " years old in human years" << endl; cin.get(); state ++; } while( state = 2) { state = 1; } cout << "Press any key to continue"; cin >> nothing; return 0; } #include <iostream> using namespace std; int main() { float age = 0; float human_age; int state 1; int choice2; char nothing; cout << "Welcome to Z3nathur's first conversion tool" << endl; while( state = 1) cout << "Choose your method of conversion and press enter to continue" << endl; cout << "1) Dog years -> Human Years" << endl; cout << "2) Human years -> Dog years" << endl; cin >> choice2; if (choice2 = 1) { cout << "How old is your dog in dog years?" << endl; cin >> age; human_age = age/7; cout << "Your dog is " << age << " years old in dog years and " << human_age << " years old in human years" << endl; cin.get(); state ++; } if (choice2 = 2) { cout << "How old is your dog in human years?" << endl; cin >> human_age; age = human_age7; cout << "Your dog is " << age << " years old in dog years and " << human_age << " years old in human years" << endl; cin.get(); state ++; } while( state = 2) { state = 1; } cout << "Press any key to continue"; cin >> nothing; return 0; }

Jul 31st, 2007, 6:29 PM	#2
snipertomcat Programmer Join Date: Nov 2005 Location: Spring Valley, CA Posts: 52 Rep Power: 3	First off, note that variables in c++ are one word (or words seperated by an underscore rather than a space). EX: int var char char_variable string this_is_a_string __________________ if (u=an_asshole) then GOTO (hell)

Jul 31st, 2007, 6:53 PM	#3
Z3nathur Newbie Join Date: Jul 2007 Posts: 17 Rep Power: 0	hmm need to find a more portable solution for (Toggle Plain Text) system("cls"); system("cls");

Jul 31st, 2007, 6:55 PM	#4
Z3nathur Newbie Join Date: Jul 2007 Posts: 17 Rep Power: 0	i meant to use a compilation of the two lines (Toggle Plain Text) int state; state = 1; int state; state = 1;

Jul 31st, 2007, 8:31 PM	#6
DaWei Resident Grouch Join Date: Jun 2005 Posts: 6,453 Rep Power: 10	To test your code, enter things a careless user might enter instead of the things you expect. For instance, enter 'z' for age. __________________ Abstraction doesn't make it impossible to write bad code; it makes it possible to write superior code. Contributor's Corner: Grumpy on C++ Exceptions DaWei on Pointers

Jul 31st, 2007, 6:57 PM	#5
Z3nathur Newbie Join Date: Jul 2007 Posts: 17 Rep Power: 0	which i have since changed lol. thanks though!

Jul 31st, 2007, 9:15 PM	#7
The Dark Expert Programmer Join Date: Jun 2005 Posts: 882 Rep Power: 4	Remember to use braces around multiple statements e.g. (I fixed the indenting): (Toggle Plain Text) while( state = 1) cout << "Choose your method of conversion and press enter to continue" << endl; cout << "1) Dog years -> Human Years" << endl; .... while( state = 1) cout << "Choose your method of conversion and press enter to continue" << endl; cout << "1) Dog years -> Human Years" << endl; .... will run the first cout over and over and never get to the second cout. it should be (Toggle Plain Text) while( state = 1) { cout << "Choose your method of conversion and press enter to continue" << endl; cout << "1) Dog years -> Human Years" << endl; ... } while( state = 1) { cout << "Choose your method of conversion and press enter to continue" << endl; cout << "1) Dog years -> Human Years" << endl; ... } While we are looking at the while statement, note that "=" is assignment, whereas "==" is comparison. So your while statement (Toggle Plain Text) while( state = 1) while( state = 1) is assigning 1 to state and then checking whether it is non-zero. Change it to: (Toggle Plain Text) while( state == 1) while( state == 1)

Aug 1st, 2007, 2:22 AM	#8
Z3nathur Newbie Join Date: Jul 2007 Posts: 17 Rep Power: 0	man, i was NOT expecting this kind of support! thank you guys, seriously.

Aug 1st, 2007, 9:18 AM	#9
peace_of_mind Professional Programmer Join Date: Sep 2004 Location: Hell if I know most of the time Posts: 439 Rep Power: 5	I think you'll find that if you show that you're working on the problem yourself and always start by posting the code you already have worked on and have a bit of patience that you'll get this level of assistance pretty much every time. __________________ Amateurs built the ark Professionals built the Titanic

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Programming Forums > Application Development > C++

Posting this so you can get an idea of what i'm thinking and overlooking