Programming Forums > Application Development > Visual Basic .NET

Jabo · Apr 20th, 2008, 4:43 AM

I have this code that will print and email results of pings. On my test pc, it works great, but on the production pc, it prints/emails multiple lines of the errors. I've tried re-publishing it and re-installing it and it's the same each time. The only thing I've changed from the time it worked correctly to now is making the ping loop 4 times for each entry. I've gone through the code several times and I can't figure out why it work differently on 2 pcs.

 vb Syntax (Toggle Plain Text) 
Do While sr.EndOfStream = False
                'Read in a line from file
                linecheck = sr.ReadLine
 
                'Check that line read isn't empty string and that it contains 2 parts, otherwise discard
                If ((linecheck = "") Or (linecheck.Contains(",") = False)) Then
                Else
                    'If ok, split read line and put in entry
                    entry = linecheck.Split(",")
                    Dim Ping As Ping = New Ping
                    Dim PingReply As PingReply
                    success = 0
                    For t As Integer = 0 To 3
                        If entry(0) = "y" Then
                            PingReply = Ping.Send(entry(1), 2000)
                            'Set current activity on toolstrip and cause repaint
                            tssActivity.Text = "Current Task: Pinging " & entry(2) & ": " & entry(1)
                            tssActivity.Invalidate()
                            'Set result parts 1 & 2 to current ping entry
                            line(0) = entry(2) & ": "
                            line(1) = entry(1)
                            'Set result part 3 (line(2)) to ping if success, error message if failed
                            If PingReply.Status = IPStatus.Success Then
                                line(2) = PingReply.RoundtripTime.ToString
                                success += 1
                            Else
                                line(2) = PingReply.Status.ToString
                                errtemp = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10)
                            End If
                        End If
                        Ping.Dispose()
                    Next
                End If
 
                If success = 0 Then
                    errstring += errtemp
                End If
 
                'Set result string (line(3))
                line(3) = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10)
                rtbResult.Text += line(3)
                'kill ping after used
                rtbResult.Invalidate()
                Me.Refresh()
            Loop
Do While sr.EndOfStream = False
                'Read in a line from file
                linecheck = sr.ReadLine

                'Check that line read isn't empty string and that it contains 2 parts, otherwise discard
                If ((linecheck = "") Or (linecheck.Contains(",") = False)) Then
                Else
                    'If ok, split read line and put in entry
                    entry = linecheck.Split(",")
                    Dim Ping As Ping = New Ping
                    Dim PingReply As PingReply
                    success = 0
                    For t As Integer = 0 To 3
                        If entry(0) = "y" Then
                            PingReply = Ping.Send(entry(1), 2000)
                            'Set current activity on toolstrip and cause repaint
                            tssActivity.Text = "Current Task: Pinging " & entry(2) & ": " & entry(1)
                            tssActivity.Invalidate()
                            'Set result parts 1 & 2 to current ping entry
                            line(0) = entry(2) & ": "
                            line(1) = entry(1)
                            'Set result part 3 (line(2)) to ping if success, error message if failed
                            If PingReply.Status = IPStatus.Success Then
                                line(2) = PingReply.RoundtripTime.ToString
                                success += 1
                            Else
                                line(2) = PingReply.Status.ToString
                                errtemp = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10)
                            End If
                        End If
                        Ping.Dispose()
                    Next
                End If

                If success = 0 Then
                    errstring += errtemp
                End If

                'Set result string (line(3))
                line(3) = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10)
                rtbResult.Text += line(3)
                'kill ping after used
                rtbResult.Invalidate()
                Me.Refresh()
            Loop

The lines of code I've added are 12, 13, 25, 32, and 35-37, otherwise, the program is unchanged. Works correctly from the IDE but not from the exe.

The weirdest thing about it is, sometimes it duplicates the message 3 or 4 times, sometimes as much as 15 times on the same entry. Each duplication is on a new line. Is it possible that it's not disposing the ping and just pinging the same server on the next round?

Unfortunately I can't attach to the process because I'm using VB Express.

Narue · Apr 20th, 2008, 8:50 AM

If your program works during debug but not release, or on one machine but not another, it's usually a concurrency or timing issue. You've got multiple threads or processes vying for the same resources, or you're trying to do something too fast or too slow.

Jabo · Apr 20th, 2008, 6:51 PM

Thanks Narue, that gives me something to chew on lol. If my program is multi-threaded, it's not intentional, since I know pretty much jack about multi-threading.

Since I have a 2 second timeout on my pings, maybe I should put a 3 second timer on each ping.

Jimbo · Apr 20th, 2008, 8:31 PM

Changing the timers won't necessarily fix the problem. Often the problem lies in accessing a shared resource or accessing an object. Also, if your program has a graphical UI (which I'm guessing, since you have it repaint), it is almost certainly multi-threaded.

Narue · Apr 21st, 2008, 7:06 AM

>maybe I should put a 3 second timer on each ping.
Only if you plan to use that for locating the source of the problem. Don't change a timer and expect the problem to be solved, that's like sweeping dirt under a rug.

Jabo · Apr 22nd, 2008, 6:19 PM

Well, I fixed the problem by moving the check for success into the IF statement. Now it only prints one instance of each error.

I still don't know why this caused the error.

 vb Syntax (Toggle Plain Text) 
Do While sr.EndOfStream = False
                'Read in a line from file
                linecheck = sr.ReadLine
 
                'Check that line read isn't empty string and that it contains 2 parts, otherwise discard
                If ((linecheck = "") Or (linecheck.Contains(",") = False)) Then
                Else
                    'If ok, split read line and put in entry
                    entry = linecheck.Split(",")
                    Dim Ping As Ping = New Ping
                    Dim PingReply As PingReply
                    success = 0
                    For t As Integer = 0 To 3
                        If entry(0) = "y" Then
                            PingReply = Ping.Send(entry(1), 2000)
                            'Set current activity on toolstrip and cause repaint
                            tssActivity.Text = "Current Task: Pinging " & entry(2) & ": " & entry(1)
                            tssActivity.Invalidate()
                            'Set result parts 1 & 2 to current ping entry
                            line(0) = entry(2) & ": "
                            line(1) = entry(1)
                            'Set result part 3 (line(2)) to ping if success, error message if failed
                            If PingReply.Status = IPStatus.Success Then
                                line(2) = PingReply.RoundtripTime.ToString
                                success += 1
                            Else
                                line(2) = PingReply.Status.ToString
                                errtemp = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10)
                            End If
                        End If
                        Ping.Dispose()
                    Next
                    If success = 0 Then
                        errstring += errtemp
                    End If                
               End If
 
 
                'Set result string (line(3))
                line(3) = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10)
                rtbResult.Text += line(3)
                'kill ping after used
                rtbResult.Invalidate()
                Me.Refresh()
            Loop
Do While sr.EndOfStream = False
                'Read in a line from file
                linecheck = sr.ReadLine

                'Check that line read isn't empty string and that it contains 2 parts, otherwise discard
                If ((linecheck = "") Or (linecheck.Contains(",") = False)) Then
                Else
                    'If ok, split read line and put in entry
                    entry = linecheck.Split(",")
                    Dim Ping As Ping = New Ping
                    Dim PingReply As PingReply
                    success = 0
                    For t As Integer = 0 To 3
                        If entry(0) = "y" Then
                            PingReply = Ping.Send(entry(1), 2000)
                            'Set current activity on toolstrip and cause repaint
                            tssActivity.Text = "Current Task: Pinging " & entry(2) & ": " & entry(1)
                            tssActivity.Invalidate()
                            'Set result parts 1 & 2 to current ping entry
                            line(0) = entry(2) & ": "
                            line(1) = entry(1)
                            'Set result part 3 (line(2)) to ping if success, error message if failed
                            If PingReply.Status = IPStatus.Success Then
                                line(2) = PingReply.RoundtripTime.ToString
                                success += 1
                            Else
                                line(2) = PingReply.Status.ToString
                                errtemp = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10)
                            End If
                        End If
                        Ping.Dispose()
                    Next
                    If success = 0 Then
                        errstring += errtemp
                    End If                
               End If

                
                'Set result string (line(3))
                line(3) = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10)
                rtbResult.Text += line(3)
                'kill ping after used
                rtbResult.Invalidate()
                Me.Refresh()
            Loop

Apr 20th, 2008, 4:43 AM	#1
Jabo Not a user? Join Date: Sep 2007 Posts: 245 Rep Power: 1	Difference between test and production? I have this code that will print and email results of pings. On my test pc, it works great, but on the production pc, it prints/emails multiple lines of the errors. I've tried re-publishing it and re-installing it and it's the same each time. The only thing I've changed from the time it worked correctly to now is making the ping loop 4 times for each entry. I've gone through the code several times and I can't figure out why it work differently on 2 pcs. vb Syntax (Toggle Plain Text) Do While sr.EndOfStream = False 'Read in a line from file linecheck = sr.ReadLine 'Check that line read isn't empty string and that it contains 2 parts, otherwise discard If ((linecheck = "") Or (linecheck.Contains(",") = False)) Then Else 'If ok, split read line and put in entry entry = linecheck.Split(",") Dim Ping As Ping = New Ping Dim PingReply As PingReply success = 0 For t As Integer = 0 To 3 If entry(0) = "y" Then PingReply = Ping.Send(entry(1), 2000) 'Set current activity on toolstrip and cause repaint tssActivity.Text = "Current Task: Pinging " & entry(2) & ": " & entry(1) tssActivity.Invalidate() 'Set result parts 1 & 2 to current ping entry line(0) = entry(2) & ": " line(1) = entry(1) 'Set result part 3 (line(2)) to ping if success, error message if failed If PingReply.Status = IPStatus.Success Then line(2) = PingReply.RoundtripTime.ToString success += 1 Else line(2) = PingReply.Status.ToString errtemp = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10) End If End If Ping.Dispose() Next End If If success = 0 Then errstring += errtemp End If 'Set result string (line(3)) line(3) = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10) rtbResult.Text += line(3) 'kill ping after used rtbResult.Invalidate() Me.Refresh() Loop Do While sr.EndOfStream = False 'Read in a line from file linecheck = sr.ReadLine 'Check that line read isn't empty string and that it contains 2 parts, otherwise discard If ((linecheck = "") Or (linecheck.Contains(",") = False)) Then Else 'If ok, split read line and put in entry entry = linecheck.Split(",") Dim Ping As Ping = New Ping Dim PingReply As PingReply success = 0 For t As Integer = 0 To 3 If entry(0) = "y" Then PingReply = Ping.Send(entry(1), 2000) 'Set current activity on toolstrip and cause repaint tssActivity.Text = "Current Task: Pinging " & entry(2) & ": " & entry(1) tssActivity.Invalidate() 'Set result parts 1 & 2 to current ping entry line(0) = entry(2) & ": " line(1) = entry(1) 'Set result part 3 (line(2)) to ping if success, error message if failed If PingReply.Status = IPStatus.Success Then line(2) = PingReply.RoundtripTime.ToString success += 1 Else line(2) = PingReply.Status.ToString errtemp = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10) End If End If Ping.Dispose() Next End If If success = 0 Then errstring += errtemp End If 'Set result string (line(3)) line(3) = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10) rtbResult.Text += line(3) 'kill ping after used rtbResult.Invalidate() Me.Refresh() Loop The lines of code I've added are 12, 13, 25, 32, and 35-37, otherwise, the program is unchanged. Works correctly from the IDE but not from the exe. The weirdest thing about it is, sometimes it duplicates the message 3 or 4 times, sometimes as much as 15 times on the same entry. Each duplication is on a new line. Is it possible that it's not disposing the ping and just pinging the same server on the next round? Unfortunately I can't attach to the process because I'm using VB Express.

Apr 20th, 2008, 8:50 AM	#2
Narue Professional Programmer Join Date: Sep 2005 Posts: 419 Rep Power: 3	Re: Difference between test and production? If your program works during debug but not release, or on one machine but not another, it's usually a concurrency or timing issue. You've got multiple threads or processes vying for the same resources, or you're trying to do something too fast or too slow. __________________ Even if the voices aren't real, they have some pretty good ideas.

Apr 20th, 2008, 6:51 PM	#3
Jabo Not a user? Join Date: Sep 2007 Posts: 245 Rep Power: 1	Re: Difference between test and production? Thanks Narue, that gives me something to chew on lol. If my program is multi-threaded, it's not intentional, since I know pretty much jack about multi-threading. Since I have a 2 second timeout on my pings, maybe I should put a 3 second timer on each ping.

Apr 20th, 2008, 8:31 PM	#4
Jimbo Battle Programmer Join Date: Feb 2006 Location: Bellevue, WA, USA Posts: 747 Rep Power: 3	Re: Difference between test and production? Changing the timers won't necessarily fix the problem. Often the problem lies in accessing a shared resource or accessing an object. Also, if your program has a graphical UI (which I'm guessing, since you have it repaint), it is almost certainly multi-threaded. __________________ <insert disclaimer here> <insert shameless plug for Visual Studio here>

Apr 21st, 2008, 7:06 AM	#5
Narue Professional Programmer Join Date: Sep 2005 Posts: 419 Rep Power: 3	Re: Difference between test and production? >maybe I should put a 3 second timer on each ping. Only if you plan to use that for locating the source of the problem. Don't change a timer and expect the problem to be solved, that's like sweeping dirt under a rug. __________________ Even if the voices aren't real, they have some pretty good ideas.

Apr 22nd, 2008, 6:19 PM	#6
Jabo Not a user? Join Date: Sep 2007 Posts: 245 Rep Power: 1	Re: Difference between test and production? Well, I fixed the problem by moving the check for success into the IF statement. Now it only prints one instance of each error. I still don't know why this caused the error. vb Syntax (Toggle Plain Text) Do While sr.EndOfStream = False 'Read in a line from file linecheck = sr.ReadLine 'Check that line read isn't empty string and that it contains 2 parts, otherwise discard If ((linecheck = "") Or (linecheck.Contains(",") = False)) Then Else 'If ok, split read line and put in entry entry = linecheck.Split(",") Dim Ping As Ping = New Ping Dim PingReply As PingReply success = 0 For t As Integer = 0 To 3 If entry(0) = "y" Then PingReply = Ping.Send(entry(1), 2000) 'Set current activity on toolstrip and cause repaint tssActivity.Text = "Current Task: Pinging " & entry(2) & ": " & entry(1) tssActivity.Invalidate() 'Set result parts 1 & 2 to current ping entry line(0) = entry(2) & ": " line(1) = entry(1) 'Set result part 3 (line(2)) to ping if success, error message if failed If PingReply.Status = IPStatus.Success Then line(2) = PingReply.RoundtripTime.ToString success += 1 Else line(2) = PingReply.Status.ToString errtemp = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10) End If End If Ping.Dispose() Next If success = 0 Then errstring += errtemp End If End If 'Set result string (line(3)) line(3) = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10) rtbResult.Text += line(3) 'kill ping after used rtbResult.Invalidate() Me.Refresh() Loop Do While sr.EndOfStream = False 'Read in a line from file linecheck = sr.ReadLine 'Check that line read isn't empty string and that it contains 2 parts, otherwise discard If ((linecheck = "") Or (linecheck.Contains(",") = False)) Then Else 'If ok, split read line and put in entry entry = linecheck.Split(",") Dim Ping As Ping = New Ping Dim PingReply As PingReply success = 0 For t As Integer = 0 To 3 If entry(0) = "y" Then PingReply = Ping.Send(entry(1), 2000) 'Set current activity on toolstrip and cause repaint tssActivity.Text = "Current Task: Pinging " & entry(2) & ": " & entry(1) tssActivity.Invalidate() 'Set result parts 1 & 2 to current ping entry line(0) = entry(2) & ": " line(1) = entry(1) 'Set result part 3 (line(2)) to ping if success, error message if failed If PingReply.Status = IPStatus.Success Then line(2) = PingReply.RoundtripTime.ToString success += 1 Else line(2) = PingReply.Status.ToString errtemp = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10) End If End If Ping.Dispose() Next If success = 0 Then errstring += errtemp End If End If 'Set result string (line(3)) line(3) = line(0) & Chr(13) & Chr(10) & line(1) & Chr(9) & Chr(9) & "Ping: " & line(2) & Chr(13) & Chr(10) rtbResult.Text += line(3) 'kill ping after used rtbResult.Invalidate() Me.Refresh() Loop

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Programming Forums > Application Development > Visual Basic .NET

Difference between test and production?