Programming Forums > Application Development > C++

KuraKai · Mar 1st, 2008, 2:11 PM

I am trying to read from the registry and there is issues with trying to query it, it can get to where the value is located but it can't find the value for some odd reason. Here is the code I am currently running.

 C++ Syntax (Toggle Plain Text) 
#include <cstdlib>
#include <iostream>
#include "windows.h"
#include "winnt.h"
#include "winreg.h"
 
using namespace std;
 
int main(int argc, char *argv[])
{
    HKEY MyKey;
 
    char szBuff[80];
    LONG cb;
 
    if (RegOpenKey(HKEY_CURRENT_USER, "Software\\Random\\Program", &MyKey) == ERROR_SUCCESS)
    {
       cout << "Program is installed\n";
       cb = sizeof(szBuff);
 
       //Debug info, this normally isn't here!
       printf("%d",RegQueryValue(MyKey, "hexData", szBuff, &cb) );
       cout << '\n';
 
       if(RegQueryValue(MyKey, "hexData, szBuff, &cb) == ERROR_SUCCESS)
       {
          cout << "Program has been run once\n";
          printf(szBuff);
       }
 
       RegCloseKey(MyKey);
    }
 
    system("PAUSE");
    return EXIT_SUCCESS;
}
 
#include <cstdlib>
#include <iostream>
#include "windows.h"
#include "winnt.h"
#include "winreg.h"

using namespace std;

int main(int argc, char *argv[])
{
    HKEY MyKey;
    
    char szBuff[80];
    LONG cb;

    if (RegOpenKey(HKEY_CURRENT_USER, "Software\\Random\\Program", &MyKey) == ERROR_SUCCESS)
    {
       cout << "Program is installed\n";
       cb = sizeof(szBuff);
       
       //Debug info, this normally isn't here!
       printf("%d",RegQueryValue(MyKey, "hexData", szBuff, &cb) );
       cout << '\n';

       if(RegQueryValue(MyKey, "hexData, szBuff, &cb) == ERROR_SUCCESS)
       {
          cout << "Program has been run once\n";
          printf(szBuff);
       }

       RegCloseKey(MyKey);
    }

    system("PAUSE");
    return EXIT_SUCCESS;
}

The value that it should be printing out 0611623CA8EFE3D880FF72E0F9A5AACDE5D9C171EAE2C6FDB6888BF7B5386DEE , however it can't find it even though it should be there. Any help with this?

Ancient Dragon · Mar 1st, 2008, 4:58 PM

are you certain that's exactly the code you compiled? line 25 has syntax error -- you need to close the quote after "hexData.

KuraKai · Mar 1st, 2008, 5:01 PM

Oops, but that isn't the exact code, I cut out the pieces that where for something else. (Mostly all the commented out parts of previous tries at getting it right.) But that is what i use for this specific part.

Ancient Dragon · Mar 1st, 2008, 5:05 PM

After fixing the quote error and adding that key/string value to my registry this is what you program prints

Quote:

Program is installed
2
Press any key to continue . . .

Seems to work for me, but maybe the registry entry on your computer isn't the same as you said it is in the program code.

KuraKai · Mar 1st, 2008, 5:09 PM

No, if it was working properly it should find the registry and actually say

Quote:

Program is installed
1
Program has been run once
0611623CA8EFE3D880FF72E0F9A5AACDE5D9C171EAE2C6FDB6888BF7B5386DEE
Press any key to continue . . .

The 2 means there was an error when it tries to query for the value, if it found the value it should print it out also.

Ancient Dragon · Mar 1st, 2008, 5:28 PM

I changed your program to call RegQueryKeyEx() and it works now

 cplusplus Syntax (Toggle Plain Text) 
int main(int argc, char *argv[])
{
    HKEY MyKey = 0;
 
    BYTE szBuff[255] = {0};
    DWORD cb = 0;
    DWORD dwType = REG_SZ;
    LONG rval;
    if (RegOpenKey(HKEY_CURRENT_USER, "Software\\Random\\Program", &MyKey) == ERROR_SUCCESS)
    {
       cout << "Program is installed\n";
       cb = sizeof(szBuff);
 
       //Debug info, this normally isn't here!
 
       if((rval = RegQueryValueEx(MyKey, "hexData", 0, &dwType, szBuff, &cb)) == ERROR_SUCCESS)
       {
          cout << "Program has been run once\n";
          printf((char *)szBuff);
       }
       printf("%d",rval);
       cout << '\n';
 
       RegCloseKey(MyKey);
    }
 
    system("PAUSE");
    return EXIT_SUCCESS;
}
int main(int argc, char *argv[])
{
    HKEY MyKey = 0;
    
    BYTE szBuff[255] = {0};
    DWORD cb = 0;
    DWORD dwType = REG_SZ;
    LONG rval;
    if (RegOpenKey(HKEY_CURRENT_USER, "Software\\Random\\Program", &MyKey) == ERROR_SUCCESS)
    {
       cout << "Program is installed\n";
       cb = sizeof(szBuff);
       
       //Debug info, this normally isn't here!

       if((rval = RegQueryValueEx(MyKey, "hexData", 0, &dwType, szBuff, &cb)) == ERROR_SUCCESS)
       {
          cout << "Program has been run once\n";
          printf((char *)szBuff);
       }
       printf("%d",rval);
       cout << '\n';

       RegCloseKey(MyKey);
    }

    system("PAUSE");
    return EXIT_SUCCESS;
}

And the output is

Quote:

Program is installed
Program has been run once
0611623CA8EFE3D880FF72E0F9A5AACDE5D9C171EAE2C6FDB6888BF7B5386DEE0
Press any key to continue . . .

KuraKai · Mar 1st, 2008, 5:36 PM

Alrighty thank you, for some odd reason that didn't work before for me...But also you didn't do a '\n' after printing out the registry value. And thanks again for the help.

Ancient Dragon · Mar 1st, 2008, 5:39 PM

The code as posted could use a little clearning up, such as don't mix both cout and printf(). I didn't bother with that, especially since you said this is only a small part of some larger program.

KuraKai · Mar 1st, 2008, 6:48 PM

I have a quick question about the same topic, how would i modify this if i was going to query multiple values that are in the same location?

Ancient Dragon · Mar 1st, 2008, 7:01 PM

RegEnumVal(). There is an example program near the bottom of that web page.

Mar 1st, 2008, 2:11 PM	#1
KuraKai Newbie Join Date: Mar 2008 Posts: 25 Rep Power: 0	RegQueryValue Issues I am trying to read from the registry and there is issues with trying to query it, it can get to where the value is located but it can't find the value for some odd reason. Here is the code I am currently running. C++ Syntax (Toggle Plain Text) #include <cstdlib> #include <iostream> #include "windows.h" #include "winnt.h" #include "winreg.h" using namespace std; int main(int argc, char argv[]) { HKEY MyKey; char szBuff[80]; LONG cb; if (RegOpenKey(HKEY_CURRENT_USER, "Software\\Random\\Program", &MyKey) == ERROR_SUCCESS) { cout << "Program is installed\n"; cb = sizeof(szBuff); //Debug info, this normally isn't here! printf("%d",RegQueryValue(MyKey, "hexData", szBuff, &cb) ); cout << '\n'; if(RegQueryValue(MyKey, "hexData, szBuff, &cb) == ERROR_SUCCESS) { cout << "Program has been run once\n"; printf(szBuff); } RegCloseKey(MyKey); } system("PAUSE"); return EXIT_SUCCESS; } #include <cstdlib> #include <iostream> #include "windows.h" #include "winnt.h" #include "winreg.h" using namespace std; int main(int argc, char argv[]) { HKEY MyKey; char szBuff[80]; LONG cb; if (RegOpenKey(HKEY_CURRENT_USER, "Software\\Random\\Program", &MyKey) == ERROR_SUCCESS) { cout << "Program is installed\n"; cb = sizeof(szBuff); //Debug info, this normally isn't here! printf("%d",RegQueryValue(MyKey, "hexData", szBuff, &cb) ); cout << '\n'; if(RegQueryValue(MyKey, "hexData, szBuff, &cb) == ERROR_SUCCESS) { cout << "Program has been run once\n"; printf(szBuff); } RegCloseKey(MyKey); } system("PAUSE"); return EXIT_SUCCESS; } The value that it should be printing out 0611623CA8EFE3D880FF72E0F9A5AACDE5D9C171EAE2C6FDB6888BF7B5386DEE , however it can't find it even though it should be there. Any help with this?

Mar 1st, 2008, 4:58 PM	#2
Ancient Dragon PFO God In Training Join Date: Jun 2005 Location: near St Louis, MO. (USA) Posts: 530 Rep Power: 4	Re: RegQueryValue Issues are you certain that's exactly the code you compiled? line 25 has syntax error -- you need to close the quote after "hexData. __________________ I Like Ike. Vote for Dwight Eisenhower this November. --This message brought to you by the the Procrastinators Club Of America.

Mar 1st, 2008, 5:01 PM	#3
KuraKai Newbie Join Date: Mar 2008 Posts: 25 Rep Power: 0	Re: RegQueryValue Issues Oops, but that isn't the exact code, I cut out the pieces that where for something else. (Mostly all the commented out parts of previous tries at getting it right.) But that is what i use for this specific part.

Mar 1st, 2008, 5:36 PM	#7
KuraKai Newbie Join Date: Mar 2008 Posts: 25 Rep Power: 0	Re: RegQueryValue Issues Alrighty thank you, for some odd reason that didn't work before for me...But also you didn't do a '\n' after printing out the registry value. And thanks again for the help.

Mar 1st, 2008, 5:39 PM	#8
Ancient Dragon PFO God In Training Join Date: Jun 2005 Location: near St Louis, MO. (USA) Posts: 530 Rep Power: 4	Re: RegQueryValue Issues The code as posted could use a little clearning up, such as don't mix both cout and printf(). I didn't bother with that, especially since you said this is only a small part of some larger program. __________________ I Like Ike. Vote for Dwight Eisenhower this November. --This message brought to you by the the Procrastinators Club Of America.

Mar 1st, 2008, 6:48 PM	#9
KuraKai Newbie Join Date: Mar 2008 Posts: 25 Rep Power: 0	Re: RegQueryValue Issues I have a quick question about the same topic, how would i modify this if i was going to query multiple values that are in the same location?

Mar 1st, 2008, 7:01 PM	#10
Ancient Dragon PFO God In Training Join Date: Jun 2005 Location: near St Louis, MO. (USA) Posts: 530 Rep Power: 4	Re: RegQueryValue Issues RegEnumVal(). There is an example program near the bottom of that web page. __________________ I Like Ike. Vote for Dwight Eisenhower this November. --This message brought to you by the the Procrastinators Club Of America.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
LWP form Data array issues	Johnmcter	Perl	0	Feb 13th, 2008 2:21 PM
Intermittent issues	blud	Community Announcements and Feedback	3	Nov 2nd, 2007 8:46 AM
Table issues...	Glastea	HTML / XHTML / CSS	2	Jan 12th, 2007 1:54 AM
I have an idea, but copyright issues.	Booooze	Project Ideas	25	Aug 3rd, 2006 9:31 PM

Programming Forums > Application Development > C++

RegQueryValue Issues