Programming Forums
User Name Password Register
 

RSS Feed
FORUM INDEX | TODAY'S POSTS | UNANSWERED THREADS | ADVANCED SEARCH

Reply
 
Thread Tools Display Modes
Old May 28th, 2007, 1:12 AM   #1
mrynit
Hobbyist Programmer
 
mrynit's Avatar
 
Join Date: Mar 2006
Location: WA, USA
Posts: 332
Rep Power: 3 mrynit is on a distinguished road
Send a message via AIM to mrynit Send a message via MSN to mrynit Send a message via Yahoo to mrynit Send a message via Skype™ to mrynit
intensive code review

this is the capstone project for my GUI programming class. my group is making a program to handle and manage studnets and tutors signing in and out of the schools math center.

so far we have a basic sign in and out for studnents with time stamping, adding new students, reading and writing student list to disk. when the program loads it checks to see if the file of students exists then reads it or makes a new one. the tutor tab doesnt do anything. the admin tab is buggy but the change student info works.it is not finished and is a work in progerss.

Would you all please look over our code and see what should be changed, comment style, class structure, better OO modling, problem solving, break up the large class file into smaller peaces and so on.
Attached Files
File Type: zip capStone.zip (9.2 KB, 28 views)
__________________
i dont know much about programming but i try to help
mrynit is offline   Reply With Quote
Old May 29th, 2007, 11:36 AM   #2
msi_333
Newbie
 
msi_333's Avatar
 
Join Date: May 2007
Location: Egypt
Posts: 19
Rep Power: 0 msi_333 is on a distinguished road
Send a message via Yahoo to msi_333
Good Work

I think you made a very good work.The GUI is excellent.








Computer Science & Information Technology Engineer.
My Place on the net :
http://www.codemiles.com

Last edited by msi_333; May 29th, 2007 at 11:49 AM.
msi_333 is offline   Reply With Quote
Old May 30th, 2007, 6:16 PM   #3
mrynit
Hobbyist Programmer
 
mrynit's Avatar
 
Join Date: Mar 2006
Location: WA, USA
Posts: 332
Rep Power: 3 mrynit is on a distinguished road
Send a message via AIM to mrynit Send a message via MSN to mrynit Send a message via Yahoo to mrynit Send a message via Skype™ to mrynit
i am more conserned about the code rather than how it looks
__________________
i dont know much about programming but i try to help
mrynit is offline   Reply With Quote
Old May 31st, 2007, 4:05 AM   #4
andro
Professional Programmer
 
Join Date: Oct 2005
Location: California
Posts: 311
Rep Power: 3 andro is on a distinguished road
Send a message via AIM to andro
If it were mine I would definitely make an effort at moving some code out of MathTracker.java. There's way too much in there that could easily be moved to other classes imo.
andro is offline   Reply With Quote
Old May 31st, 2007, 10:37 AM   #5
mrynit
Hobbyist Programmer
 
mrynit's Avatar
 
Join Date: Mar 2006
Location: WA, USA
Posts: 332
Rep Power: 3 mrynit is on a distinguished road
Send a message via AIM to mrynit Send a message via MSN to mrynit Send a message via Yahoo to mrynit Send a message via Skype™ to mrynit
Quote:
Originally Posted by andro View Post
If it were mine I would definitely make an effort at moving some code out of MathTracker.java. There's way too much in there that could easily be moved to other classes imo.
why? all the code is related. more lines means its better!
__________________
i dont know much about programming but i try to help
mrynit is offline   Reply With Quote
Old May 31st, 2007, 12:08 PM   #6
xavier
Professional Programmer
 
xavier's Avatar
 
Join Date: Oct 2004
Location: .ro
Posts: 383
Rep Power: 4 xavier is on a distinguished road
Send a message via Yahoo to xavier
Actually all the classes in MathTracker.java should stay in separate files. There's no point in making one big file.
Quote:
more lines means its better!
That, you could explain a bit . Why is that better?
__________________
Don't take life too seriously, it's not permanent !
xavier is offline   Reply With Quote
Old May 31st, 2007, 4:45 PM   #7
msi_333
Newbie
 
msi_333's Avatar
 
Join Date: May 2007
Location: Egypt
Posts: 19
Rep Power: 0 msi_333 is on a distinguished road
Send a message via Yahoo to msi_333
Yes

IT is a good Design is to make small classes and using OOP Concepts ,to make it readable and easy to understand and also easy to add more function to it
msi_333 is offline   Reply With Quote
Old May 31st, 2007, 8:47 PM   #8
mrynit
Hobbyist Programmer
 
mrynit's Avatar
 
Join Date: Mar 2006
Location: WA, USA
Posts: 332
Rep Power: 3 mrynit is on a distinguished road
Send a message via AIM to mrynit Send a message via MSN to mrynit Send a message via Yahoo to mrynit Send a message via Skype™ to mrynit
Quote:
Originally Posted by xavier View Post
Actually all the classes in MathTracker.java should stay in separate files. There's no point in making one big file.
That, you could explain a bit . Why is that better?
That it what my group thinks. I know it is wrong. it should be split into many separate classes. It is quite logical to separate it for the tabs, at least, considering each tab has a lot of methods and anonymous classes for action listeners.

do you have any suggestions to convise my group to slipt it up? I said it was way too difficult to browse the file considering there are like 30 methods and 10 classes all in one file! args!!
__________________
i dont know much about programming but i try to help
mrynit is offline   Reply With Quote
Old May 31st, 2007, 11:19 PM   #9
xavier
Professional Programmer
 
xavier's Avatar
 
Join Date: Oct 2004
Location: .ro
Posts: 383
Rep Power: 4 xavier is on a distinguished road
Send a message via Yahoo to xavier
Well, what if : your GUI would be 10times more complex ? what then? there's no point in making a 3000 lines file. Imagine working on line 789 and 1934 . It would be a nightmare. Similar code is grouped in separate folders: You can have a folder for the GUI stuff and another for the rest of your logic ... and so on , depending on your project.

+ what msi_333 said
Quote:
It is a good Design is to make small classes and using OOP Concepts ,to make it readable and easy to understand and also easy to add more function to it

And another thing: What if you had 2 windows . The first being MathTracker.java and the next Something.java, and they would need essentially the same inner classes .What would you do then ? where would you put the inner classes ? Something.java or MathTracker.java ). The best place for them is in other files.
__________________
Don't take life too seriously, it's not permanent !
xavier is offline   Reply With Quote
Old May 31st, 2007, 11:39 PM   #10
mrynit
Hobbyist Programmer
 
mrynit's Avatar
 
Join Date: Mar 2006
Location: WA, USA
Posts: 332
Rep Power: 3 mrynit is on a distinguished road
Send a message via AIM to mrynit Send a message via MSN to mrynit Send a message via Yahoo to mrynit Send a message via Skype™ to mrynit
thanks. I do understand these reasons, I just have a hard time explaining what I know is right to people. I will write these notes down and present it to the group. I hope i don't come off as a conceited smart ass.
__________________
i dont know much about programming but i try to help
mrynit is offline   Reply With Quote
Reply

Bookmarks

« Previous Thread in Forum | Next Thread in Forum »

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
review my code mrynit Java 8 Apr 29th, 2007 10:52 PM
EXECryptor software protection Jean5 C++ 35 Oct 10th, 2006 7:10 PM
How to post a question nnxion C++ 10 Jun 3rd, 2005 11:53 AM
How to post a question nnxion C++ 0 Jun 3rd, 2005 8:55 AM
How to post a question nnxion C 0 Jun 3rd, 2005 8:55 AM




DaniWeb IT Discussion Community
All times are GMT -5. The time now is 3:46 PM.

Powered by vBulletin® Version 3.7.0, Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
Copyright ©2007 DaniWeb® LLC