Programming Forums > Projects > Show Off Your Open Source Projects

Master · Mar 21st, 2007, 6:05 PM

This is my first crack at making a game maker, so i would be glad if anyone here can test my engine and post some feedback on the blog. Thanks :-)

Link: http://phoenixengine.blogspot.com/

Sane · Mar 21st, 2007, 6:15 PM

Quick comment about your site:

http://www.iomegatrix.com/Downloads/code.txt

I don't think your Python code does what your Ruby code does. It doesn't even compile.

Master · Mar 21st, 2007, 6:46 PM

Thanks for letting me know, i have updated it. The problem was because i did not tab the code.

Sane · Mar 21st, 2007, 7:05 PM

It's still wrong. You have return s on the wrong identation level. Plus you're doing some other whacky things. Why do you append to the string for all clauses except the else clause?

(Toggle Plain Text)

class Point:

    def __init__(self, x = 0, y = 0):
        self.x , self.y = x, y

    def __str__(self):
        if (self.x < 0) : 
            s = "a value in is too small"
        elif (self.x > -1 and self.y > -1):
            s = "x = " + str(self.x) + " y = " + str(self.y)
        else:
            s = "<Point " + str(self) + " >"
        return s

mypoint = Point()
# print str(mypoint)

But I don't even know what the Ruby code does... so, meh.

Master · Mar 21st, 2007, 10:08 PM

Quote:

Originally Posted by Sane

It's still wrong. You have return s on the wrong identation level. Plus you're doing some other whacky things. Why do you append to the string for all clauses except the else clause?

(Toggle Plain Text)

class Point:

    def __init__(self, x = 0, y = 0):
        self.x , self.y = x, y

    def __str__(self):
        if (self.x < 0) : 
            s = "a value in is too small"
        elif (self.x > -1 and self.y > -1):
            s = "x = " + str(self.x) + " y = " + str(self.y)
        else:
            s = "<Point " + str(self) + " >"
        return s

mypoint = Point()
# print str(mypoint)

But I don't even know what the Ruby code does... so, meh.

I tested the code and it works

. The s on the right indent. The point of the code is to show how to use if and else compare to ruby. Some part of the code is not need but to show an example.

The sample is basically a point class, which can be used to store x and y point. And when the #toString method is called, it print what ever result is set for the to_s in ruby and calls __str__ for python.

Sane · Mar 21st, 2007, 10:17 PM

Uhhh... if you don't return s, str(my_point) will display a nullified NoneType variable. No s is being returned for the default case of (x, y) = (0, 0).

Run your code with the line "print str(mypoint)" at the bottom:

(Toggle Plain Text)

>>> print str(mypoint)
TypeError: __str__ returned non-string (type NoneType)

My version of your code shows the (presumably) correct output:

(Toggle Plain Text)

>>> print str(mypoint)
x = 0 y = 0

Master · Mar 21st, 2007, 11:06 PM

Can you post it. I will be glad to update it

Sane · Mar 21st, 2007, 11:32 PM

I already did.

Master · Mar 22nd, 2007, 4:27 PM

Sorry, i did not realized it

Game_Ender · Mar 25th, 2007, 5:26 PM

You are also missing out on one common python idiom, iteration. You do this:

 python Syntax (Toggle Plain Text) 
for i in range(0, len(Players)):
    player = Players[i]
    # loop code ...
for i in range(0, len(Players)):
    player = Players[i]
    # loop code ...

When you should go:

 python Syntax (Toggle Plain Text) 
for i, player in enumerate(Players):
    # loop code ...
for i, player in enumerate(Players):
    # loop code ...

Mar 21st, 2007, 6:05 PM	#1
Master Programmer Join Date: Sep 2005 Location: GA Posts: 99 Rep Power: 4	Phoenix Engine.NET This is my first crack at making a game maker, so i would be glad if anyone here can test my engine and post some feedback on the blog. Thanks :-) Link: http://phoenixengine.blogspot.com/

Mar 21st, 2007, 6:15 PM	#2
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 2,030 Rep Power: 6	Quick comment about your site: http://www.iomegatrix.com/Downloads/code.txt I don't think your Python code does what your Ruby code does. It doesn't even compile. __________________ Looking for tough programming challenges? Try participating in Sane's Monthly Algorithms Challenges! Composing Techno is a little side hobby of mine. Techno by DJ Sane. All free for download.

Mar 21st, 2007, 7:05 PM	#4
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 2,030 Rep Power: 6	It's still wrong. You have return s on the wrong identation level. Plus you're doing some other whacky things. Why do you append to the string for all clauses except the else clause? (Toggle Plain Text) class Point: def __init__(self, x = 0, y = 0): self.x , self.y = x, y def __str__(self): if (self.x < 0) : s = "a value in is too small" elif (self.x > -1 and self.y > -1): s = "x = " + str(self.x) + " y = " + str(self.y) else: s = "<Point " + str(self) + " >" return s mypoint = Point() # print str(mypoint) class Point: def __init__(self, x = 0, y = 0): self.x , self.y = x, y def __str__(self): if (self.x < 0) : s = "a value in is too small" elif (self.x > -1 and self.y > -1): s = "x = " + str(self.x) + " y = " + str(self.y) else: s = "<Point " + str(self) + " >" return s mypoint = Point() # print str(mypoint) But I don't even know what the Ruby code does... so, meh. __________________ Looking for tough programming challenges? Try participating in Sane's Monthly Algorithms Challenges! Composing Techno is a little side hobby of mine. Techno by DJ Sane. All free for download.

Mar 21st, 2007, 10:17 PM	#6
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 2,030 Rep Power: 6	Uhhh... if you don't return s, str(my_point) will display a nullified NoneType variable. No s is being returned for the default case of (x, y) = (0, 0). Run your code with the line "print str(mypoint)" at the bottom: (Toggle Plain Text) >>> print str(mypoint) TypeError: __str__ returned non-string (type NoneType) >>> print str(mypoint) TypeError: __str__ returned non-string (type NoneType) My version of your code shows the (presumably) correct output: (Toggle Plain Text) >>> print str(mypoint) x = 0 y = 0 >>> print str(mypoint) x = 0 y = 0 __________________ Looking for tough programming challenges? Try participating in Sane's Monthly Algorithms Challenges! Composing Techno is a little side hobby of mine. Techno by DJ Sane. All free for download.

Mar 21st, 2007, 11:32 PM	#8
Sane Programming Guru Join Date: Apr 2005 Location: Waterloo, Ontario Posts: 2,030 Rep Power: 6	I already did. __________________ Looking for tough programming challenges? Try participating in Sane's Monthly Algorithms Challenges! Composing Techno is a little side hobby of mine. Techno by DJ Sane. All free for download.

Mar 21st, 2007, 6:46 PM	#3
Master Programmer Join Date: Sep 2005 Location: GA Posts: 99 Rep Power: 4	Thanks for letting me know, i have updated it. The problem was because i did not tab the code.

Mar 21st, 2007, 11:06 PM	#7
Master Programmer Join Date: Sep 2005 Location: GA Posts: 99 Rep Power: 4	Can you post it. I will be glad to update it

Mar 22nd, 2007, 4:27 PM	#9
Master Programmer Join Date: Sep 2005 Location: GA Posts: 99 Rep Power: 4	Sorry, i did not realized it

Mar 25th, 2007, 5:26 PM	#10
Game_Ender Professional Programmer Join Date: May 2006 Location: Maryland, USA Posts: 306 Rep Power: 3	You are also missing out on one common python idiom, iteration. You do this: python Syntax (Toggle Plain Text) for i in range(0, len(Players)): player = Players[i] # loop code ... for i in range(0, len(Players)): player = Players[i] # loop code ... When you should go: python Syntax (Toggle Plain Text) for i, player in enumerate(Players): # loop code ... for i, player in enumerate(Players): # loop code ... __________________ Robotics @ Maryland AUV Team - Software Lead

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[C#] Phoenix - freeware delivery system	g3cka	Paid Job Offers	14	Jan 2nd, 2007 6:29 AM

Programming Forums > Projects > Show Off Your Open Source Projects

Phoenix Engine.NET